DaanHoogland commented on code in PR #9531:
URL: https://github.com/apache/cloudstack/pull/9531#discussion_r1719469109
##########
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java:
##########
@@ -24,8 +24,13 @@
import com.cloud.utils.Pair;
import com.cloud.utils.Ternary;
import com.cloud.utils.db.GenericDao;
+import org.apache.cloudstack.framework.config.ConfigKey;
public interface CapacityDao extends GenericDao<CapacityVO, Long> {
+
+ ConfigKey<Boolean> allowRoutersOnDedicatedResources = new
ConfigKey<>("Advanced", Boolean.class, "allow.routers.on.dedicated.resources",
"false",
Review Comment:
I'm a bit weary having `Dao`s be `Configurable`s. Can this be setting be
moved to the `Planner`-hierarchy somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
