Re: [PR] [VMware] Update data disk controller same as the root disk controller type when it is not set in the VM detail [cloudstack]

2024-07-22 Thread via GitHub
codecov[bot] commented on PR #9433: URL: https://github.com/apache/cloudstack/pull/9433#issuecomment-2244375222 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9433?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [VMware] Update data disk controller same as the root disk controller type when it is not set in the VM detail [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9433: URL: https://github.com/apache/cloudstack/pull/9433#issuecomment-2244366503 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] [VMware] Update data disk controller same as the root disk controller type when it is not set in the VM detail [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9433: URL: https://github.com/apache/cloudstack/pull/9433#issuecomment-2244363442 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] [VMware] Update data disk controller same as the root disk controller type when it is not set in the VM detail [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti opened a new pull request, #9433: URL: https://github.com/apache/cloudstack/pull/9433 ### Description This PR updates data disk controller (in VMware) same as the root disk controller type when it is not set in the VM detail. This is to ensure the disk controller is av

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2244264409 [SF] Trillian test result (tid-10935) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 62561 seconds Marvin logs: https://github.co

Re: [I] After using Migrate Data from Image Store, new snapshots on moved disks failing [cloudstack]

2024-07-22 Thread via GitHub
nxsbi commented on issue #9430: URL: https://github.com/apache/cloudstack/issues/9430#issuecomment-2244242831 > @nxsbi I gather this is a Xen environment. Are there a chain of snapshots present for the given volume? If yes, have all the snapshots belonging to the chain been migrated to the

(cloudstack-kubernetes-provider) branch support-acl updated (a0377310 -> 98fbfc55)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git omit a0377310 skip adding network ACLs if network tier uses default ACL add 98fbfc55

(cloudstack-kubernetes-provider) branch support-acl updated (0bf987b6 -> a0377310)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git from 0bf987b6 address comments - oob exception check add a0377310 skip adding networ

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2244233572 [SF] Trillian test result (tid-10938) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 59025 seconds Marvin logs: https://github.c

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2244233130 [SF] Trillian test result (tid-10939) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58933 seconds Marvin logs: https://github.co

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2244222554 [SF] Trillian test result (tid-10937) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58318 seconds Marvin logs: https://github.c

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2244212440 [SF] Trillian test result (tid-10940) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52185 seconds Marvin logs: https://github.co

Re: [I] After using Migrate Data from Image Store, new snapshots on moved disks failing [cloudstack]

2024-07-22 Thread via GitHub
Pearl1594 commented on issue #9430: URL: https://github.com/apache/cloudstack/issues/9430#issuecomment-2244194996 @nxsbi I gather this is a Xen environment. Are there a chain of snapshots present for the given volume? If yes, have all the snapshots belonging to the chain been migrated to th

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2244189919 [SF] Trillian test result (tid-10934) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 57359 seconds Marvin logs: https://github.c

(cloudstack) branch nsx-integration-fixes updated (97339840972 -> 9c1df1d0200)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration-fixes in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 97339840972 remove unused import add 9c1df1d0200 remove duplicate imports No new revision

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2244166629 [SF] Trillian test result (tid-10933) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 55646 seconds Marvin logs: https://github.c

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2244074500 [SF] Trillian test result (tid-10932) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 59404 seconds Marvin logs: https://github.com

Re: [PR] add procedures procedure [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2244001778 [SF] Trillian test result (tid-10936) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43631 seconds Marvin logs: https://github.co

Re: [PR] Improvements to quota tariffs APIs and UI [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9225: URL: https://github.com/apache/cloudstack/pull/9225#issuecomment-2243982381 [SF] Trillian test result (tid-10931) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 52924 seconds Marvin logs: https://github.com

Re: [PR] API: Fix missing keys in listZonesMetrics response [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9419: URL: https://github.com/apache/cloudstack/pull/9419#issuecomment-2243979381 [SF] Trillian test result (tid-10930) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54045 seconds Marvin logs: https://github.co

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2243940975 [LL]Trillian test result (tid-6962) Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8 Total time taken: 46628 seconds Marvin logs: https://github.com/b

[I] Missing events on project operations [cloudstack]

2024-07-22 Thread via GitHub
nvazquez opened a new issue, #9432: URL: https://github.com/apache/cloudstack/issues/9432 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Events ~~~ # CLOUDSTACK VERSION ~~~ 4.18, 4.19, 4.20 ~~~ # CONFIGURATION N/A

[I] After using Migrate Data from Image Store, new snapshots on moved disks failing [cloudstack]

2024-07-22 Thread via GitHub
nxsbi opened a new issue, #9430: URL: https://github.com/apache/cloudstack/issues/9430 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION XCP-NG

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1687132627 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -266,6 +273,12 @@ public class VpcManagerImpl extends ManagerBase implements VpcManag

(cloudstack) branch nsx-integration-fixes updated (89aa0a5c37e -> 97339840972)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration-fixes in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 89aa0a5c37e Externalize retries and inverval for NSX segment deletion (#67) add 973398409

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1687059826 ## api/src/main/java/org/apache/cloudstack/api/command/admin/bgp/CreateASNRangeCmd.java: ## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (AS

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1687058002 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -266,6 +273,12 @@ public class VpcManagerImpl extends ManagerBase implements VpcManag

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243646016 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243642646 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243640593 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10440 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
hsato03 commented on code in PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#discussion_r1686997066 ## framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java: ## @@ -437,9 +437,11 @@ public List searchIncludingRemoved(SearchCriteria sc, final Filter fil

Re: [I] UI: guest network options greyed out [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on issue #9413: URL: https://github.com/apache/cloudstack/issues/9413#issuecomment-2243579331 > @weizhouapache, can you share the API response for listnetworks? I don't see the `account` field returned on my instance. @poddm The account is not returned in

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243533657 [SF] Trillian Build Failed (tid-10942) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243526040 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243521399 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243523155 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2243522730 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

(cloudstack) branch nsx-integration-fixes updated (0163da4ffaa -> 89aa0a5c37e)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration-fixes in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0163da4ffaa fix logger add 0c615312f95 log messages (#9093) add 87b55af1979 Fixup res

Re: [I] UI: guest network options greyed out [cloudstack]

2024-07-22 Thread via GitHub
poddm commented on issue #9413: URL: https://github.com/apache/cloudstack/issues/9413#issuecomment-2243419380 @weizhouapache, can you share the API response for listnetworks? I don't see the `account` field returned on my instance. -- This is an automated message from the Apache Git Serv

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686769179 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void v

Re: [PR] fix removeSecondaryStorageSelector response for docs [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9264: URL: https://github.com/apache/cloudstack/pull/9264#issuecomment-2243255745 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10439 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686753378 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void valid

(cloudstack-kubernetes-provider) branch support-acl updated (549f6880 -> 0bf987b6)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git from 549f6880 increase log verbosity add 0bf987b6 address comments - oob exception c

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686742214 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void v

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
JoaoJandre commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2243183135 > > @DaanHoogland can BO export the agent's logs? There seems to be an error in the snapshot creation, but with only the MGMTs logs I'm unable to trace it properly > > good f

(cloudstack-kubernetes-provider) branch support-acl updated (e8546ff0 -> 549f6880)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git from e8546ff0 address comment: delete only 1 matching rule, in case ACL is shared betwee

(cloudstack-kubernetes-provider) branch support-acl updated (5b4c48ca -> e8546ff0)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git from 5b4c48ca revert docker image changes add e8546ff0 address comment: delete only

Re: [PR] fix removeSecondaryStorageSelector response for docs [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9264: URL: https://github.com/apache/cloudstack/pull/9264#issuecomment-2243088496 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] fix removeSecondaryStorageSelector response for docs [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on PR #9264: URL: https://github.com/apache/cloudstack/pull/9264#issuecomment-2243085787 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686629136 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void valid

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686629136 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void valid

Re: [PR] Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9415: URL: https://github.com/apache/cloudstack/pull/9415#issuecomment-2243066617 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

2024-07-22 Thread via GitHub
vishesh92 commented on PR #9415: URL: https://github.com/apache/cloudstack/pull/9415#issuecomment-2243065133 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] fix removeSecondaryStorageSelector response for docs [cloudstack]

2024-07-22 Thread via GitHub
BryanMLima commented on PR #9264: URL: https://github.com/apache/cloudstack/pull/9264#issuecomment-2243014411 CLGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#issuecomment-2243000136 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10438 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686542701 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -6412,6 +6420,23 @@ public NetworkOffering createNetworkOffering(final Cr

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2242952879 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10437 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix 4.17.2 upgrade schema idempotent add column order [cloudstack]

2024-07-22 Thread via GitHub
nvazquez commented on PR #9427: URL: https://github.com/apache/cloudstack/pull/9427#issuecomment-2242937271 Thanks @weizhouapache - I haven't seen that PR, will close this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Fix 4.17.2 upgrade schema idempotent add column order [cloudstack]

2024-07-22 Thread via GitHub
nvazquez closed pull request #9427: Fix 4.17.2 upgrade schema idempotent add column order URL: https://github.com/apache/cloudstack/pull/9427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686530796 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void v

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686530796 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -839,7 +848,7 @@ private void v

(cloudstack-kubernetes-provider) branch support-acl updated (8b5d72bc -> 5b4c48ca)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git discard 8b5d72bc revert docker image changes add 5b4c48ca revert docker image changes

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2242918931 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

(cloudstack-kubernetes-provider) branch support-acl updated (95f5c080 -> 8b5d72bc)

2024-07-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch support-acl in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git from 95f5c080 remove debug logs add 8b5d72bc revert docker image changes No new rev

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2242917149 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2242916152 > @DaanHoogland can BO export the agent's logs? There seems to be an error in the snapshot creation, but with only the MGMTs logs I'm unable to trace it properly good featu

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#issuecomment-2242844733 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
codecov[bot] commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2242841752 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9428?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#issuecomment-2242841010 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on code in PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#discussion_r1686470531 ## engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41910to42000.java: ## @@ -80,4 +85,32 @@ public void updateSystemVmTemplates(Connection conn) {

Re: [PR] Fix 4.17.2 upgrade schema idempotent add column order [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on PR #9427: URL: https://github.com/apache/cloudstack/pull/9427#issuecomment-2242832666 to be frank, I like @DaanHoogland's idea in #9385 more, which will permanently fix all the similar issues -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2242829353 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9428: URL: https://github.com/apache/cloudstack/pull/9428#issuecomment-2242827322 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Fix root disk resize (don't allow) when service offering has root disk size, only allow through service offering change [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti opened a new pull request, #9428: URL: https://github.com/apache/cloudstack/pull/9428 ### Description This PR fixes root disk resize (don't allow) when service offering has root disk size, only allow through service offering change. Fixes #9380

Re: [PR] Fix 4.17.2 upgrade schema idempotent add column order [cloudstack]

2024-07-22 Thread via GitHub
codecov[bot] commented on PR #9427: URL: https://github.com/apache/cloudstack/pull/9427#issuecomment-2242813883 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9427?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Fix 4.17.2 upgrade schema idempotent add column order [cloudstack]

2024-07-22 Thread via GitHub
nvazquez opened a new pull request, #9427: URL: https://github.com/apache/cloudstack/pull/9427 ### Description This PR adds a fix for an upgrade issue found from 4.17.2 to 4.19.1. The IDEMPOTENT_ADD_COLUMN procedure was not found and the upgrade has failed with the following er

Re: [PR] Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9415: URL: https://github.com/apache/cloudstack/pull/9415#issuecomment-2242767827 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10436 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Failed add volume when instance running on VMware use VMware Paravirtual SCSI controller [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on issue #9400: URL: https://github.com/apache/cloudstack/issues/9400#issuecomment-2242763723 I'm able to reproduce this, seems attach data volume tried to use LSI Logic SCSI controller and failed, as it's not available. All four controllers created, are Paravirtual

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242755947 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This i

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-07-22 Thread via GitHub
JoaoJandre commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2242755711 @DaanHoogland can BO export the agent's logs? There seems to be an error in the snapshot creation, but with only the MGMTs logs I'm unable to trace it properly -- This is an auto

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242752054 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242746043 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10435 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2242745336 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10434 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#issuecomment-2242741347 > [SF] Trillian test result (tid-10914) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58597 seconds Marvin logs: https://github.com/bl

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on code in PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#discussion_r1686400408 ## engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41910to42000.java: ## @@ -80,4 +85,32 @@ public void updateSystemVmTemplates(Connection conn) {

Re: [PR] Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements [cloudstack]

2024-07-22 Thread via GitHub
harikrishna-patnala commented on code in PR #9340: URL: https://github.com/apache/cloudstack/pull/9340#discussion_r1686392058 ## engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41910to42000.java: ## @@ -80,4 +85,32 @@ public void updateSystemVmTemplates(Connection conn)

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2242712240 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This i

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2242710122 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
DaanHoogland commented on code in PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#discussion_r1686340539 ## test/integration/smoke/test_purge_expunged_vms.py: ## @@ -349,15 +353,18 @@ def test_05_purge_expunged_vm_service_offering(self): @skipTestIf("hyperviso

Re: [I] Can not change size root disk instances [cloudstack]

2024-07-22 Thread via GitHub
harikrishna-patnala commented on issue #9380: URL: https://github.com/apache/cloudstack/issues/9380#issuecomment-2242696581 I think this is kind of design thing, the error message says "Failed to resize Root volume. The service offering of this Volume has been configured with a root

Re: [I] Can not change size root disk instances [cloudstack]

2024-07-22 Thread via GitHub
sureshanaparti commented on issue #9380: URL: https://github.com/apache/cloudstack/issues/9380#issuecomment-2242681918 able to reproduce this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] WIP - Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9415: URL: https://github.com/apache/cloudstack/pull/9415#issuecomment-2242648847 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] WIP - Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

2024-07-22 Thread via GitHub
vishesh92 commented on PR #9415: URL: https://github.com/apache/cloudstack/pull/9415#issuecomment-2242645240 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] AS Numbers Management [cloudstack]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #9410: URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686331368 ## engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql: ## @@ -154,3 +154,47 @@ WHERE -- Quota inject tariff result into subsequent ones C

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242616135 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
shwstppr commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242613800 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-07-22 Thread via GitHub
shwstppr commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2242611161 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2242612346 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] test: improve purge expunged resources b/g task testcase [cloudstack]

2024-07-22 Thread via GitHub
codecov[bot] commented on PR #9426: URL: https://github.com/apache/cloudstack/pull/9426#issuecomment-2242610244 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9426?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-07-22 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2242609544 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10433 -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >