hsato03 commented on code in PR #9340:
URL: https://github.com/apache/cloudstack/pull/9340#discussion_r1686997066
##########
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##########
@@ -437,9 +437,11 @@ public List<T> searchIncludingRemoved(SearchCriteria<T>
sc, final Filter filter,
}
return result;
} catch (final SQLException e) {
- throw new CloudRuntimeException("DB Exception on: " + pstmt, e);
+ logger.error("DB Exception on: " + pstmt, e);
Review Comment:
```suggestion
logger.error("DB Exception on: {}", pstmt, e);
```
The parameterized log message can also be used in the other logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
