Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2136510728 [SF] Trillian test result (tid-10309) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 56625 seconds Marvin logs: https://github.com

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2136349321 [SF] Trillian test result (tid-10308) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44310 seconds Marvin logs: https://github.co

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2136243033 [SF] Trillian test result (tid-10307) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43797 seconds Marvin logs: https://github.co

[PR] Add unit tests for null cpu for null parameters for set allocated cpu [cloudstack]

2024-05-28 Thread via GitHub
charlesweng opened a new pull request, #9137: URL: https://github.com/apache/cloudstack/pull/9137 ### Description This test case tests the various if branches inside CpuAllocation that can result in null pointer exceptions. It is important to ensure that all arguments inside the cpu

[PR] test update and get connected hosts [cloudstack]

2024-05-28 Thread via GitHub
charlesweng opened a new pull request, #9136: URL: https://github.com/apache/cloudstack/pull/9136 ### Description This pull requests tests that we are able to get the next connected host in terms of the VM. This is important in making sure that a list of hosts.

Re: [PR] Fixup response code on incorrect credentials [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8671: URL: https://github.com/apache/cloudstack/pull/8671#issuecomment-2136211654 [SF] Trillian test result (tid-10306) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46962 seconds Marvin logs: https://github.co

Re: [PR] allow users to add description to private gateway and static routes [cloudstack]

2024-05-28 Thread via GitHub
codecov[bot] commented on PR #9135: URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2136067465 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9135?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2136043310 [SF] Trillian test result (tid-10297) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50862 seconds Marvin logs: https://github.co

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2135998701 [SF] Trillian test result (tid-10299) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47658 seconds Marvin logs: https://github.

Re: [PR] allow users to add description to private gateway and static routes [cloudstack]

2024-05-28 Thread via GitHub
boring-cyborg[bot] commented on PR #9135: URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2135961649 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribut

[PR] allow users to add description to private gateway and static routes [cloudstack]

2024-05-28 Thread via GitHub
charlesweng opened a new pull request, #9135: URL: https://github.com/apache/cloudstack/pull/9135 ### Description Adding a description to the private gateway tab inside the Network > Vpc > Private Gateway tab. This allows for administrators to easily identify what the private gateway

Re: [PR] While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main] [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9063: URL: https://github.com/apache/cloudstack/pull/9063#issuecomment-2135925513 [SF] Trillian test result (tid-10295) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46990 seconds Marvin logs: https://github.co

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2135782627 [SF] Trillian test result (tid-10296) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41497 seconds Marvin logs: https://github.co

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-05-28 Thread via GitHub
winterhazel commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2135773444 Hey @lucas-a-martins @DaanHoogland, sorry for the delay. Looking back at this PR, I think it would be better to implement the link validation in both pages by including the v

Re: [PR] pre-commit: enable `markdownlint` rule `MD018` [cloudstack]

2024-05-28 Thread via GitHub
codecov[bot] commented on PR #9134: URL: https://github.com/apache/cloudstack/pull/9134#issuecomment-2135582878 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9134?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] pre-commit: enable `markdownlint` rule `MD018` [cloudstack]

2024-05-28 Thread via GitHub
jbampton opened a new pull request, #9134: URL: https://github.com/apache/cloudstack/pull/9134 https://github.com/DavidAnson/markdownlint/blob/main/doc/md018.md ### Description This PR adds another check for our Markdown linter. MD018/no-missing-space-atx No space after

Re: [PR] pre-commit: add hook `check-yaml` [cloudstack]

2024-05-28 Thread via GitHub
codecov[bot] commented on PR #9133: URL: https://github.com/apache/cloudstack/pull/9133#issuecomment-2135408922 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] pre-commit: add hook `check-yaml` [cloudstack]

2024-05-28 Thread via GitHub
jbampton opened a new pull request, #9133: URL: https://github.com/apache/cloudstack/pull/9133 https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml ### Description This PR adds another check or test to our pre-commit framework. From the official pr

Re: [PR] pre-commit: add `codespell` to check spelling [cloudstack]

2024-05-28 Thread via GitHub
jbampton commented on code in PR #8197: URL: https://github.com/apache/cloudstack/pull/8197#discussion_r1617247947 ## .pre-commit-config.yaml: ## @@ -61,6 +61,14 @@ repos: - id: trailing-whitespace files: \.(in|java|md|py|rb|sh|vue|yaml|yml)$ args: [--ma

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-28 Thread via GitHub
BryanMLima commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2135199283 @bernardodemarco, thanks for testing it. > @BryanMLima will you apply @bernardodemarco 's sugestion [#8372 (comment)](https://github.com/apache/cloudstack/pull/8372#discussion

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2135192362 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9724 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2135167941 @shwstppr a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2135163566 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] pre-commit: add `codespell` to check spelling [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on code in PR #8197: URL: https://github.com/apache/cloudstack/pull/8197#discussion_r1617168284 ## .github/linters/codespell.txt: ## @@ -0,0 +1,649 @@ +accouns +acess +acheived +acount +activ +actuall +acuiring +acumulate +addes +additionals +addreess +add

(cloudstack-kubernetes-provider) branch main updated: Strip domain from node.Name before matching with vm names (#47)

2024-05-28 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git The following commit(s) were added to refs/heads/main by this push: new 1c5bd9e8 Strip domain from

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2135112362 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

(cloudstack-kubernetes-provider) branch main updated: Add hostname annotation to set lb ingress hostname (#48)

2024-05-28 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git The following commit(s) were added to refs/heads/main by this push: new 0150bf58 Add hostname anno

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2135108181 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2135107438 > @DaanHoogland As Wei mentioned, password reset is needed nonetheless.. yeah, I can imagine it is implemented in several locations now. Each equally hard to read. ddineverm

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2135105315 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9722 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Fix grammar, spelling, word casing, whitespace [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on code in PR #9132: URL: https://github.com/apache/cloudstack/pull/9132#discussion_r1617158881 ## plugins/network-elements/netscaler/src/main/java/com/cloud/api/commands/StopNetScalerVMCmd.java: ## @@ -110,7 +110,7 @@ public boolean isForced() { @O

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2135050549 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on code in PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#discussion_r1617120474 ## plugins/event-bus/webhook/src/main/java/org/apache/cloudstack/mom/webhook/WebhookApiServiceImpl.java: ## @@ -0,0 +1,533 @@ +// Licensed to the Apache Software Fo

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2135046791 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
Pearl1594 commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2134977644 @DaanHoogland As Wei mentioned, password reset is needed nonetheless.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Fix grammar, spelling, word casing, whitespace [cloudstack]

2024-05-28 Thread via GitHub
codecov[bot] commented on PR #9132: URL: https://github.com/apache/cloudstack/pull/9132#issuecomment-2134964809 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2134959136 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2134955411 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Fix grammar, spelling, word casing, whitespace [cloudstack]

2024-05-28 Thread via GitHub
jbampton opened a new pull request, #9132: URL: https://github.com/apache/cloudstack/pull/9132 ### Description This PR cleans up the code base and standardizes some terms for casing. Fixes in exception messages, log messages, code comments and more.

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2134941686 [SF] Trillian test result (tid-10294) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 50227 seconds Marvin logs: https://github.c

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134902652 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9721 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feature: webhooks [cloudstack]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2134893195 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

(cloudstack) branch fix-password-file-cd-reinstall-vm updated (78026e5d8cd -> 50aa3c74875)

2024-05-28 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch fix-password-file-cd-reinstall-vm in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 78026e5d8cd Configure config drive ISO with password file on reinstallation of VM

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2134874734 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2134873081 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2134866250 [SF] Trillian test result (tid-10293) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47536 seconds Marvin logs: https://github.co

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
andrijapanicsb commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134833196 @vishesh92 no - those are used later during importVm API to connect via ssh etc. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

2024-05-28 Thread via GitHub
codecov[bot] commented on PR #9131: URL: https://github.com/apache/cloudstack/pull/9131#issuecomment-2134828707 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9131?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] pre-commit: add `XML` files to the `trailing-whitespace` check [cloudstack]

2024-05-28 Thread via GitHub
jbampton opened a new pull request, #9131: URL: https://github.com/apache/cloudstack/pull/9131 ### Description This PR adds checking for XML files for trailing whitespace. Trailing whitespace is mostly extra space or data we don't need.

Re: [I] Recurring volume snapshot strange behaviour [cloudstack]

2024-05-28 Thread via GitHub
rajujith commented on issue #9128: URL: https://github.com/apache/cloudstack/issues/9128#issuecomment-2134800661 @cdfgallo could you update the time for the data volume snapshot schedule to 2 to 3 hours later than the ROOT volume? -- This is an automated message from the Apache Git Serv

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134760444 @shwstppr Do we need any changes in the UI for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134757894 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134756299 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134753716 > @shwstppr as the parameters are not used, should these also be removed from the `Cmd` class? currently vms are listed by virsh command (endpoint is the remote server)

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616890349 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1384,6 +1431,8 @@ public boolean st

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616889853 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1526,6 +1575,8 @@ public KubernetesC

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616889053 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1270,29 +1280,64 @@ private Security

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2134733631 [SF] Trillian Build Failed (tid-10305) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Fixup response code on incorrect credentials [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8671: URL: https://github.com/apache/cloudstack/pull/8671#issuecomment-2134705168 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Fixup response code on incorrect credentials [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on PR #8671: URL: https://github.com/apache/cloudstack/pull/8671#issuecomment-2134702437 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616860423 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java: ## @@ -331,12 +345,14 @@ public Kubernetes

Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2134687699 @shwstppr as the parameters are not used, should these also be removed from the `Cmd` class? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2134687165 [SF] Trillian Build Failed (tid-10304) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2134687011 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9720 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616851718 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1526,6 +1575,8 @@ public Kubernetes

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616845982 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1384,6 +1431,8 @@ public boolean s

Re: [PR] cks: fix events [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616844672 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -1270,29 +1280,64 @@ private Securit

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#discussion_r1616809782 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java: ## @@ -134,7 +138,14 @@ public String getAdmin() {

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-05-28 Thread via GitHub
vishesh92 commented on code in PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#discussion_r1616808406 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java: ## @@ -134,7 +138,14 @@ public String getAdmin() {

(cloudstack) 01/01: Merge release branch 4.19 to main

2024-05-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit f1c3d2c4beece042f39d13469bc99b7943b34b06 Merge: 28e8e2d0096 c970141e250 Author: Daan Hoogland AuthorDate: Tue May 28 09:

(cloudstack) branch main updated (28e8e2d0096 -> f1c3d2c4bee)

2024-05-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 28e8e2d0096 pre-commit: add hook to trim trailing whitespace (#8205) add ad66edf6e65 UI: Add search filters (#906

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-05-28 Thread via GitHub
Pearl1594 commented on code in PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#discussion_r1616793731 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -7844,9 +7844,10 @@ public UserVm restoreVirtualMachine(final Account caller, final long vmId,

[PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache opened a new pull request, #8624: URL: https://github.com/apache/cloudstack/pull/8624 ### Description This PR fixes #8622 error ``` 2024-02-07 10:59:11,110 ERROR [c.c.a.ApiServer] (qtp1146825051-20:ctx-74413901 ctx-b91ecc51) (logid:aa41ab63) unhandled exce

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland closed pull request #8624: server: fix fail to list public ips of shared networks sometimes URL: https://github.com/apache/cloudstack/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2134595431 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Allow for scripts in CKS ISO to fully control CKS deployment [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9087: URL: https://github.com/apache/cloudstack/pull/9087#issuecomment-2134593268 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9716 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2134592333 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fixup response code on incorrect credentials [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8671: URL: https://github.com/apache/cloudstack/pull/8671#issuecomment-2134593269 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9717 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Testcases Added [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9116: URL: https://github.com/apache/cloudstack/pull/9116#issuecomment-2134593267 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9718 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134593270 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9719 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2134576814 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#issuecomment-2134573834 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] pre-commit: add `codespell` to check spelling [cloudstack]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #8197: URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2134573595 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #8973: URL: https://github.com/apache/cloudstack/pull/8973#issuecomment-2134564768 Tests with a 4.19 env, Without changes (`objectstorageid` for `listBuckets` is shown to a normal user): ``` (local) 🐱 > sync Discovered 320 APIs (local) 🐱 > list buc

Re: [I] Unable to delete User Data [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on issue #8703: URL: https://github.com/apache/cloudstack/issues/8703#issuecomment-2134566006 Fixed with #9120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Unable to delete User Data [cloudstack]

2024-05-28 Thread via GitHub
shwstppr closed issue #8703: Unable to delete User Data URL: https://github.com/apache/cloudstack/issues/8703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

(cloudstack) branch 4.19 updated: engine-schema: add removed columne for cloud.user_data, fix delete op (#9120)

2024-05-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new c970141e250 engine-schema: add removed columne for

Re: [PR] engine-schema: add removed column for cloud.user_data, fix delete op [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland merged PR #9120: URL: https://github.com/apache/cloudstack/pull/9120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [I] VPC link present under Create Menu when account has no permission [cloudstack]

2024-05-28 Thread via GitHub
shwstppr closed issue #9099: VPC link present under Create Menu when account has no permission URL: https://github.com/apache/cloudstack/issues/9099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[I] ui for listVolumes by isEncrypted [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland opened a new issue, #9130: URL: https://github.com/apache/cloudstack/issues/9130 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134532489 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [I] VPC link present under Create Menu when account has no permission [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on issue #9099: URL: https://github.com/apache/cloudstack/issues/9099#issuecomment-2134532849 Fixed with #9104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134529596 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134529386 let's make sure it doesn't cause the integration test failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(cloudstack) branch 4.19 updated (261530c92a9 -> c36a3b8cc33)

2024-05-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 261530c92a9 server: honor listall param for listiso api (#9064) add c36a3b8cc33 ui: fix create menu item access (

Re: [PR] ui: fix create menu item access [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland merged PR #9104: URL: https://github.com/apache/cloudstack/pull/9104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] utils,ui: obfuscate sensitive log info, use POST for configureOutOfBandManagement [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on code in PR #9126: URL: https://github.com/apache/cloudstack/pull/9126#discussion_r1616723070 ## utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java: ## @@ -74,27 +96,28 @@ public ProcessResult executeCommands(final List commands,

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2134508800 @BryanMLima will you apply @bernardodemarco 's sugestion https://github.com/apache/cloudstack/pull/8372#discussion_r1616409198 , or can we merge as is? Also, @BryanMLima th

Re: [I] List ISO doesn't respect listall=true [cloudstack]

2024-05-28 Thread via GitHub
shwstppr closed issue #8315: List ISO doesn't respect listall=true URL: https://github.com/apache/cloudstack/issues/8315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] List ISO doesn't respect listall=true [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on issue #8315: URL: https://github.com/apache/cloudstack/issues/8315#issuecomment-2134503181 Fixed with #9064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

  1   2   >