Re: [PR] Updated PK generators to avoid needlessly calling super.methods() [cayenne]

2025-05-05 Thread via GitHub
Jugen commented on PR #629: URL: https://github.com/apache/cayenne/pull/629#issuecomment-2853422436 All good. Also checked that no other super calls were missed in other *PkGenerator flavours. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Updated PK generators to avoid needlessly calling super.methods() [cayenne]

2025-05-05 Thread via GitHub
mrg opened a new pull request, #629: URL: https://github.com/apache/cayenne/pull/629 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-11 Thread via GitHub
stariy95 commented on PR #628: URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710547149 @Jugen Yes, you are correct, we should clean tracked paths in those places too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-11 Thread via GitHub
Jugen commented on PR #628: URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710484982 I was wondering if _trackedFlattenedPaths_ didn't need housekeeping in these two places as well ? https://github.com/apache/cayenne/blob/e1d6db2553e989d1d5668dfed2d5fec9440df778/cayenn

[PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-11 Thread via GitHub
stariy95 opened a new pull request, #628: URL: https://github.com/apache/cayenne/pull/628 Another approach to the CAY-2876 This PR introduces cleanup callback in the `ReferenceMap` keeping flattened paths as is in the `ObjectStore` and dropping them in sync with the main object map.

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-11 Thread via GitHub
stariy95 merged PR #628: URL: https://github.com/apache/cayenne/pull/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-10 Thread via GitHub
Jugen commented on PR #628: URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710447376 +1. I was experimenting with changing _trackedFlattenedPaths_ to a _WeakHashMap_ but couldn't successfully write a test case for it, however I prefer this direct approach much more. -- Thi

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-10 Thread via GitHub
andrus commented on PR #628: URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710397074 +1 . Not pretty, but should work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-05 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1981020792 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -201,7 +205,7 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-03-05 Thread via GitHub
stariy95 commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1981049296 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -201,7 +205,7 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-26 Thread via GitHub
stariy95 merged PR #627: URL: https://github.com/apache/cayenne/pull/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965667951 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965667951 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
stariy95 commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r196035 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff)

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965550429 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
stariy95 commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965533464 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff)

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965515190 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId, NodeDiff diff) {

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
stariy95 commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965481170 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -993,60 +1022,44 @@ public void arcDeleted(Object nodeId, Object targetNodeId, ArcId a

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
Jugen commented on code in PR #627: URL: https://github.com/apache/cayenne/pull/627#discussion_r1965479185 ## cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -993,60 +1022,44 @@ public void arcDeleted(Object nodeId, Object targetNodeId, ArcId arcI

Re: [PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
andrus commented on PR #627: URL: https://github.com/apache/cayenne/pull/627#issuecomment-2674507071 I am +1 on this approach in 4.2. I guess in 5.0 we should get rid of the Persistent contract of ObjectStorePersistentWrapper and make the internal ObjectStore map use explicit boundaries:

[PR] CAY-2876 Memory leak in the ObjectStore [cayenne]

2025-02-21 Thread via GitHub
stariy95 opened a new pull request, #627: URL: https://github.com/apache/cayenne/pull/627 Fix adds `ObjectStorePersistentWrapper` class that stores `Persistent` object with flatten paths in the same map, so it could be reclaimed by the GC. This class implements `Persistent` interface for

[PR] Bump org.springframework:spring-core from 5.3.37 to 6.1.14 [cayenne]

2024-12-02 Thread via GitHub
dependabot[bot] opened a new pull request, #626: URL: https://github.com/apache/cayenne/pull/626 Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 5.3.37 to 6.1.14. Release notes Sourced from https://github.com/spring-projects/spring

Re: [PR] CAY-2739 mapping proposal replace to dep pk with fk [cayenne]

2024-11-01 Thread via GitHub
stariy95 closed pull request #580: CAY-2739 mapping proposal replace to dep pk with fk URL: https://github.com/apache/cayenne/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] CAY-2739 Mapping Proposal: replace "toDepPk" with "fk" [cayenne]

2024-11-01 Thread via GitHub
stariy95 opened a new pull request, #625: URL: https://github.com/apache/cayenne/pull/625 This PR is heavily based on #580 In addition it bumps project XML version from 11 to 12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] CAY-2739 mapping proposal replace to dep pk with fk [cayenne]

2024-11-01 Thread via GitHub
stariy95 commented on PR #580: URL: https://github.com/apache/cayenne/pull/580#issuecomment-2451908624 superseded by #625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] disjoint prefetch returns incorrect data [failing tests] [cayenne]

2024-10-18 Thread via GitHub
stariy95 commented on PR #624: URL: https://github.com/apache/cayenne/pull/624#issuecomment-2422306800 Did a bit of digging. This is an older problem it seems, it's present at least in 4.2 and 4.1. An issue really in the combination of prefetch types, from all possible combination in this c

Re: [PR] Change Orderings.orderedList() to accept a Collection rather than a List [cayenne]

2024-09-16 Thread via GitHub
stariy95 merged PR #623: URL: https://github.com/apache/cayenne/pull/623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] Change Orderings.orderedList() to accept a Collection rather than a List [cayenne]

2024-09-14 Thread via GitHub
hugithordarson commented on PR #623: URL: https://github.com/apache/cayenne/pull/623#issuecomment-2350940911 Issue issued :) https://issues.apache.org/jira/browse/CAY-2873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Change Orderings.orderedList() to accept a Collection rather than a List [cayenne]

2024-09-07 Thread via GitHub
andrus commented on PR #623: URL: https://github.com/apache/cayenne/pull/623#issuecomment-2335164261 +1 . Probably also need a Jira to document the behavior change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] Change Orderings.orderedList() to accept a Collection rather than a List [cayenne]

2024-09-07 Thread via GitHub
hugithordarson opened a new pull request, #623: URL: https://github.com/apache/cayenne/pull/623 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] CAY-2597 `case-when` implementation [cayenne]

2024-08-06 Thread via GitHub
stariy95 merged PR #618: URL: https://github.com/apache/cayenne/pull/618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] Bump sqlite-jdbc from 3.36.0.3 to 3.41.2.2 [cayenne]

2024-08-06 Thread via GitHub
dependabot[bot] commented on PR #585: URL: https://github.com/apache/cayenne/pull/585#issuecomment-2270597104 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump sqlite-jdbc from 3.36.0.3 to 3.41.2.2 [cayenne]

2024-08-06 Thread via GitHub
stariy95 closed pull request #585: Bump sqlite-jdbc from 3.36.0.3 to 3.41.2.2 URL: https://github.com/apache/cayenne/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Drag and drop in DbImport targetTree [cayenne]

2024-08-02 Thread via GitHub
stariy95 merged PR #622: URL: https://github.com/apache/cayenne/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] Drag and drop in DbImport targetTree [cayenne]

2024-08-02 Thread via GitHub
stariy95 commented on PR #622: URL: https://github.com/apache/cayenne/pull/622#issuecomment-2265197937 This solves [CAY-2787](https://issues.apache.org/jira/browse/CAY-2787) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump org.springframework:spring-core from 5.2.23.RELEASE to 6.0.15 [cayenne]

2024-07-31 Thread via GitHub
dependabot[bot] commented on PR #601: URL: https://github.com/apache/cayenne/pull/601#issuecomment-2260434508 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump org.springframework:spring-core from 5.2.23.RELEASE to 6.0.15 [cayenne]

2024-07-31 Thread via GitHub
stariy95 closed pull request #601: Bump org.springframework:spring-core from 5.2.23.RELEASE to 6.0.15 URL: https://github.com/apache/cayenne/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] CAY-2091 + entity inheritance test [cayenne]

2024-07-31 Thread via GitHub
stariy95 closed pull request #201: CAY-2091 + entity inheritance test URL: https://github.com/apache/cayenne/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] CAY-2636 Modeler: Ordering in db import config [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #437: URL: https://github.com/apache/cayenne/pull/437#issuecomment-2257991293 Closed in favor of #622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] CAY-2636 Modeler: Ordering in db import config [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #437: CAY-2636 Modeler: Ordering in db import config URL: https://github.com/apache/cayenne/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Drag and drop in DbImport targetTree [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #573: Drag and drop in DbImport targetTree URL: https://github.com/apache/cayenne/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Drag and drop in DbImport targetTree [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #573: URL: https://github.com/apache/cayenne/pull/573#issuecomment-2257715524 Superseded by #622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Sorting in db import [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #568: URL: https://github.com/apache/cayenne/pull/568#issuecomment-2257714852 Superseded by #573 and #622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Sorting in db import [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #568: Sorting in db import URL: https://github.com/apache/cayenne/pull/568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.maven:maven-compat from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
dependabot[bot] commented on PR #600: URL: https://github.com/apache/cayenne/pull/600#issuecomment-2257701872 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump org.apache.maven:maven-compat from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #600: Bump org.apache.maven:maven-compat from 3.5.0 to 3.8.1 in /maven-plugins URL: https://github.com/apache/cayenne/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Bump org.apache.maven:maven-compat from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #600: URL: https://github.com/apache/cayenne/pull/600#issuecomment-2257701813 Already upgraded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 [cayenne]

2024-07-30 Thread via GitHub
dependabot[bot] commented on PR #598: URL: https://github.com/apache/cayenne/pull/598#issuecomment-2257700886 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #598: URL: https://github.com/apache/cayenne/pull/598#issuecomment-2257700831 Need much more effort to upgrade Derby, see https://issues.apache.org/jira/browse/CAY-2861 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #598: Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 URL: https://github.com/apache/cayenne/pull/598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump org.apache.maven:maven-core from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
dependabot[bot] commented on PR #599: URL: https://github.com/apache/cayenne/pull/599#issuecomment-2257698021 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump org.apache.maven:maven-core from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
stariy95 closed pull request #599: Bump org.apache.maven:maven-core from 3.5.0 to 3.8.1 in /maven-plugins URL: https://github.com/apache/cayenne/pull/599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump org.apache.maven:maven-core from 3.5.0 to 3.8.1 in /maven-plugins [cayenne]

2024-07-30 Thread via GitHub
stariy95 commented on PR #599: URL: https://github.com/apache/cayenne/pull/599#issuecomment-2257697959 Not relevant, maven deps are updated already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] CAY-2667 Fix Issues with Generic Vertical Inheritance [cayenne]

2024-07-30 Thread via GitHub
stariy95 merged PR #621: URL: https://github.com/apache/cayenne/pull/621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

[PR] Drag and drop in DbImport targetTree [cayenne]

2024-07-19 Thread via GitHub
m-dzianishchyts opened a new pull request, #622: URL: https://github.com/apache/cayenne/pull/622 This is a refined copy of #573. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [4.2] Modeler: Fix menu item background and foreground colors [cayenne]

2024-07-12 Thread via GitHub
stariy95 merged PR #620: URL: https://github.com/apache/cayenne/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2816 (NOT) EXIST usability - provide simple expression syntax [cayenne]

2024-07-12 Thread via GitHub
stariy95 merged PR #603: URL: https://github.com/apache/cayenne/pull/603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

[PR] CAY-2667 Fix Issues with Generic Vertical Inheritance [cayenne]

2024-07-09 Thread via GitHub
stariy95 opened a new pull request, #621: URL: https://github.com/apache/cayenne/pull/621 This PR is based on #432, particularly it directly uses test cases from it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Modeler: Fix menu item background and foreground colors [cayenne]

2024-07-05 Thread via GitHub
stariy95 merged PR #619: URL: https://github.com/apache/cayenne/pull/619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2804 LocalTimeValueType potential loss of precision [cayenne]

2024-06-18 Thread via GitHub
stariy95 closed pull request #583: CAY-2804 LocalTimeValueType potential loss of precision URL: https://github.com/apache/cayenne/pull/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] CAY-2804 LocalTimeValueType potential loss of precision [cayenne]

2024-06-18 Thread via GitHub
stariy95 commented on PR #583: URL: https://github.com/apache/cayenne/pull/583#issuecomment-2176073084 Merged: https://github.com/apache/cayenne/commit/25264972e9a4c32133c0d254fa6bbe133a165182 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Remove exception cause in Cayenne Modeler [cayenne]

2024-06-18 Thread via GitHub
stariy95 merged PR #582: URL: https://github.com/apache/cayenne/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] ManyToMany join table with objEntity. No cascade del [cayenne]

2024-06-13 Thread via GitHub
stariy95 commented on PR #587: URL: https://github.com/apache/cayenne/pull/587#issuecomment-2165549288 Seems like a test case for [CAY-2779](https://issues.apache.org/jira/browse/CAY-2779) -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-05-31 Thread via GitHub
stariy95 merged PR #610: URL: https://github.com/apache/cayenne/pull/610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2846 Modeler: Allow to disable some validation rules in the project [cayenne]

2024-05-28 Thread via GitHub
stariy95 commented on code in PR #617: URL: https://github.com/apache/cayenne/pull/617#discussion_r1617110860 ## cayenne-project/src/main/java/org/apache/cayenne/project/validation/BaseQueryValidator.java: ## @@ -25,36 +25,49 @@ import org.apache.cayenne.util.Util; import org.

[PR] CAY-2846 Modeler: Allow to disable some validation rules in the project [cayenne]

2024-05-28 Thread via GitHub
m-dzianishchyts opened a new pull request, #617: URL: https://github.com/apache/cayenne/pull/617 # What does this PR do? - [x] Refactors current validators. - [x] Provides modeler module with `ValidationExtension` to load and save validation config. - [ ] Allows to edit validati

Re: [PR] CAY-2848 Vertical Inheritance: Updating one-to-many with inverse nullifies other columns [cayenne]

2024-05-27 Thread via GitHub
stariy95 merged PR #616: URL: https://github.com/apache/cayenne/pull/616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

[PR] CAY-2848 Vertical Inheritance: Updating one-to-many with inverse nullifies other columns [cayenne]

2024-05-27 Thread via GitHub
stariy95 opened a new pull request, #616: URL: https://github.com/apache/cayenne/pull/616 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-23 Thread via GitHub
stariy95 commented on PR #614: URL: https://github.com/apache/cayenne/pull/614#issuecomment-2126999694 @Jugen I'll try to just cherry-pick this commit, and hope that it'll just apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-23 Thread via GitHub
stariy95 merged PR #615: URL: https://github.com/apache/cayenne/pull/615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-22 Thread via GitHub
Jugen commented on PR #614: URL: https://github.com/apache/cayenne/pull/614#issuecomment-2126327473 Now that this has been merged are there steps that I must take to back port this as previously suggested ? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-21 Thread via GitHub
Jugen commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2123949263 I have rebased and updated the release-notes for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-21 Thread via GitHub
stariy95 merged PR #614: URL: https://github.com/apache/cayenne/pull/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-17 Thread via GitHub
Jugen commented on PR #614: URL: https://github.com/apache/cayenne/pull/614#issuecomment-2116887600 Updated release notes and squashed commits for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-05-16 Thread via GitHub
Jugen commented on PR #610: URL: https://github.com/apache/cayenne/pull/610#issuecomment-2116879793 I've rebased & squashed commits for this PR, and updated the release-notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-16 Thread via GitHub
Jugen commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2114928299 Yeah, I didn't think you would like it - but it was just so convenient I couldn't resist :-) Anyway it was a good starting point. So I've updated the PR refactoring to only use the sugg

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-14 Thread via GitHub
stariy95 commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2110639172 HI @Jugen, thank you for another PR. I like the overall idea, but in this case we need something more elaborate. `CayennePath` is a good hack, but it's not supposed to be used for a

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-12 Thread via GitHub
Jugen commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2106242344 Note that this PR is based on PR 614, so only the second commit here ([b31bbe0](https://github.com/apache/cayenne/pull/615/commits/b31bbe0583bb03b22a7a12c529a81fa06304a03e)) shows the relevan

[PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-12 Thread via GitHub
Jugen opened a new pull request, #615: URL: https://github.com/apache/cayenne/pull/615 Weather a flattened attribute row should/should not be deleted is currently detected each time during each delete query construction (see [PR 614](https://github.com/apache/cayenne/pull/614)). In o

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
Jugen commented on PR #614: URL: https://github.com/apache/cayenne/pull/614#issuecomment-2103089041 Have made all the changes as requested. Note that the changes to `RootRowOpProcessor.visitDelete` has been slightly modified from the initial PR in order for the restored test to pass. So tha

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
stariy95 commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595465728 ## cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java: ## @@ -457,28 +457,42 @@ public void testDelete() throws Exception { a

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
stariy95 commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595465481 ## cayenne/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -1011,6 +1013,18 @@ public Collection getFlattenedIds(ObjectId objectId) { .

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
stariy95 commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595463305 ## cayenne/src/main/java/org/apache/cayenne/access/flush/RootRowOpProcessor.java: ## @@ -74,14 +79,37 @@ public Void visitUpdate(UpdateDbRowOp dbRow) { @Override

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
Jugen commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595222948 ## cayenne/src/main/java/org/apache/cayenne/access/flush/RootRowOpProcessor.java: ## @@ -74,14 +79,37 @@ public Void visitUpdate(UpdateDbRowOp dbRow) { @Override

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
Jugen commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595218130 ## cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java: ## @@ -457,28 +457,42 @@ public void testDelete() throws Exception { a.se

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
Jugen commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595206887 ## cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java: ## @@ -457,28 +457,42 @@ public void testDelete() throws Exception { a.se

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-09 Thread via GitHub
Jugen commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595204366 ## cayenne/src/main/java/org/apache/cayenne/access/ObjectStore.java: ## @@ -1011,6 +1013,18 @@ public Collection getFlattenedIds(ObjectId objectId) { .get

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-08 Thread via GitHub
stariy95 commented on code in PR #614: URL: https://github.com/apache/cayenne/pull/614#discussion_r1595029409 ## cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java: ## @@ -457,28 +457,42 @@ public void testDelete() throws Exception { a

Re: [PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-08 Thread via GitHub
Jugen commented on PR #614: URL: https://github.com/apache/cayenne/pull/614#issuecomment-2101052382 This PR is ready for review please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] CAY-2853 Incorrect deletion of entities from flattened attributes [cayenne]

2024-05-07 Thread via GitHub
Jugen opened a new pull request, #614: URL: https://github.com/apache/cayenne/pull/614 When deleting an ObjEntity with flattened attributes Cayenne deletes the related DB attribute's row as well. So if we have for example an ObjEntity "FlatPainting" with flattened attribute "gallery

Re: [PR] CAY-2851 Replace Existing OneToOne From New Object [cayenne]

2024-05-02 Thread via GitHub
stariy95 merged PR #612: URL: https://github.com/apache/cayenne/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2851 Replace Existing OneToOne From New Object [cayenne]

2024-05-01 Thread via GitHub
stariy95 merged PR #613: URL: https://github.com/apache/cayenne/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

Re: [PR] CAY-2850 Query using Clob comparison with empty String fails [cayenne]

2024-04-23 Thread via GitHub
stariy95 merged PR #611: URL: https://github.com/apache/cayenne/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa

[PR] CAY-2851 Replace Existing OneToOne From New Object [cayenne]

2024-04-18 Thread via GitHub
mattraydub opened a new pull request, #612: URL: https://github.com/apache/cayenne/pull/612 breaking test for CAY-2851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] CAY-2850 Query using Clob comparison with empty String fails [cayenne]

2024-04-14 Thread via GitHub
Jugen opened a new pull request, #611: URL: https://github.com/apache/cayenne/pull/611 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-03-19 Thread via GitHub
Jugen commented on code in PR #610: URL: https://github.com/apache/cayenne/pull/610#discussion_r1530698772 ## cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java: ## @@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-03-19 Thread via GitHub
Jugen commented on PR #610: URL: https://github.com/apache/cayenne/pull/610#issuecomment-2007602836 I think that there are two tests needed but I don't know how to add them to the current test setup in OrderingStageTest 1. Test that no duplicate column is added for an aliased select colu

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-03-19 Thread via GitHub
stariy95 commented on code in PR #610: URL: https://github.com/apache/cayenne/pull/610#discussion_r1530563725 ## cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java: ## @@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslat

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-03-19 Thread via GitHub
Jugen commented on code in PR #610: URL: https://github.com/apache/cayenne/pull/610#discussion_r1529869933 ## cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java: ## @@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator

Re: [PR] CAY-2847 Improve duplicate select column detection when using order by [cayenne]

2024-03-19 Thread via GitHub
Jugen commented on code in PR #610: URL: https://github.com/apache/cayenne/pull/610#discussion_r1529869933 ## cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java: ## @@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator

  1   2   3   >