Jugen commented on PR #629:
URL: https://github.com/apache/cayenne/pull/629#issuecomment-2853422436
All good. Also checked that no other super calls were missed in other
*PkGenerator flavours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
mrg opened a new pull request, #629:
URL: https://github.com/apache/cayenne/pull/629
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: co
stariy95 commented on PR #628:
URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710547149
@Jugen Yes, you are correct, we should clean tracked paths in those places
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Jugen commented on PR #628:
URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710484982
I was wondering if _trackedFlattenedPaths_ didn't need housekeeping in these
two places as well ?
https://github.com/apache/cayenne/blob/e1d6db2553e989d1d5668dfed2d5fec9440df778/cayenn
stariy95 opened a new pull request, #628:
URL: https://github.com/apache/cayenne/pull/628
Another approach to the CAY-2876
This PR introduces cleanup callback in the `ReferenceMap` keeping flattened
paths as is in the `ObjectStore` and dropping them in sync with the main object
map.
stariy95 merged PR #628:
URL: https://github.com/apache/cayenne/pull/628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Jugen commented on PR #628:
URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710447376
+1. I was experimenting with changing _trackedFlattenedPaths_ to a
_WeakHashMap_ but couldn't successfully write a test case for it, however I
prefer this direct approach much more.
--
Thi
andrus commented on PR #628:
URL: https://github.com/apache/cayenne/pull/628#issuecomment-2710397074
+1 . Not pretty, but should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1981020792
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -201,7 +205,7 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
stariy95 commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1981049296
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -201,7 +205,7 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
stariy95 merged PR #627:
URL: https://github.com/apache/cayenne/pull/627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965667951
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965667951
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
stariy95 commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r196035
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff)
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965550429
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
stariy95 commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965533464
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff)
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965515190
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -213,13 +217,28 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
stariy95 commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965481170
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -993,60 +1022,44 @@ public void arcDeleted(Object nodeId, Object
targetNodeId, ArcId a
Jugen commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1965479185
##
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -993,60 +1022,44 @@ public void arcDeleted(Object nodeId, Object
targetNodeId, ArcId arcI
andrus commented on PR #627:
URL: https://github.com/apache/cayenne/pull/627#issuecomment-2674507071
I am +1 on this approach in 4.2. I guess in 5.0 we should get rid of the
Persistent contract of ObjectStorePersistentWrapper and make the internal
ObjectStore map use explicit boundaries:
stariy95 opened a new pull request, #627:
URL: https://github.com/apache/cayenne/pull/627
Fix adds `ObjectStorePersistentWrapper` class that stores `Persistent`
object with flatten paths in the same map, so it could be reclaimed by the GC.
This class implements `Persistent` interface for
dependabot[bot] opened a new pull request, #626:
URL: https://github.com/apache/cayenne/pull/626
Bumps
[org.springframework:spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.37 to 6.1.14.
Release notes
Sourced from https://github.com/spring-projects/spring
stariy95 closed pull request #580: CAY-2739 mapping proposal replace to dep pk
with fk
URL: https://github.com/apache/cayenne/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
stariy95 opened a new pull request, #625:
URL: https://github.com/apache/cayenne/pull/625
This PR is heavily based on #580
In addition it bumps project XML version from 11 to 12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
stariy95 commented on PR #580:
URL: https://github.com/apache/cayenne/pull/580#issuecomment-2451908624
superseded by #625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stariy95 commented on PR #624:
URL: https://github.com/apache/cayenne/pull/624#issuecomment-2422306800
Did a bit of digging. This is an older problem it seems, it's present at
least in 4.2 and 4.1. An issue really in the combination of prefetch types,
from all possible combination in this c
stariy95 merged PR #623:
URL: https://github.com/apache/cayenne/pull/623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
hugithordarson commented on PR #623:
URL: https://github.com/apache/cayenne/pull/623#issuecomment-2350940911
Issue issued :)
https://issues.apache.org/jira/browse/CAY-2873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
andrus commented on PR #623:
URL: https://github.com/apache/cayenne/pull/623#issuecomment-2335164261
+1 . Probably also need a Jira to document the behavior change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
hugithordarson opened a new pull request, #623:
URL: https://github.com/apache/cayenne/pull/623
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
stariy95 merged PR #618:
URL: https://github.com/apache/cayenne/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
dependabot[bot] commented on PR #585:
URL: https://github.com/apache/cayenne/pull/585#issuecomment-2270597104
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let m
stariy95 closed pull request #585: Bump sqlite-jdbc from 3.36.0.3 to 3.41.2.2
URL: https://github.com/apache/cayenne/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stariy95 merged PR #622:
URL: https://github.com/apache/cayenne/pull/622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 commented on PR #622:
URL: https://github.com/apache/cayenne/pull/622#issuecomment-2265197937
This solves [CAY-2787](https://issues.apache.org/jira/browse/CAY-2787)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] commented on PR #601:
URL: https://github.com/apache/cayenne/pull/601#issuecomment-2260434508
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let m
stariy95 closed pull request #601: Bump org.springframework:spring-core from
5.2.23.RELEASE to 6.0.15
URL: https://github.com/apache/cayenne/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stariy95 closed pull request #201: CAY-2091 + entity inheritance test
URL: https://github.com/apache/cayenne/pull/201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
stariy95 commented on PR #437:
URL: https://github.com/apache/cayenne/pull/437#issuecomment-2257991293
Closed in favor of #622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
stariy95 closed pull request #437: CAY-2636 Modeler: Ordering in db import
config
URL: https://github.com/apache/cayenne/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
stariy95 closed pull request #573: Drag and drop in DbImport targetTree
URL: https://github.com/apache/cayenne/pull/573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
stariy95 commented on PR #573:
URL: https://github.com/apache/cayenne/pull/573#issuecomment-2257715524
Superseded by #622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
stariy95 commented on PR #568:
URL: https://github.com/apache/cayenne/pull/568#issuecomment-2257714852
Superseded by #573 and #622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
stariy95 closed pull request #568: Sorting in db import
URL: https://github.com/apache/cayenne/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] commented on PR #600:
URL: https://github.com/apache/cayenne/pull/600#issuecomment-2257701872
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let m
stariy95 closed pull request #600: Bump org.apache.maven:maven-compat from
3.5.0 to 3.8.1 in /maven-plugins
URL: https://github.com/apache/cayenne/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stariy95 commented on PR #600:
URL: https://github.com/apache/cayenne/pull/600#issuecomment-2257701813
Already upgraded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dependabot[bot] commented on PR #598:
URL: https://github.com/apache/cayenne/pull/598#issuecomment-2257700886
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let m
stariy95 commented on PR #598:
URL: https://github.com/apache/cayenne/pull/598#issuecomment-2257700831
Need much more effort to upgrade Derby, see
https://issues.apache.org/jira/browse/CAY-2861
--
This is an automated message from the Apache Git Service.
To respond to the message, please
stariy95 closed pull request #598: Bump org.apache.derby:derby from 10.14.2.0
to 10.17.1.0
URL: https://github.com/apache/cayenne/pull/598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dependabot[bot] commented on PR #599:
URL: https://github.com/apache/cayenne/pull/599#issuecomment-2257698021
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let m
stariy95 closed pull request #599: Bump org.apache.maven:maven-core from 3.5.0
to 3.8.1 in /maven-plugins
URL: https://github.com/apache/cayenne/pull/599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stariy95 commented on PR #599:
URL: https://github.com/apache/cayenne/pull/599#issuecomment-2257697959
Not relevant, maven deps are updated already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stariy95 merged PR #621:
URL: https://github.com/apache/cayenne/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
m-dzianishchyts opened a new pull request, #622:
URL: https://github.com/apache/cayenne/pull/622
This is a refined copy of #573.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
stariy95 merged PR #620:
URL: https://github.com/apache/cayenne/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #603:
URL: https://github.com/apache/cayenne/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 opened a new pull request, #621:
URL: https://github.com/apache/cayenne/pull/621
This PR is based on #432, particularly it directly uses test cases from it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
stariy95 merged PR #619:
URL: https://github.com/apache/cayenne/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 closed pull request #583: CAY-2804 LocalTimeValueType potential loss
of precision
URL: https://github.com/apache/cayenne/pull/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
stariy95 commented on PR #583:
URL: https://github.com/apache/cayenne/pull/583#issuecomment-2176073084
Merged:
https://github.com/apache/cayenne/commit/25264972e9a4c32133c0d254fa6bbe133a165182
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
stariy95 merged PR #582:
URL: https://github.com/apache/cayenne/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 commented on PR #587:
URL: https://github.com/apache/cayenne/pull/587#issuecomment-2165549288
Seems like a test case for
[CAY-2779](https://issues.apache.org/jira/browse/CAY-2779)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
stariy95 merged PR #610:
URL: https://github.com/apache/cayenne/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 commented on code in PR #617:
URL: https://github.com/apache/cayenne/pull/617#discussion_r1617110860
##
cayenne-project/src/main/java/org/apache/cayenne/project/validation/BaseQueryValidator.java:
##
@@ -25,36 +25,49 @@
import org.apache.cayenne.util.Util;
import org.
m-dzianishchyts opened a new pull request, #617:
URL: https://github.com/apache/cayenne/pull/617
# What does this PR do?
- [x] Refactors current validators.
- [x] Provides modeler module with `ValidationExtension` to load and save
validation config.
- [ ] Allows to edit validati
stariy95 merged PR #616:
URL: https://github.com/apache/cayenne/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 opened a new pull request, #616:
URL: https://github.com/apache/cayenne/pull/616
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
stariy95 commented on PR #614:
URL: https://github.com/apache/cayenne/pull/614#issuecomment-2126999694
@Jugen I'll try to just cherry-pick this commit, and hope that it'll just
apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stariy95 merged PR #615:
URL: https://github.com/apache/cayenne/pull/615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Jugen commented on PR #614:
URL: https://github.com/apache/cayenne/pull/614#issuecomment-2126327473
Now that this has been merged are there steps that I must take to back port
this as previously suggested ?
--
This is an automated message from the Apache Git Service.
To respond to the mes
Jugen commented on PR #615:
URL: https://github.com/apache/cayenne/pull/615#issuecomment-2123949263
I have rebased and updated the release-notes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
stariy95 merged PR #614:
URL: https://github.com/apache/cayenne/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Jugen commented on PR #614:
URL: https://github.com/apache/cayenne/pull/614#issuecomment-2116887600
Updated release notes and squashed commits for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jugen commented on PR #610:
URL: https://github.com/apache/cayenne/pull/610#issuecomment-2116879793
I've rebased & squashed commits for this PR, and updated the release-notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Jugen commented on PR #615:
URL: https://github.com/apache/cayenne/pull/615#issuecomment-2114928299
Yeah, I didn't think you would like it - but it was just so convenient I
couldn't resist :-) Anyway it was a good starting point.
So I've updated the PR refactoring to only use the sugg
stariy95 commented on PR #615:
URL: https://github.com/apache/cayenne/pull/615#issuecomment-2110639172
HI @Jugen, thank you for another PR.
I like the overall idea, but in this case we need something more elaborate.
`CayennePath` is a good hack, but it's not supposed to be used for a
Jugen commented on PR #615:
URL: https://github.com/apache/cayenne/pull/615#issuecomment-2106242344
Note that this PR is based on PR 614, so only the second commit here
([b31bbe0](https://github.com/apache/cayenne/pull/615/commits/b31bbe0583bb03b22a7a12c529a81fa06304a03e))
shows the relevan
Jugen opened a new pull request, #615:
URL: https://github.com/apache/cayenne/pull/615
Weather a flattened attribute row should/should not be deleted is currently
detected each time during each delete query construction (see [PR
614](https://github.com/apache/cayenne/pull/614)).
In o
Jugen commented on PR #614:
URL: https://github.com/apache/cayenne/pull/614#issuecomment-2103089041
Have made all the changes as requested. Note that the changes to
`RootRowOpProcessor.visitDelete` has been slightly modified from the initial PR
in order for the restored test to pass. So tha
stariy95 commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595465728
##
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java:
##
@@ -457,28 +457,42 @@ public void testDelete() throws Exception {
a
stariy95 commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595465481
##
cayenne/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -1011,6 +1013,18 @@ public Collection getFlattenedIds(ObjectId
objectId) {
.
stariy95 commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595463305
##
cayenne/src/main/java/org/apache/cayenne/access/flush/RootRowOpProcessor.java:
##
@@ -74,14 +79,37 @@ public Void visitUpdate(UpdateDbRowOp dbRow) {
@Override
Jugen commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595222948
##
cayenne/src/main/java/org/apache/cayenne/access/flush/RootRowOpProcessor.java:
##
@@ -74,14 +79,37 @@ public Void visitUpdate(UpdateDbRowOp dbRow) {
@Override
Jugen commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595218130
##
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java:
##
@@ -457,28 +457,42 @@ public void testDelete() throws Exception {
a.se
Jugen commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595206887
##
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java:
##
@@ -457,28 +457,42 @@ public void testDelete() throws Exception {
a.se
Jugen commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595204366
##
cayenne/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##
@@ -1011,6 +1013,18 @@ public Collection getFlattenedIds(ObjectId
objectId) {
.get
stariy95 commented on code in PR #614:
URL: https://github.com/apache/cayenne/pull/614#discussion_r1595029409
##
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java:
##
@@ -457,28 +457,42 @@ public void testDelete() throws Exception {
a
Jugen commented on PR #614:
URL: https://github.com/apache/cayenne/pull/614#issuecomment-2101052382
This PR is ready for review please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Jugen opened a new pull request, #614:
URL: https://github.com/apache/cayenne/pull/614
When deleting an ObjEntity with flattened attributes Cayenne deletes the
related DB attribute's row as well.
So if we have for example an ObjEntity "FlatPainting" with flattened
attribute "gallery
stariy95 merged PR #612:
URL: https://github.com/apache/cayenne/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #613:
URL: https://github.com/apache/cayenne/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #611:
URL: https://github.com/apache/cayenne/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
mattraydub opened a new pull request, #612:
URL: https://github.com/apache/cayenne/pull/612
breaking test for CAY-2851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Jugen opened a new pull request, #611:
URL: https://github.com/apache/cayenne/pull/611
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jugen commented on code in PR #610:
URL: https://github.com/apache/cayenne/pull/610#discussion_r1530698772
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator
Jugen commented on PR #610:
URL: https://github.com/apache/cayenne/pull/610#issuecomment-2007602836
I think that there are two tests needed but I don't know how to add them to
the current test setup in OrderingStageTest
1. Test that no duplicate column is added for an aliased select colu
stariy95 commented on code in PR #610:
URL: https://github.com/apache/cayenne/pull/610#discussion_r1530563725
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslat
Jugen commented on code in PR #610:
URL: https://github.com/apache/cayenne/pull/610#discussion_r1529869933
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator
Jugen commented on code in PR #610:
URL: https://github.com/apache/cayenne/pull/610#discussion_r1529869933
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -57,51 +57,154 @@ protected void processOrdering(QualifierTranslator
1 - 100 of 227 matches
Mail list logo