Jugen commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2114928299
Yeah, I didn't think you would like it - but it was just so convenient I couldn't resist :-) Anyway it was a good starting point. So I've updated the PR refactoring to only use the suggested `AdditionalEntityDescriptor` class. I initially also tried incorporating `FlattenedId` but ran into problems in `ArcValuesCreationHandler`._processFlattenedPath_ and in `ReplacementIdVisitor`._visitInsert_ (both in package access/flush) where new FlattenedId object's need to be created, but there's no way (I know of) to get to the needed `AdditionalEntityDescriptor` for the noDelete flag. Anyway using just `AdditionalEntityDescriptor` on its own turned out much cleaner and simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
