yifan-c merged PR #109:
URL: https://github.com/apache/cassandra-analytics/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
frankgh commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2101256916
##
CHANGES.txt:
##
@@ -1,4 +1,5 @@
1.0.0
+ * Bulk writer needs to support collections with UDTs
Review Comment:
can we add the ticket here?
```sugge
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2099856754
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SharedClusterSparkIntegrationTestBase.java:
##
@@ -171,28 +173,35 @@ p
yifan-c commented on PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#issuecomment-2891821490
Please update `CHANGES.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
yifan-c commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2096203009
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -380,28 +382,69 @@ private Map
getBindValuesForColu
frankgh commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2096092205
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -380,28 +382,69 @@ private Map
getBindValuesForColu
yifan-c commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2096087782
##
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/CqlTable.java:
##
@@ -242,6 +246,31 @@ public int indexCount()
return in
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095850224
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/testing/TestUtils.java:
##
@@ -36,7 +36,7 @@ public final class TestUtils
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095858316
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SharedClusterSparkIntegrationTestBase.java:
##
@@ -171,28 +173,35 @@ p
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095806449
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -380,28 +382,69 @@ private Map
getBindValuesForCol
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095817571
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -380,28 +382,69 @@ private Map
getBindValuesForCol
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095806449
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -380,28 +382,69 @@ private Map
getBindValuesForCol
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095787453
##
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/CqlTable.java:
##
@@ -242,6 +246,31 @@ public int indexCount()
return i
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2081780842
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BulkWriteUdtTest.java:
##
@@ -32,7 +32,7 @@
import org.apache.spark.s
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2081801395
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##
@@ -389,19 +391,52 @@ private Map
getBindValuesForCol
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2081781154
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BulkWriteUdtTest.java:
##
@@ -88,17 +141,298 @@ void testWriteWithNest
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2075300073
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BulkWriteUdtTest.java:
##
@@ -59,6 +59,59 @@ class BulkWriteUdtTest ex
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2075299058
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BulkWriteUdtTest.java:
##
@@ -32,7 +32,7 @@
import org.apache.spark.s
skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2075295112
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/testing/TestUtils.java:
##
@@ -36,7 +36,7 @@ public final class TestUtils
yifan-c commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2074359925
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/testing/TestUtils.java:
##
@@ -36,7 +36,7 @@ public final class TestUtils
skoppu22 opened a new pull request, #109:
URL: https://github.com/apache/cassandra-analytics/pull/109
Currently Cassandra bulk writer not properly supporting UDTs inside
collections. Also complex structures like collections inside UDTs are not
supported properly. Adding support for these ca
21 matches
Mail list logo