skoppu22 commented on code in PR #109:
URL:
https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095817571
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##########
@@ -380,28 +382,69 @@ private Map<String, Object>
getBindValuesForColumns(Map<String, Object> map, Str
{
Preconditions.checkArgument(values.length == columnNames.length,
"Number of values does not match the
number of columns " + values.length + ", " + columnNames.length);
+
for (int i = 0; i < columnNames.length; i++)
{
- map.put(columnNames[i], maybeConvertUdt(values[i]));
+ if (cqlTable().containsUdt(columnNames[i]))
Review Comment:
I see @yifan-c added cqlTable. @yifan-c Can we call cqlTable() only once in
the class init and reference the class local variable in rest of the class? I
see `cqlTable` is volatile, but it is assigned only once when it is null. Does
it need to be really volatile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
