Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Oct. 5, 2012, 6:36 p.m., Alena Prokharchyk wrote: > > Ship It! Fixed with f7ebb76f57a0c88c8b379aacb1a4e3fd653a325f. Added WARN statement myself. - Alena --- This is an automatically generated e-mail. To reply, visit: https://revie

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 28, 2012, 6:18 a.m., Rohit Yadav wrote: > > Fixed as per comments, waiting for review/commit. Rohit, the updated diff still has Debug level for "Authentication failure: No user with name" error message. It should be WARN - Alena ---

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review12195 --- Ship it! Ship It! - Alena Prokharchyk On Sept. 27, 2012, 4:34 a.m

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review12017 --- Fixed as per comments, waiting for review/commit. - Rohit Yadav On

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 27, 2012, 4:34 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

OK,thank you very much. Thanks, Lucy 2012/9/26 Rohit Yadav > > > > On Sept. 25, 2012, 8:51 p.m., Alena Prokharchyk wrote: > > > Could you also please add warn log statement on the case when account > can't be found? At the moment we just return NULL. > > Already added. Please check the diff co

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 25, 2012, 8:51 p.m., Alena Prokharchyk wrote: > > Could you also please add warn log statement on the case when account can't > > be found? At the moment we just return NULL. Already added. Please check the diff code. When authenticated boolean is True, it checks for number of things

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11907 --- Could you also please add warn log statement on the case when account

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 25, 2012, 7:56 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 25, 2012, 12:14 a.m., Alena Prokharchyk wrote: > > Rohit, I wouldn't advise to use hardcoded values when compare cloudStack > > object states: > > > > if ((userAccount.getState().toString()).equals("enabled")) > > > > otherwise once we decide to change the name from "enabled" to s

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11872 --- Rohit, I wouldn't advise to use hardcoded values when compare cloudSt

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 18, 2012, 11:27 a.m., Nitin Mehta wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 1884 > > > > > > Trivial but we have already logged auth failure above correct ? +1 But, added as suggest

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11657 --- server/src/com/cloud/user/AccountManagerImpl.java

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 18, 2012, 9:43 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 18, 2012, 8:32 a.m., Nitin Mehta wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 1869 > > > > > > You are retrieving the user account again and again checking for null. > > Can we not hav

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

> On Sept. 18, 2012, 8:32 a.m., Nitin Mehta wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 1869 > > > > > > You are retrieving the user account again and again checking for null. > > Can we not hav

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11652 --- server/src/com/cloud/user/AccountManagerImpl.java

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 18, 2012, 8:29 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 18, 2012, 8:29 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11651 --- server/src/com/cloud/user/AccountManagerImpl.java

Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- (Updated Sept. 17, 2012, 12:22 p.m.) Review request for cloudstack, Abhinandan P

Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/ --- Review request for cloudstack, Abhinandan Prateek, Alena Prokharchyk, and Alex Hu