> On Sept. 18, 2012, 11:27 a.m., Nitin Mehta wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 1884 > > <https://reviews.apache.org/r/7130/diff/2/?file=156156#file156156line1884> > > > > Trivial but we have already logged auth failure above correct ?
+1 But, added as suggested by Koushik (see above). This is a special case we want to log for the Admin: It happens when someone tries to login with an incorrect domain. The information may be useful for Admin. PS. over engineering for a silly bug, just ship already pretty please ;) - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11657 ----------------------------------------------------------- On Sept. 18, 2012, 9:43 a.m., Rohit Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7130/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2012, 9:43 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Alena Prokharchyk, and > Alex Huang. > > > Description > ------- > > Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-121 > > Download original patch and git am <patch>: > http://bhaisaab.org/patches/cloudstack/0001-CLOUDSTACK-121-Fix-NullPointerException-for-incorrec.patch > > > Diffs > ----- > > api/src/com/cloud/user/UserAccount.java 734e16b > server/src/com/cloud/user/AccountManagerImpl.java fa9fafb > > Diff: https://reviews.apache.org/r/7130/diff/ > > > Testing > ------- > > > Thanks, > > Rohit Yadav > >
