Re: Review Request: Fix CS-15603

2012-09-13 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6515/#review11457 --- Ship it! https://git-wip-us.apache.org/repos/asf?p=incubator-cloudst

Re: Review Request: Fix CS-15603

2012-09-11 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6515/ --- (Updated Sept. 11, 2012, 12:32 p.m.) Review request for cloudstack and Abhinanda

Re: Review Request: Fix CS-15603

2012-09-06 Thread Koushik Das
> On Sept. 6, 2012, 10:15 p.m., Alex Huang wrote: > > - It removed the code that skips VMs that do not have cloudstack's naming > > convention. This in effects stops other VMs. That's a no no. > > - Technically, an administrator is suppose to only force stop a VM only if > > he has found the

Re: Review Request: Fix CS-15603

2012-09-06 Thread Alex Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6515/#review11141 --- - It removed the code that skips VMs that do not have cloudstack's na

Re: Review Request: Fix CS-15603

2012-08-17 Thread Mice
x27;infos' which are not tracked by CS > and cleans them up. > > > > Thanks, > > Koushik > > > > -Original Message- > > From: Mice Xia [mailto:mice_...@tcloudcomputing.com] > > Sent: Tuesday, August 14, 2012 7:58 AM > > To: clo

RE: Review Request: Fix CS-15603

2012-08-17 Thread Koushik Das
Mice Xia [mailto:weiran.x...@gmail.com] Sent: Friday, August 17, 2012 5:32 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Review Request: Fix CS-15603 Koushik, Yes, there are two loops. The first loop does not take care of VMs in Migrating state, So VM in Migrating state will be handl

Re: Review Request: Fix CS-15603

2012-08-17 Thread Mice Xia
om 'infos' if present. In the second loop it iterates over the remaining > VMs in 'infos' which are not tracked by CS and cleans them up. > > Thanks, > Koushik > > -Original Message- > From: Mice Xia [mailto:mice_...@tcloudcomputing.com] > Sent: Tu

RE: Review Request: Fix CS-15603

2012-08-17 Thread Koushik Das
not tracked by CS and cleans them up. Thanks, Koushik -Original Message- From: Mice Xia [mailto:mice_...@tcloudcomputing.com] Sent: Tuesday, August 14, 2012 7:58 AM To: cloudstack-dev@incubator.apache.org Subject: RE: Review Request: Fix CS-15603 Koushik, I'm not very familiar wit

RE: Review Request: Fix CS-15603

2012-08-13 Thread Mice Xia
ync or compareState? Regards Mice -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Tuesday, August 14, 2012 2:27 AM To: cloudstack-dev@incubator.apache.org Subject: RE: Review Request: Fix CS-15603 Matthew, You have a valid point and the regular delete operation d

RE: Review Request: Fix CS-15603

2012-08-13 Thread Koushik Das
, it is up to the users what they want to choose. -Koushik -Original Message- From: Matthew Patton [mailto:mpat...@inforelay.com] Sent: Monday, August 13, 2012 7:06 PM To: cloudstack-dev@incubator.apache.org Subject: RE: Review Request: Fix CS-15603 This it's yet another ca

RE: Review Request: Fix CS-15603

2012-08-13 Thread Matthew Patton
This it's yet another case of misleading the user and lying about system state. The deletion flat out failed. CS should say so. if anything create a job in the queue and retry the operation a number of times if you want. But the state is "pending deletion" until it actually executes.

RE: Review Request: Fix CS-15603

2012-08-13 Thread Koushik Das
Can anyone review this? Thanks, Koushik From: Koushik Das [mailto:nore...@reviews.apache.org] On Behalf Of Koushik Das Sent: Friday, August 10, 2012 4:07 PM To: Abhinandan Prateek Cc: cloudstack; Koushik Das Subject: Review Request: Fix CS-15603 This is an automatically generated e-mail. To reply