----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6515/#review11141 -----------------------------------------------------------
- It removed the code that skips VMs that do not have cloudstack's naming convention. This in effects stops other VMs. That's a no no. - Technically, an administrator is suppose to only force stop a VM only if he has found the VM is stopped. I understand force stop is shown to the end user now which is a bug. I don't see this fix as being necessary, although there's nothing wrong with the fix itself other than the first item listed. - Alex Huang On Aug. 10, 2012, 10:37 a.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6515/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 10:37 a.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Description > ------- > > When a VM is force deleted and the host is not available then CS simply > marks the state in db as "Destroyed/Expunging". The VM is still running on > the host and once it becomes available again there is a discrepancy in state > of the VM. In this scenario the VM is removed from the host when the next > full cluster sync happens. > > > Diffs > ----- > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 3f7cab9 > > Diff: https://reviews.apache.org/r/6515/diff/ > > > Testing > ------- > > > Thanks, > > Koushik Das > >
