Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-05 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:31 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java, > > line 77 > > > > > > Instead of requiring the nicModel in the API

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-05 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:03 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifDriver.java, > > line 35 > > > > > > This should be an Interface rather than an abstract

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
On 8/3/12 7:40 PM, "Tomoe Sugihara" wrote: > > >> On Aug. 3, 2012, 10:31 p.m., Chiradeep Vittal wrote: >> > >>plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBrid >>geVifDriver.java, line 49 >> > >> >

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
On 8/3/12 7:29 PM, "Tomoe Sugihara" wrote: > > >> On Aug. 3, 2012, 10:03 p.m., Chiradeep Vittal wrote: >> > >>plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifD >>river.java, line 35 >> > >> >> > >>

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:31 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java, > > line 49 > > > > > > This should not be a concern of the vif drive

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:03 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifDriver.java, > > line 35 > > > > > > This should be an Interface rather than an abstract

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9838 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Libvirt

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9837 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Libvirt

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-02 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/ --- (Updated Aug. 2, 2012, 11:18 p.m.) Review request for cloudstack, edison su and

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-02 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/ --- (Updated Aug. 2, 2012, 11:11 p.m.) Review request for cloudstack and Chiradeep V