RE: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-08 Thread Likitha Shetty
with these details. Likitha, Will be ignoring this patch as per the review discussion. -Prachi >-Original Message- >From: Nitin Mehta [mailto:nore...@reviews.apache.org] On Behalf Of >Nitin Mehta >Sent: Friday, July 06, 2012 4:52 PM >To: cloudstack; Prachi Damle; Likitha Sh

RE: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-06 Thread Prachi Damle
the review discussion. -Prachi >-Original Message- >From: Nitin Mehta [mailto:nore...@reviews.apache.org] On Behalf Of >Nitin Mehta >Sent: Friday, July 06, 2012 4:52 PM >To: cloudstack; Prachi Damle; Likitha Shetty; Nitin Mehta >Subject: Re: Review Request: listSnapshotPolicies com

Re: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-06 Thread Alena Prokharchyk
..@reviews.apache.org] On Behalf Of Nitin >Mehta >Sent: Friday, July 06, 2012 4:52 PM >To: cloudstack; Prachi Damle; Likitha Shetty; Nitin Mehta >Subject: Re: Review Request: listSnapshotPolicies command, volumeId >parameter made optional. > > > >> On June 28, 2012, 1

RE: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-06 Thread Prachi Damle
Mehta Subject: Re: Review Request: listSnapshotPolicies command, volumeId parameter made optional. > On June 28, 2012, 12:21 p.m., Nitin Mehta wrote: > > Ideally listSnapshotPolicy should be part of > > BaseListProjectAndAccountResourcesCmd. > > Prachi Damle wrote:

Re: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-06 Thread Nitin Mehta
> On June 28, 2012, 12:21 p.m., Nitin Mehta wrote: > > Ideally listSnapshotPolicy should be part of > > BaseListProjectAndAccountResourcesCmd. > > Prachi Damle wrote: > listSnapshotPolicy cannot extend BaseListProjectAndAccountResourcesCmd, > since the snapshotPolicy entity does not carry

Re: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-07-06 Thread Prachi Damle
> On June 28, 2012, 12:21 p.m., Nitin Mehta wrote: > > Ideally listSnapshotPolicy should be part of > > BaseListProjectAndAccountResourcesCmd. listSnapshotPolicy cannot extend BaseListProjectAndAccountResourcesCmd, since the snapshotPolicy entity does not carry the account/domain attributes. I

Re: Review Request: listSnapshotPolicies command, volumeId parameter made optional.

2012-06-28 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5604/#review8706 --- Ideally listSnapshotPolicy should be part of BaseListProjectAndAccoun