> On June 28, 2012, 12:21 p.m., Nitin Mehta wrote: > > Ideally listSnapshotPolicy should be part of > > BaseListProjectAndAccountResourcesCmd.
listSnapshotPolicy cannot extend BaseListProjectAndAccountResourcesCmd, since the snapshotPolicy entity does not carry the account/domain attributes. Instead access checks are made to the volume to which the policy refers. - Prachi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5604/#review8706 ----------------------------------------------------------- On June 27, 2012, 6:47 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5604/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 6:47 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Changes made to allow the admin to see all the the policies in the system > when 'listSnapshotPolicies' is executed. The optional parameter 'volumeId' > can be used to narrow down the search. > > > This addresses bug CS-4109. > > > Diffs > ----- > > api/src/com/cloud/api/commands/ListSnapshotPoliciesCmd.java c19924b > api/src/com/cloud/storage/snapshot/SnapshotService.java 0500061 > server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java b97a7d7 > > Diff: https://reviews.apache.org/r/5604/diff/ > > > Testing > ------- > > > Thanks, > > Likitha Shetty > >
