Re: Review Request: Added a global package name in the packaging script

2013-02-22 Thread Prasanna Santhanam
> On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote: > > Ship It! > > Hugo Trippaers wrote: > Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b > > Cherry pick to 4.1 8b2aabe687fbee0a0806a2f9d9c0ca9a8d3cd2fd Hey pradeep , can you close this review as submitted. - Prasanna

RE: Review Request: Added a global package name in the packaging script

2013-02-21 Thread Animesh Chaturvedi
deep Soundararajan > Subject: Re: Review Request: Added a global package name in the packaging > script > > > > > On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote: > > > Ship It! > > Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b > >

Re: Review Request: Added a global package name in the packaging script

2013-02-21 Thread Hugo Trippaers
> On Feb. 21, 2013, 9:37 a.m., Hugo Trippaers wrote: > > Ship It! Commit in master 3279b4146526e2f4e77a06699887cb7ea141fc0b Cherry pick to 4.1 8b2aabe687fbee0a0806a2f9d9c0ca9a8d3cd2fd - Hugo --- This is an automatically generated e-mai

Re: Review Request: Added a global package name in the packaging script

2013-02-21 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9409/#review16839 --- Ship it! Ship It! - Hugo Trippaers On Feb. 12, 2013, 12:16 p.m.,

RE: Review Request: Added a global package name in the packaging script

2013-02-20 Thread Animesh Chaturvedi
ers > Cc: Pradeep Soundararajan > Subject: RE: Review Request: Added a global package name in the packaging > script > > Hugo > > Can you review and commit the patch if satisfied > > > -Original Message- > > From: Wido den Hollander [mailto:nore...@reviews.apa

RE: Review Request: Added a global package name in the packaging script

2013-02-15 Thread Animesh Chaturvedi
loudstack; Pradeep Soundararajan > Subject: Re: Review Request: Added a global package name in the packaging > script > > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

RE: Review Request: Added a global package name in the packaging script

2013-02-13 Thread Pradeep Soundararajan
, 2013 12:56 PM To: Wido den Hollander; Hugo Trippaers Cc: cloudstack; Pradeep Soundararajan Subject: Re: Review Request: Added a global package name in the packaging script This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9409/ Ship it! Seems fine with me

Re: Review Request: Added a global package name in the packaging script

2013-02-13 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9409/#review16567 --- Ship it! Seems fine with me, but Hugo has the most RPM knowledge, so

RE: Review Request: Added a global package name in the packaging script

2013-02-13 Thread Pradeep Soundararajan
Pradeep S -Original Message- From: Animesh Chaturvedi Sent: Thursday, February 14, 2013 9:01 AM To: cloudstack-dev@incubator.apache.org; Pradeep Soundararajan; Wido den Hollander; Hugo Trippaers Subject: RE: Review Request: Added a global package name in the packaging script Pradeep The p

RE: Review Request: Added a global package name in the packaging script

2013-02-13 Thread Animesh Chaturvedi
Pradeep The patch looks fine, but do we really need the change? Wido/ Hugo can you review? > -Original Message- > From: Pradeep Soundararajan [mailto:nore...@reviews.apache.org] On Behalf > Of Pradeep Soundararajan > Sent: Tuesday, February 12, 2013 4:17 AM > To: Wido den Hollander; Hugo