----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9409/#review16567 -----------------------------------------------------------
Ship it! Seems fine with me, but Hugo has the most RPM knowledge, so I'll let this up to him. >From what I understand, package.sh hasn't been used that much. - Wido den Hollander On Feb. 12, 2013, 12:16 p.m., Pradeep Soundararajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9409/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2013, 12:16 p.m.) > > > Review request for cloudstack, Hugo Trippaers and Wido den Hollander. > > > Description > ------- > > Added a global package name in the packaging script > > > Diffs > ----- > > packaging/centos63/package.sh 5b1bab49b615e504273be3fe69335c10782d009a > > Diff: https://reviews.apache.org/r/9409/diff/ > > > Testing > ------- > > > Thanks, > > Pradeep Soundararajan > >
