Re: Patches review

2012-06-25 Thread David Nalley
Hi folks, It's been about a week since Review Board was stood up. Anyone have any comments? I have a couple - first compared to gerrit, ReviewBoard def lacks a few features, though it's virtually zero effort for us to maintain. I think it does provide a nice centralized place to look for patches

Re: Patches review

2012-06-20 Thread David Nalley
On Wed, Jun 20, 2012 at 12:07 PM, Chip Childers wrote: > On Wed, Jun 20, 2012 at 12:18 AM, David Nalley wrote: >> You can sign up for an account on reviews.a.o - >> I haven't figured out workflow, so I might submit a patch or two just >> to see how it works. > > I added 8 more (license header upd

Re: Patches review

2012-06-20 Thread Chip Childers
On Wed, Jun 20, 2012 at 12:18 AM, David Nalley wrote: > You can sign up for an account on reviews.a.o - > I haven't figured out workflow, so I might submit a patch or two just > to see how it works. I added 8 more (license header updates). It would be great if we could use these to test the proc

Re: Patches review

2012-06-19 Thread David Nalley
> > > Created: > https://issues.apache.org/jira/browse/INFRA-4939 > > --David This is done (Thanks to the fine folks in INFRA!) You can sign up for an account on reviews.a.o - I haven't figured out workflow, so I might submit a patch or two just to see how it works. --David

Re: Patches review

2012-06-19 Thread David Nalley
On Tue, Jun 19, 2012 at 2:33 PM, Ewan Mellor wrote: >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> >> On Jun 19, 2012, at 12:44 AM, Ewan Mellor >> wrote: >> >> >> [Re ReviewBoard] >> >> >> >> I think it's low 'cost' to try it out. If no one objects in the next >> >>

RE: Patches review

2012-06-19 Thread Ewan Mellor
> -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > > On Jun 19, 2012, at 12:44 AM, Ewan Mellor > wrote: > > >> [Re ReviewBoard] > >> > >> I think it's low 'cost' to try it out. If no one objects in the next > >> day or so I'll request that we get CloudStack instance in > r

Re: Patches review

2012-06-19 Thread David Nalley
On Jun 19, 2012, at 12:44 AM, Ewan Mellor wrote: >> [Re ReviewBoard] >> >> I think it's low 'cost' to try it out. If no one objects in the next >> day or so I'll request that we get CloudStack instance in reviewboard, >> and we can try using it for a week or two and see if that is to our >>

RE: Patches review

2012-06-18 Thread Ewan Mellor
> [Re ReviewBoard] > > I think it's low 'cost' to try it out. If no one objects in the next > day or so I'll request that we get CloudStack instance in reviewboard, > and we can try using it for a week or two and see if that is to our > liking. If there are specific problems that we find from a wor

Re: Patches review

2012-06-18 Thread David Nalley
On Mon, Jun 18, 2012 at 8:04 PM, Kevin Kluge wrote: >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> Sent: Monday, June 18, 2012 2:20 PM >> To: cloudstack-dev@incubator.apache.org >> Subject: Re: Patches review >> >> On

RE: Patches review

2012-06-18 Thread Kevin Kluge
> -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Monday, June 18, 2012 2:20 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Patches review > > On Mon, Jun 18, 2012 at 4:17 PM, Adrian Cole > wrote: > > +1 gerrit,

Re: Patches review

2012-06-18 Thread David Nalley
On Mon, Jun 18, 2012 at 4:17 PM, Adrian Cole wrote: > +1 gerrit, particularly as it helps avoid additional process mismatches for > folks working in both openstack and cloudstack So while I like the thinking here, let me present the flip side of the coin. Reviewboard is what is used in a large nu

Re: Patches review

2012-06-18 Thread John Kinsella
On Jun 18, 2012, at 1:06 PM, Ewan Mellor wrote: >> -Original Message- >> From: Fred Wittekind [mailto:r...@twister.dyndns.org] >> >> ... >> >>> Personally, I've always submitted patches via attaching them to bug reports. Works well when I find a bug in something, don't have time >

RE: Patches review

2012-06-18 Thread Adrian Cole
+1 gerrit, particularly as it helps avoid additional process mismatches for folks working in both openstack and cloudstack On Jun 18, 2012 2:07 PM, "Ewan Mellor" wrote: > > -Original Message- > > From: Fred Wittekind [mailto:r...@twister.dyndns.org] > > > > ... > > > >> Personally, I've a

RE: Patches review

2012-06-18 Thread Ewan Mellor
> -Original Message- > From: Fred Wittekind [mailto:r...@twister.dyndns.org] > > ... > >> Personally, I've always submitted patches via attaching them to bug > >> reports. Works well when I find a bug in something, don't have time > to > >> wait on anyone else to fix it, so I fix it myself

Re: Patches review

2012-06-13 Thread Brett Porter
On 14/06/2012, at 1:09 AM, David Nalley wrote: >>> So I have seen a lot of folks who use this approach, but that >>> typically means that the mailing list gets cced on every action in the >>> bugtracker. (mailing lists are where everything happens in Apache >>> projects) We are already on track t

RE: Patches review

2012-06-13 Thread Kelven Yang
gt; Subject: Re: Patches review > > On 6/12/2012 4:01 PM, David Nalley wrote: > > On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk > > wrote: > >> I know it's been discussed in several email threads, but I would like > to > >> initiate a separate discussion

Re: Patches review

2012-06-13 Thread David Nalley
On Wed, Jun 13, 2012 at 10:49 AM, Fred Wittekind wrote: > On 6/13/2012 10:25 AM, David Nalley wrote: >> On Wed, Jun 13, 2012 at 8:59 AM, Fred Wittekind >> wrote: >>> On 6/12/2012 4:01 PM, David Nalley wrote: On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk wrote: > I know it's

Re: Patches review

2012-06-13 Thread Fred Wittekind
On 6/13/2012 10:25 AM, David Nalley wrote: > On Wed, Jun 13, 2012 at 8:59 AM, Fred Wittekind > wrote: >> On 6/12/2012 4:01 PM, David Nalley wrote: >>> On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk >>> wrote: I know it's been discussed in several email threads, but I would like to

Re: Patches review

2012-06-13 Thread David Nalley
On Wed, Jun 13, 2012 at 8:59 AM, Fred Wittekind wrote: > On 6/12/2012 4:01 PM, David Nalley wrote: >> On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk >> wrote: >>> I know it's been discussed in several email threads, but I would like to >>> initiate a separate discussion on what tool we should

Re: Patches review

2012-06-13 Thread Fred Wittekind
On 6/12/2012 4:01 PM, David Nalley wrote: > On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk > wrote: >> I know it's been discussed in several email threads, but I would like to >> initiate a separate discussion on what tool we should use for reviweing >> the patches. >> >> Several people (inclu

RE: Patches review

2012-06-12 Thread Kevin Kluge
l Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Tuesday, June 12, 2012 1:02 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Patches review > > On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk > wrote: > > I know it's been discussed

Re: Patches review

2012-06-12 Thread David Nalley
On Tue, Jun 12, 2012 at 3:46 PM, Alena Prokharchyk wrote: > I know it's been discussed in several email threads, but I would like to > initiate a separate discussion on what tool we should use for reviweing > the patches. > > Several people (including myself - using Outlook on Mac OS X Lion) have

RE: Patches review

2012-06-12 Thread Prachi Damle
+1 to use some tool for review rather than using emails. I am struggling with email patches through Outlook still and haven't found a clean solution yet. I have no personal experience but have heard about Gerrit being good to achieve what is being listed below by Alena. -Prachi -Original