fine with the leading Spaces.
-Fang
-Original Message-
From: Mice Xia [mailto:weiran.x...@gmail.com]
Sent: Friday, February 22, 2013 4:00 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Commits with tabs & trailing white space
guys,
i know how to setup indent in eclipse, and th
-Original Message-
From: Mice Xia [mailto:weiran.x...@gmail.com]
Sent: Friday, February 22, 2013 4:00 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Commits with tabs & trailing white space
guys,
i know how to setup indent in eclipse, and this commit does not contain tabs.
there are &#
e as a convention, instead of notifying
>> each commit that breaks this convention, I would suggest we automate this
>> correction.
>>
>> Regards
>> Mice
>>
>> -Original Message-
>> From: Devdeep Singh [mailto:devdeep.si...@citrix.com]
&
f Rohit Yadav
>> Sent: Thursday, February 21, 2013 12:37 AM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: Commits with tabs & trailing white space
>>
>> On Thu, Feb 21, 2013 at 11:11 AM, Mice Xia
wrote:
>>> Sateesh,
>>>
>>> I
ying
>> each commit that breaks this convention, I would suggest we automate this
>> correction.
>>
>> Regards
>> Mice
>>
>> -Original Message-
>> From: Devdeep Singh [mailto:devdeep.si...@citrix.com]
>> Sent: Thursday, February 21, 201
+1 for git hook
-Fang
-Original Message-
From: Mice Xia [mailto:mice_...@tcloudcomputing.com]
Sent: Thursday, February 21, 2013 1:29 AM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Commits with tabs & trailing white space
+1 to git hook (for future) and sed (for exis
: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf Of Rohit
Yadav
Sent: Thursday, February 21, 2013 12:37 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Commits with tabs & trailing white space
On Thu, Feb 21, 2013 at 11:11 AM, Mice Xia wrote:
> Sateesh,
>
> I
;
> -Mice
>
> -Original Message-
> From: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf Of
> Rohit Yadav
> Sent: Thursday, February 21, 2013 4:37 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Commits with tabs & trailing white space
>
>
--
> From: Devdeep Singh [mailto:devdeep.si...@citrix.com]
> Sent: Thursday, February 21, 2013 1:14 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Commits with tabs & trailing white space
>
> As a contributor if a patch is submitted, applying that patch will fai
Singh [mailto:devdeep.si...@citrix.com]
> Sent: Thursday, February 21, 2013 1:14 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Commits with tabs & trailing white space
>
> As a contributor if a patch is submitted, applying that patch will fail if it
> has tra
Regards,
Sateesh
> -Original Message-
> From: Mice Xia [mailto:mice_...@tcloudcomputing.com]
> Sent: 21 February 2013 11:12
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Commits with tabs & trailing white space
>
> Sateesh,
>
> I just run
commit that breaks this convention, I would suggest we
>automate this correction.
>
>Regards
>Mice
>
>-Original Message-
>From: Devdeep Singh [mailto:devdeep.si...@citrix.com]
>Sent: Thursday, February 21, 2013 1:14 PM
>To: cloudstack-dev@incubator.apache.org
>Su
dstack-dev@incubator.apache.org
Subject: RE: Commits with tabs & trailing white space
As a contributor if a patch is submitted, applying that patch will fail if it
has trailing whitespaces. Maybe we should honor the convention of not
submitting code/patches with trailing spaces too.
Re
:mice_...@tcloudcomputing.com]
> Sent: Thursday, February 21, 2013 10:29 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Commits with tabs & trailing white space
>
> Leading spaces can be found everywhere in the codes, I think that's caused by
> IDE when intentionally leave an
4 spaces indent by code convention.
-Mice
-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: Thursday, February 21, 2013 12:44 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Commits with tabs & trailing white space
On Wed, Feb 20, 2013 at 11:37 PM, Sateesh Ch
On Wed, Feb 20, 2013 at 11:37 PM, Sateesh Chodapuneedi
wrote:
> Seeing commits containing tab spaces and trailing white spaces.
> Aren't we enforcing these checks?
>
> Regards,
> Sateesh
>
We desperately need more folks looking at the commit mails and calling
these issues out. (It looks like you
16 matches
Mail list logo
