Regards, Sateesh
> -----Original Message----- > From: Mice Xia [mailto:mice_...@tcloudcomputing.com] > Sent: 21 February 2013 11:12 > To: cloudstack-dev@incubator.apache.org > Subject: RE: Commits with tabs & trailing white space > > Sateesh, > > I just run some scripts: > > find . -name *.java |wc -l > 4220 > > find . -name *.java | xargs egrep -c "^[[:space:]]+$" | grep -v 0 | wc -l > 2117 > > So we have half java source files that have leading spaces in an empty line, > not > to mention trailing spaces and tabs. > > If we are going to enforce this rule as a convention, instead of notifying > each > commit that breaks this convention, I would suggest we automate this > correction. Yes, I am all for enforcing it, probably git hooks should suffice. > > Regards > Mice > > -----Original Message----- > From: Devdeep Singh [mailto:devdeep.si...@citrix.com] > Sent: Thursday, February 21, 2013 1:14 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Commits with tabs & trailing white space > > As a contributor if a patch is submitted, applying that patch will fail if it > has > trailing whitespaces. Maybe we should honor the convention of not submitting > code/patches with trailing spaces too. > > Regards, > Devdeep > > > -----Original Message----- > > From: Mice Xia [mailto:mice_...@tcloudcomputing.com] > > Sent: Thursday, February 21, 2013 10:29 AM > > To: cloudstack-dev@incubator.apache.org > > Subject: RE: Commits with tabs & trailing white space > > > > Leading spaces can be found everywhere in the codes, I think that's > > caused by IDE when intentionally leave an empty line. To me it's not a > > big deal and reviewboard provides "Hide Extra Whitespace & Hide Whitespace > changes" > > to filter these. Tab should be avoided, we use 4 spaces indent by code > > convention. > > > > -Mice > > > > -----Original Message----- > > From: David Nalley [mailto:da...@gnsa.us] > > Sent: Thursday, February 21, 2013 12:44 PM > > To: cloudstack-dev@incubator.apache.org > > Subject: Re: Commits with tabs & trailing white space > > > > On Wed, Feb 20, 2013 at 11:37 PM, Sateesh Chodapuneedi > > <sateesh.chodapune...@citrix.com> wrote: > > > Seeing commits containing tab spaces and trailing white spaces. > > > Aren't we enforcing these checks? > > > > > > Regards, > > > Sateesh > > > > > > > We desperately need more folks looking at the commit mails and calling > > these issues out. (It looks like you are doing the first, how about > > sending the nudge when you see it) Replies to commit messages will by > > default hit cloudstack- dev. > > > > --David
