api_refactoring
> API refactoring - Integrate hibernate validator
> ---
>
> Key: CLOUDSTACK-640
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-640
> Project: CloudStack
>
the list.
> API refactoring - Integrate hibernate validator
> ---
>
> Key: CLOUDSTACK-640
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-640
> Project: Cloud
way. But just put it there as a place holder,
so later we can go back
And state why we do NOT go. IF not make sense, we can delete it.
> API refactoring - Integrate hibernate validator
> ---
>
> Key
r it.
> API refactoring - Integrate hibernate validator
> ---
>
> Key: CLOUDSTACK-640
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-640
> Project: CloudStack
>
Fang Wang created CLOUDSTACK-640:
Summary: API refactoring - Integrate hibernate validator
Key: CLOUDSTACK-640
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-640
Project: CloudStack
[
https://issues.apache.org/jira/browse/CLOUDSTACK-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sudha Ponnaganti closed CLOUDSTACK-69.
--
> Hibernate jars should be remo
wscript_build
verified in my own build environment
> Hibernate jars should be removed
>
>
> Key: CLOUDSTACK-69
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-69
> Project: CloudStack
>
[
https://issues.apache.org/jira/browse/CLOUDSTACK-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajesh Battala closed CLOUDSTACK-52.
> AWSAPI contains hibernate configurati
o be modified or rpmbuild will complain
> Hibernate jars should be removed
>
>
> Key: CLOUDSTACK-69
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-69
> Project: CloudStack
>
g as resolved then?
-chip
> Hibernate jars should be removed
>
>
> Key: CLOUDSTACK-69
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-69
> Project: CloudStack
>
ews.apache.org/r/6967/
> ---
>
> (Updated Sept. 8, 2012, 7:40 a.m.)
>
>
> Review request for cloudstack, David Nalley and edison su.
>
>
> Description
> ---
>
> Removed awsapi/conf/CloudStack.cfg.xml
> Modified cloud.spec to
ster d9c03a55cfd482d2aa7a254e83ee75e7eaa02f7d
> AWSAPI contains hibernate configurations
>
>
> Key: CLOUDSTACK-52
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-52
> Project: CloudStack
>
ster 0d02e33d3154be3feb87c91e027389f0f8a64fec
> Hibernate jars should be removed
>
>
> Key: CLOUDSTACK-69
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-69
> Project: CloudStack
> Issue Type:
[
https://issues.apache.org/jira/browse/CLOUDSTACK-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mice Xia reassigned CLOUDSTACK-69:
--
Assignee: Mice Xia
> Hibernate jars should be remo
a.m.)
>
>
> Review request for cloudstack, David Nalley and edison su.
>
>
> Description
> ---
>
> Removed awsapi/conf/CloudStack.cfg.xml
> Modified cloud.spec to remove CloudStack.cfg.xml and hibernate config
> references
>
>
> This addres
Mice Xia created CLOUDSTACK-69:
--
Summary: Hibernate jars should be removed
Key: CLOUDSTACK-69
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-69
Project: CloudStack
Issue Type: Bug
/
> AWSAPI contains hibernate configurations
>
>
> Key: CLOUDSTACK-52
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-52
> Project: CloudStack
> Issue Type: Bug
---
Removed awsapi/conf/CloudStack.cfg.xml
Modified cloud.spec to remove CloudStack.cfg.xml and hibernate config references
This addresses bug CLOUDSTACK-52.
Diffs
-
awsapi/conf/CloudStack.cfg.xml 511e68f
cloud.spec ab445ff
Diff: https://reviews.apache.org/r/6967/diff/
Testing
Assignee: Rajesh Battala
> AWSAPI contains hibernate configurations
>
>
> Key: CLOUDSTACK-52
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-52
> Project: CloudStack
>
David Nalley created CLOUDSTACK-52:
--
Summary: AWSAPI contains hibernate configurations
Key: CLOUDSTACK-52
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-52
Project: CloudStack
Issue
> On Aug. 31, 2012, 6:46 p.m., Prachi Damle wrote:
> >
>
> Rajesh Battala wrote:
> Thanks alot Prachi for the review and committing my changes.
>
As the patch got committed to ASF Master am closing this review request.
- Rajesh
---
> On Aug. 31, 2012, 6:46 p.m., Prachi Damle wrote:
> >
Thanks alot Prachi for the review and committing my changes.
- Rajesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10950
I have merged Rajesh's change for removing the hibernate dependency. However I
could not test the build as there seems to be build issues currently with the
branch.
I will run a test build once the build issues are fixed.
Thanks,
Prachi
-Original Message-
From: Prachi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10950
---
Ship it!
- Prachi Damle
On Aug. 31, 2012, 4 a.m., Rajesh Battala w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 31, 2012, 4 a.m.)
Review request for cloudstack, Prachi Damle, Kis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10915
---
Rajesh,
I don't see the changes in the latest diff - still see lot o
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 30, 2012, 6:18 a.m.)
Review request for cloudstack, Prachi Damle,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10823
---
1) Why is CloudStackConfigurationVO placed in com.cloud.bridge.servic
> On Aug. 28, 2012, 5:53 a.m., Likitha Shetty wrote:
> > After applying the patch the following EC2 commands worked as expected:
> > user Registration, instance creation, volume creation, address allocation
> > and instance listing.
Thanks likitha for the review. If EC2 is working fine please
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10804
---
After applying the patch the following EC2 commands worked as expecte
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 27, 2012, 12:04 p.m.)
Review request for cloudstack, Prachi Damle,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 27, 2012, 11:48 a.m.)
Review request for cloudstack, Prachi Damle,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 27, 2012, 6:23 a.m.)
Review request for cloudstack, Prachi Damle,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10768
---
awsapi/src/com/cloud/bridge/persist/dao/CloudStackAccountDaoImpl.jav
Thanks a lot Alex for the comments.
From: Alex Huang
Sent: Saturday, August 25, 2012 2:05 AM
To: Rajesh Battala; Kishan Kavala; Prachi Damle
Cc: cloudstack
Subject: RE: Review Request: Moved Awsapi (EC2/S3) from Hibernate framework to
CloudStack Generic Dao Framework
From: Rajesh Battala
From: Rajesh Battala [mailto:nore...@reviews.apache.org] On Behalf Of Rajesh
Battala
Sent: Friday, August 24, 2012 5:20 AM
To: Kishan Kavala; Prachi Damle; Alex Huang
Cc: Rajesh Battala; cloudstack
Subject: Re: Review Request: Moved Awsapi (EC2/S3) from Hibernate framework to
CloudStack
> On Aug. 24, 2012, 8:29 a.m., Kishan Kavala wrote:
> > Dao should be injected using the interface and not its Implementing class.
> > ComponentLocator will then find the appropriate Implementing class using
> > components.xml
> >
> > Below code:
> >
> > protected final CloudStackConfiguratio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10723
---
awsapi/src/com/cloud/bridge/persist/dao/BucketPolicyDaoImpl.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/#review10722
---
Dao should be injected using the interface and not its Implementing c
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
(Updated Aug. 23, 2012, 4:24 p.m.)
Review request for cloudstack, Prachi Damle,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6749/
---
Review request for cloudstack, Prachi Damle, Kishan Kavala, and Alex Huang.
Desc
.
--Alex
> -Original Message-
> From: Will Chan [mailto:will.c...@citrix.com]
> Sent: Wednesday, August 15, 2012 5:33 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate -> Custom DAO for AWS component
>
> I'm pretty sure you can because the Usage S
org
> Subject: RE: Hibernate -> Custom DAO for AWS component
>
> One concern here... can we connect to multiple databases using CloudStack
> DAO Implementation?
>
> The awsapi component needs to connect to two databases - 'cloudbridge'
> db(used for user Auth and S3)
ng/default zone info)
With hibernate we could do that.
-Prachi
-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: Monday, August 13, 2012 10:46 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Hibernate -> Custom DAO for AWS component
I will r
> -Original Message-
> From: Darren Shepherd [mailto:dar...@godaddy.com]
> Sent: Monday, August 13, 2012 1:29 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate -> Custom DAO for AWS component
>
> I think there's two points.
>
> 1
@incubator.apache.org
Subject: RE: Hibernate -> Custom DAO for AWS component
I think there's two points.
1) Raw SQL is bad, so even in a time crunch moving to the custom CloudStack DAO
implementation *should* have been better.
2) I'd rather see a JPA based solution then moving to custom CloudStack
o what Darren said on the mailing list:
> >
> > I was just reviewing https://reviews.apache.org/r/6557/diff/ for the
> > Hibernate -> Custom DAO implementation and it makes me so sad. Its not
> > that you went from Hibernate ORM to custom built ORM (that is already in
> >
> -Original Message-
> From: Darren Shepherd [mailto:dar...@godaddy.com]
> Sent: Monday, August 13, 2012 1:29 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate -> Custom DAO for AWS component
>
>
> I think Alex and I agree on point 1,
sure if anybody agrees
with point 2. What's the time frame for when this was supposed to be
done?
Darren
Original Message ----
Subject: RE: Hibernate -> Custom DAO for AWS component
From: Will Chan
Date: Mon, August 13, 2012 12:56 pm
To: "cloudstack-dev@incubator.apa
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Monday, August 13, 2012 10:33 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate -> Custom DAO for AWS component
>
>
>
> > -Original Message-
>
> -Original Message-
> From: Darren Shepherd [mailto:dar...@godaddy.com]
> Sent: Sunday, August 12, 2012 8:25 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Hibernate -> Custom DAO for AWS component
>
> All,
>
> I was just reviewing https://revie
the
GenericDao stuff for now so that when we switch that layer we can switch
everything together.
Here's also what Darren said on the mailing list:
I was just reviewing https://reviews.apache.org/r/6557/diff/ for the Hibernate
-> Custom DAO implementation and it makes me so sad. Its
Hi,
I had created the patch for "Removing Hibernate Dependency in awsapi project".
I had uploaded the patch in the review tool https://reviews.apache.org/r/6557/
Please review it.
Thanks
Rajesh Battala
All,
I was just reviewing https://reviews.apache.org/r/6557/diff/ for the
Hibernate -> Custom DAO implementation and it makes me so sad. Its not
that you went from Hibernate ORM to custom built ORM (that is already in
CloudStack), you went from ORM to raw SQL. From the size of the diff
and
Prateek and Chiradeep Vittal.
Description
---
S3 API service in CloudStack is using Hibernate ORM Framework. Hibernate is
licensed under the LGPL v2.1.
Hibernate dependency is removed by moving S3/EC2 to DAO Omplementation.
This addresses bugs CS-15314 and CS-15686.
Diffs
-
awsapi
.
Description
---
S3 API service in CloudStack is using Hibernate ORM Framework. Hibernate is
licensed under the LGPL v2.1.
Hibernate dependency is removed by moving S3/EC2 to DAO Omplementation.
This addresses bugs CS-15314 and CS-15686.
Diffs
-
awsapi/.classpath 4dc46c4
awsapi/conf
Am working on it.
Done removing EC2 from Hibernate dependency. Committed the patch locally and
testing is almost done.
Will send patch for the same by tomorrow.
Removing Hibernate dependency in S3 project is going on. I would be sending the
patch for it by end of this week.
Thanks
Rajesh
sage-
> >> From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com]
> >> Sent: Tuesday, July 17, 2012 9:03 AM
> >> To: cloudstack-dev@incubator.apache.org
> >> Subject: RE: Hibernate
> >>
> >> OK, good. So it's a small job. So is Rajesh doing
sday, July 17, 2012 9:03 AM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: RE: Hibernate
>>
>> OK, good. So it's a small job. So is Rajesh doing that?
>>
>> Ewan.
>>
>> > -Original Message-
>> > From: Alex Huang [mailto
Yes Ewan, I would be doing this work.
Thanks
Rajesh Battala
> -Original Message-
> From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com]
> Sent: Tuesday, July 17, 2012 9:03 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate
>
> OK, good. So it&
OK, good. So it's a small job. So is Rajesh doing that?
Ewan.
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: 16 July 2012 17:03
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate
>
> My understanding is it&
My understanding is it's one table and is already wrapped by a DAO. The DAO
object uses hibernate underneath. Don't think it's a big job.
--Alex
> -Original Message-
> From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com]
> Sent: Monday, July 16, 2012 4:43
If I read this infinitely long thread correctly, the conclusion is that
CloudStack/awsapi needs to be rewritten to use the CloudStack DAO instead of
Hibernate. Is that correct?
If so, who is doing this work, and when? That sounds like a big job.
Thanks,
Ewan.
> -Original Mess
> I don't want to speak for Alex, but I have heard him mention such a change
> number of times, and have seen it in his slides as well.
>
> But the larger sense is that if we are going to change something in AWSAPI
> for communicating to the database, it should be something that we are
> comfortab
Which would mean your code
should migrate over along with the rest of the changes.
--Alex
> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Monday, July 02, 2012 10:59 PM
> To: cloudstack-dev@incubator.apache.org
> Su
> -Original Message-
> From: Kelven Yang [mailto:kelven.y...@citrix.com]
> Sent: Saturday, June 30, 2012 3:31 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate
>
>
>
> > -Original Message-
> > From: David Nalley [mailto:d
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Friday, June 29, 2012 10:37 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Hibernate
>
> On Fri, Jun 29, 2012 at 12:13 PM, Rajesh Battala
> wrote:
> >
> >
>
On Fri, Jun 29, 2012 at 12:13 PM, Rajesh Battala
wrote:
>
>
>> -Original Message-
>> From: David Nalley [mailto:da...@gnsa.us]
>> Sent: Friday, June 29, 2012 8:40 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: Hibernate
>>
>>
The discussion is going a bit far away from the original topic, CloudBridge
project does have certain usage on Hibernate, but it is very minimum. Just less
than a dozen of Dao classes needs to be replaced, Rajesh and I had a discussion
a while ago, whether to just use direct JDBC or to use
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Friday, June 29, 2012 8:40 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Hibernate
>
> On Fri, Jun 29, 2012 at 9:27 AM, Rajesh Battala
> wrote:
> >
> > Shall I pr
On Fri, Jun 29, 2012 at 9:27 AM, Rajesh Battala
wrote:
>
> Shall I proceed to replace Hibernate Framework with Spring JDBC.
>
This is not a design decision to take lightly, or rush - as we've
talked about replacing the custom ORM that CloudStack uses as well -
we'd want to
>
>
> Shall I proceed to replace Hibernate Framework with Spring JDBC.
>
We should rethink anything that requires raw SQL. Even object queries would be
better. At least eclipse has a way to tell you that the query and the actual
object have diverged.
--Alex
. Spring is free and it's based on Apache License. We can use spring jars in
our repos.
Shall I proceed to replace Hibernate Framework with Spring JDBC.
Thanks
Rajesh Battala
> -Original Message-
> From: Kevin Kluge [mailto:kevin.kl...@citrix.com]
> Sent: Friday, June 29, 201
As for a RDBM database the usage of an inverted index is required for
complex query.
Hibernate search is based on lucene (if my memory is good), we use SOLR.
On Thu, Jun 28, 2012 at 9:37 PM, Frank Zhang wrote:
> >
> > Very interesting.
> >
> > So after the read of
>
> Very interesting.
>
> So after the read of this explanation and the architecture and coding
> implication of the usage of Hibernate my question stay the same
>
> Does the ORM approach based on a relational DB is the good way ?
> The usage of a Document Orient
Very interesting.
So after the read of this explanation and the architecture and coding
implication of the usage of Hibernate
my question stay the same
Does the ORM approach based on a relational DB is the good way ?
The usage of a Document Oriented Database seem more in adequacy with the
d which is the primary
key in database to composite object graph.
Current popular ORM, Hibernate or JPA, use one-to-many, many-to-one,
many-to-many or new annotation(JPA2) like MapKeyJoinColumn to make object
graph transparent just as you mentioned. However, this doesn't f
.
*The power of Hibernate is to try for the user to make transparent the
management of a graph object*
*There is NO graph object in Cloudstack as far I can see.*
*
*
*In the other side I think the Business Domain of the System Management is
more document oriented.*
*For exemple a VM can be represented
with Hibernate core api. However, the workload is smaller as
Hibernate core API is quite similar to JPA.
I definitely vote option 2.
No matter whether using Spring, awsapi have to rework as it wires Hibernate
core api which asks compile dependency.
> -Original Message-
> From:
gt; Subject: RE: Hibernate
>
> Rajesh, can you provide some rationale for this choice versus other
> options.
>
> -kevin
>
> > -Original Message-
> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> > Sent: Wednesday, June 27, 2012 10:44 PM
> >
Rajesh, can you provide some rationale for this choice versus other options.
-kevin
> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Wednesday, June 27, 2012 10:44 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate
Have you take a look to monogDB ?
On Thu, Jun 28, 2012 at 2:09 PM, David Nalley wrote:
>
>
>
>
> On Jun 28, 2012, at 10:11 AM, Frank Zhang wrote:
>
> > Spring is able to downgrade dependency of hibernate from compile to
> runtime, however, I am surprise at failing t
On Jun 28, 2012, at 10:11 AM, Frank Zhang wrote:
> Spring is able to downgrade dependency of hibernate from compile to runtime,
> however, I am surprise at failing to yum search "hibernate" on my FC15.
> Then I did a quick google "hibernate centos rpm" and go
10:18 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Hibernate
>
> Sorry please ignore my former mail
>
> > > Am looking at replace Hibernate with Spring Framework
> > > simpleJDBCTemplate.
> Does this mean ripping out Hibernate? Then we don
Sorry please ignore my former mail
> > Am looking at replace Hibernate with Spring Framework
> > simpleJDBCTemplate.
Does this mean ripping out Hibernate? Then we don't have dependency on
Hibernate anymore.
I am afraid that AWS API will refactor a bit, as we are jumping from
Spring is able to downgrade dependency of hibernate from compile to runtime,
however, I am surprise at failing to yum search "hibernate" on my FC15.
Then I did a quick google "hibernate centos rpm" and got nothing.
I suggest before digging into Spring, make sure hibernate
Hi,
I had started working on this issue. As Hibernate is LGPL we cannot use this in
our Apache repo.
I had discussed with Chiradeep and Kelven.
Am looking at replace Hibernate with Spring Framework simpleJDBCTemplate.
The Spring Framework is released under version 2.0 of the Apache
ot; wrote:
>
>
>
>
> On Jun 28, 2012, at 12:45 AM, Sheng Liang wrote:
>
>>> In short, I see three options (please comment if you see more) 1. Rip out
>>> hibernate and replace with some other ORM 2. Make the AWS API bits an
>>> optional non-defau
On Jun 28, 2012, at 12:45 AM, Sheng Liang wrote:
>> In short, I see three options (please comment if you see more) 1. Rip out
>> hibernate and replace with some other ORM 2. Make the AWS API bits an
>> optional non-default part of the build.
> 3. Declare that
> In short, I see three options (please comment if you see more) 1. Rip out
> hibernate and replace with some other ORM 2. Make the AWS API bits an
> optional non-default part of the build.
3. Declare that hibernate is a system requirement for CloudStack
I prefer option #1. It is the
As you may have seen from an earlier comment on a commit message, the AWS API
piece of CloudStack uses Hibernate, which is LGPL licensed, and is thus
verboten.
Several issues exist, first, Hibernate is a build dependency at present, not
just a runtime dependency. I suppose we could define
91 matches
Mail list logo