Re: Review Request: CS-15609 Volumes can be created as a part of VM creation when un-allocated space is insufficient on primary storage

2012-07-24 Thread disheng su
t into AbstractStoragePoolAllocator, e.g. adding a new method, called storagepoolhasenoughspace, the input parameter is a map, then calculate the storagepool has enough space or not. - disheng su On July 18, 2012, 1:29 p.m., mice xia wrote: > > ---

Re: Review Request: CS-15048: Log rotation functionality in system VMs is broken resuting in 100% of disk space getting consumed.

2012-07-24 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5907/#review9420 --- Ship it! Ship It! - disheng su On July 11, 2012, 10:23 a.m

Re: Review Request: CS-15521 Xenserver based User VM failed to HA when vrouter runs on ESXi

2012-07-24 Thread disheng su
. As pingtestcommand is testing user vm's aliveness, need to make sure pingtestcommand returns the correct vm status. Take scripts/vm/pingtest.sh as an example. - disheng su On July 11, 2012, 3:14 a.m., mice xia wrote: > > --- &

Re: Review Request: parms should be a copy instead of a reference as locals() is bound to change over time

2012-07-24 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5828/#review9413 --- Ship it! Ship It! - disheng su On July 9, 2012, 6:39 a.m., Hugo

Re: Review Request: cloud-vmware.jar needs to be in the system vm for the PremiumSecondaryStorageResource to work

2012-07-24 Thread disheng su
can't just add PremiumSecondaryStorageResource back into core, as it depends on vmware library, thus may break the apache license. As we already build vmware separately, need a way to add vmware related jar files into agent.tgz, such as "ant package-agent-with-vmware" - disheng

Re: Review Request: fix CS-15432 Failed to detach VMware tools ISO after VMware tools installation

2012-07-24 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5738/#review9410 --- Ship it! Ship It! - disheng su On July 4, 2012, 5:51 a.m., mice

Re: Review Request: Adding the replace.properties file back to master branch. replace.properties file got deleted due to some commit in master branch.

2012-07-24 Thread disheng su
fecb8 - disheng su On June 21, 2012, 7:01 p.m., Rajesh Battala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request: Run the simulator from ant target for debugging CloudStack on localhost

2012-07-16 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5929/#review9180 --- Ship it! Ship It! - disheng su On July 16, 2012, 11:03 a.m

Re: Review Request: Add trust="yes" option to ssh tasks

2012-07-10 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5897/#review9043 --- Ship it! Ship It! - disheng su On July 10, 2012, 11:26 p.m

Re: Review Request: Minor devcloudsetup.sh additions.

2012-07-10 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5877/#review9026 --- Ship it! Ship It! - disheng su On July 10, 2012, 1:06 p.m., Chip

Re: Review Request: Fix deploy-db-simulator.sh to create cloud_usage database

2012-07-03 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5734/#review8865 --- Ship it! Applied, thanks. - disheng su On July 3, 2012, 10:08 p.m

Re: Review Request: Fix deploy-db-simulator.sh to create cloud_usage database

2012-07-03 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5734/#review8862 --- missing create-schema-premium? - disheng su On July 3, 2012, 9:33

Re: Review Request: Fix deployDataCenter.py to allow creating basic zone with or without security groups

2012-07-03 Thread disheng su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5726/#review8853 --- Ship it! Applied, thanks for your patch. - disheng su On July 3

Re: Review Request: Make xen.check.hvm a proper parameter

2012-06-29 Thread disheng su
for configurationdao true - disheng su On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apach