-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5903/#review9417
-----------------------------------------------------------


The correct way is ssh into router vm, then ping user vm ip address. As 
pingtestcommand is testing user vm's aliveness, need to make sure 
pingtestcommand returns the correct vm status. Take scripts/vm/pingtest.sh as 
an example.

- disheng su


On July 11, 2012, 3:14 a.m., mice xia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5903/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 3:14 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> Change:
> return false as an answer when executing PingTestCommand in VMwareResource
> 
> Parent patch:
> https://reviews.apache.org/r/5738/
> they are not related, but the line number has been changed in the parent patch
> 
> 
> This addresses bug CS-15521.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b52d441 
> 
> Diff: https://reviews.apache.org/r/5903/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mice xia
> 
>

Reply via email to