Re: svn r1370 appears to have broken binding

2009-05-27 Thread Rich Hickey
On May 27, 7:59 am, Frantisek Sodomka wrote: > Thanks for the help and your feedback, Steve! > > Clojure needs some unit tests and I like writing them, so it is a win- > win situation :-) > Let me add my thanks as well - this is a great (and otherwise thankless :) contribution. I also wanted

Re: svn r1370 appears to have broken binding

2009-05-27 Thread Frantisek Sodomka
Thanks for the help and your feedback, Steve! Clojure needs some unit tests and I like writing them, so it is a win- win situation :-) Yes, this is our first test in clojure-contrib.test-clojure.vars. I checked it in together with other changes as revision 846. Frantisek On May 26, 9:27 pm, "

Re: svn r1370 appears to have broken binding

2009-05-26 Thread Stephen C. Gilardi
Hi Frantisek! On May 25, 2009, at 7:11 AM, Frantisek Sodomka wrote: (def a) (deftest test-binding (are (= _1 _2) (binding [a 4] a) 4 ; regression in Clojure SVN r1370 )) I see those tests going in over time... Thanks so much for making them! The checkin notes for this change ment

Re: svn r1370 appears to have broken binding

2009-05-25 Thread Rich Hickey
On Mon, May 25, 2009 at 5:35 AM, Stephen C. Gilardi wrote: > With svn r1370, I get this: > >% java -cp clojure.jar clojure.main >Clojure 1.1.0-alpha-SNAPSHOT >user=> (def a) >#'user/a >user=> (binding [a 4] a) >java.lang.IllegalStateException: Var u

Re: svn r1370 appears to have broken binding

2009-05-25 Thread Frantisek Sodomka
Hello Steve! When I write a test for binding for this case (using deftest) and run test_clojure, it doesn't error out. I wonder why is that? (def a) (deftest test-binding (are (= _1 _2) (binding [a 4] a) 4 ; regression in Clojure SVN r1370 )) Frantisek PS: Rich, have you seen my

svn r1370 appears to have broken binding

2009-05-25 Thread Stephen C. Gilardi
With svn r1370, I get this: % java -cp clojure.jar clojure.main Clojure 1.1.0-alpha-SNAPSHOT user=> (def a) #'user/a user=> (binding [a 4] a) java.lang.IllegalStateException: Var user/a is unbound. (NO_SOURCE_FILE:0) user=> With svn r1369, I ge