Re: Next ClojureScript Release: 1 more ticket

2013-11-20 Thread David Nolen
While talk is great a patch is better. If no one commits to a patch we will release and take a patch when we get it. Accounting for platforms is a lot of work and in the future it's only going to get more complicated. Community support is critical here. On Wednesday, November 20, 2013, David Powel

Re: [ClojureScript] Re: Next ClojureScript Release: 1 more ticket

2013-11-20 Thread David Powell
I think a good approach might be to: Keep everything as file:// urls given that we need to use urls anyway for.jar references. Never call .getPath on a URI / URL - it undoes the URL escaping that we want, and it returns weird /c:/ things on Windows that don't work as anything. Write our own URL

Re: Next ClojureScript Release: 1 more ticket

2013-11-20 Thread David Nolen
OK this is definitely a case where a patch from Windows users is most welcome. I'm willing to stall a release if someone will step forward. Thanks! David On Wednesday, November 20, 2013, David Powell wrote: > > It still isn't working on Windows. > > At > https://github.com/clojure/clojurescript/

Re: [ClojureScript] Re: Next ClojureScript Release: 1 more ticket

2013-11-20 Thread David Powell
It still isn't working on Windows. At https://github.com/clojure/clojurescript/blob/047dbb3d2bd7c3a2e00805ec2f2480e449451521/src/clj/cljs/closure.clj#L750 path is either a file:// url or something like: "/C:/Temp/cstest2/out/cljs/core.js" - which is a bit mangled, and is caused by calling .getPat

Re: Next ClojureScript Release: 1 more ticket

2013-11-20 Thread David Nolen
And by "take a look", I mean confirm that the issue no longer exists in master. David On Wed, Nov 20, 2013 at 6:12 PM, David Nolen wrote: > If you are using ClojureScript source maps please try master and give us > feedback, the experience should be significantly improved and we now have > cle