OK this is definitely a case where a patch from Windows users is most welcome. I'm willing to stall a release if someone will step forward.
Thanks! David On Wednesday, November 20, 2013, David Powell wrote: > > It still isn't working on Windows. > > At > https://github.com/clojure/clojurescript/blob/047dbb3d2bd7c3a2e00805ec2f2480e449451521/src/clj/cljs/closure.clj#L750 > > path is either a file:// url or something > like: "/C:/Temp/cstest2/out/cljs/core.js" - which is a bit mangled, and is > caused by calling .getPath on a file URL. > > But (keys (::comp/compiled-cljs @env/*compiler*)) are absolute File paths > with backslashes, eg "C:\Temp\cstest2\out\cljs\core.js" > > > I think calling .getPath on a file:// URL or URI might be questionable > unless you are going to carefully relativize it before you do anything with > it. > > > Also note that the changes on master use java.io.File.toPath() which > requires Java 7. > > > We should probably check that everything works with paths with spaces in > too. Whatever process converts files to urls needs to know to apply url > escaping. > > > -- > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to > clojure@googlegroups.com<javascript:_e({}, 'cvml', > 'clojure@googlegroups.com');> > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com <javascript:_e({}, 'cvml', > 'clojure%2bunsubscr...@googlegroups.com');> > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com <javascript:_e({}, 'cvml', > 'clojure%2bunsubscr...@googlegroups.com');>. > For more options, visit https://groups.google.com/groups/opt_out. > -- -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
