Re: Feedback on datafy/nav project

2020-01-31 Thread Derek Troy-West
alive." > -- Margaret Atwood > > > > *From: *dimitris > *Sent: *Friday, January 31, 2020 1:23 PM > *To: *clo...@googlegroups.com > *Subject: *Re: Feedback on datafy/nav project > > > > Ok, thanks a million Alex > > > > On 31/01/2020 21:13,

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
nuary 31, 2020 1:23 PM *To: *clojure@googlegroups.com <mailto:clojure@googlegroups.com> *Subject: *Re: Feedback on datafy/nav project Ok, thanks a million Alex On 31/01/2020 21:13, Alex Miller wrote: Datafiable is not special, the guidelines (recently refreshed with Rich's input

RE: Feedback on datafy/nav project

2020-01-31 Thread Sean Corfield
;re not really alive." -- Margaret Atwood From: dimitris Sent: Friday, January 31, 2020 1:23 PM To: clojure@googlegroups.com Subject: Re: Feedback on datafy/nav project Ok, thanks a million Alex On 31/01/2020 21:13, Alex Miller wrote: Datafiable is not special, the guidelines (recently refreshed wi

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
iew -- http://corfield.org/ "If you're not annoying somebody, you're not really alive." -- Margaret Atwood *From: *dimitris <mailto:jimpil1...@gmail.com> *Sent: *Thursday, January 30, 2020 9:58 AM *To: *clojure@googlegroups.com <mailto:clojure@go

Re: Feedback on datafy/nav project

2020-01-31 Thread Alex Miller
An Architect's View -- http://corfield.org/ > > "If you're not annoying somebody, you're not really alive." > -- Margaret Atwood > > > > *From: *dimitris > *Sent: *Thursday, January 30, 2020 9:58 AM > *To: *clojure@googlegroups.com > *Subj

Re: Feedback on datafy/nav project

2020-01-31 Thread dimitris
mitris <mailto:jimpil1...@gmail.com> *Sent: *Thursday, January 30, 2020 9:58 AM *To: *clojure@googlegroups.com <mailto:clojure@googlegroups.com> *Subject: *Re: Feedback on datafy/nav project Well, the official Clojure guidelines are to NOT extend protocols, unless you own either the pro

RE: Feedback on datafy/nav project

2020-01-30 Thread Sean Corfield
;re not really alive." -- Margaret Atwood From: dimitris Sent: Thursday, January 30, 2020 9:58 AM To: clojure@googlegroups.com Subject: Re: Feedback on datafy/nav project Well, the official Clojure guidelines are to NOT extend protocols, unless you own either the protocol of the type(s) [1]. In p

Re: Feedback on datafy/nav project

2020-01-30 Thread dimitris
Hmmm... how would that work? I want datafy to work on java.time objects - not Clojure maps (as you showed). On 30/01/2020 18:37, Christian Gonzalez wrote: I think you could also add some metadata to allow datafy-ing instead of extending the protocol: (with-meta {:name "John Doe" :language "u

Re: Feedback on datafy/nav project

2020-01-30 Thread Christian Gonzalez
I think you could also add some metadata to allow datafy-ing instead of extending the protocol: (with-meta {:name "John Doe" :language "us"} {`clojure.core.protocols/datafy (fn [x] ...)}) On Thursday, January 30, 2020 at 10:28:20 AM UTC-8, Jim foo.bar wrote: > > Moreover, following the mailing

Re: Feedback on datafy/nav project

2020-01-30 Thread dimitris
Moreover, following the mailing discussion linked from the clojure.org site, leads to the following quote from Rich - about 10 years ago :) /If a protocol comes with Clojure itself, avoid extending it to types // //you don't own, especially e.g. java.lang.String and other core Java // //interfac

Re: Feedback on datafy/nav project

2020-01-30 Thread dimitris
Well, the official Clojure guidelines are to NOT extend protocols, unless you own either the protocol of the type(s) [1]. In particular these lines:/ / /If you are a library developer, you should not extend if you own neither the protocol nor the target./ /You should take particular care whe

RE: Feedback on datafy/nav project

2020-01-30 Thread Sean Corfield
Is there a reason you’ve mirrored those protocols/implementations rather than just use Clojure’s built-in versions? As it stands, your library wouldn’t work with other tooling that builds on Clojure’s datafy/nav (REBL, for example). Sean Corfield -- (904) 302-SEAN An Architect's View -- http://