Re: Patching core.match

2013-05-29 Thread David Pollak
David, I figured out something of a hack... in MapPattern, I just put a guard around all the wildcard patterns. ;-) The patch and tests are uploaded to Jira. I look forward to helping as I can on core.match Thanks for your excellent work! David On Wed, May 29, 2013 at 12:57 PM, David Nolen

Re: Patching core.match

2013-05-29 Thread David Pollak
David, I'm the king of process in Lift-land and we have a ton of process that makes people unhappy. I'm happy to follow the Clojure community process and respect this community. Rock on! David On Wed, May 29, 2013 at 12:57 PM, David Nolen wrote: > It's actually nice to use pull requests as a

Re: Patching core.match

2013-05-29 Thread David Nolen
It's actually nice to use pull requests as a form of review and I don't discourage that at all. But in order to facilitate the process it's easier if you attach the patch yourself to the ticket as we're not allowed to actually merge in pull requests. I know, I know, it's a bit of rigamarole but tha

Re: Patching core.match

2013-05-29 Thread David Pollak
I'm mailing my CLA to Rich right now. I'll do a pull request for the new tests and the changed code. Please look at the pull request and fix/apply it when I've been added to the Clojure contributors. On Wed, May 29, 2013 at 12:36 PM, David Nolen wrote: > Good catch - please file a ticket here

Re: Patching core.match

2013-05-29 Thread David Nolen
Good catch - please file a ticket here http://dev.clojure.org/jira/browse/MATCH. Please attach any work-in-progress patch you may have there and I'll review. Before I can apply any work you've done you need to send in your Contributor Agreement (CA) - http://clojure.org/contributing Thanks, David

Patching core.match

2013-05-29 Thread David Pollak
Howdy, I'm looking to patch core.match. There are a couple of cases where the pattern matcher eliminates rows (basically, if you're pattern matching against a Map, a row containing a map that has all wildcards will be considered a "wildcard" row and all the subsequent rows will be removed). Here's