Re: [Clamav-devel] Code style with commit ffa31264a657618a0e40c51c01e4bfc32e244d13

Yup. I saw the follow-up commit. Thanks! -- Shawn Webb Cofounder and Security Engineer of HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE On Mon, Jul 31, 2017 at 09:45:52PM +, Joel Esler (jesler) wrote: > Shawn, >

Re: [Clamav-devel] Code style with commit ffa31264a657618a0e40c51c01e4bfc32e244d13

Shawn, Thanks for writing in, looks like we’ve already re-formatted this code for 99.3, which should be released soon. -- Joel Esler | Talos: Manager | jes...@cisco.com > On Jul 20, 2017, at 2:36 PM, Shawn Webb wrote: > > Hey ClamAV Developers, > > The part o

[Clamav-devel] Code style with commit ffa31264a657618a0e40c51c01e4bfc32e244d13

Hey ClamAV Developers, The part of the diff that reads: if ( !(len = sys->read(fh, &buf[0], 256) > 0)) { is a little awkward. I'm wondering if it would be better to be split out. Something like this: len = sys->read(fh, buf, sizeof(buf)); if (len <= 0) { ... } That would make the code a bit mo