Hey ClamAV Developers, The part of the diff that reads:
if ( !(len = sys->read(fh, &buf[0], 256) > 0)) {
is a little awkward. I'm wondering if it would be better to be split
out. Something like this:
len = sys->read(fh, buf, sizeof(buf));
if (len <= 0) {
...
}
That would make the code a bit more readable for future developers. It
would also prevent issues in case the size of buf were to ever change in
the future.
Thanks,
--
Shawn Webb
Cofounder and Security Engineer of HardenedBSD
GPG Key ID: 0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE
signature.asc
Description: PGP signature
_______________________________________________ http://lurker.clamav.net/list/clamav-devel.html Please submit your patches to our Bugzilla: http://bugs.clamav.net http://www.clamav.net/contact.html#ml
