https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/91628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/91750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
Thanks! I'm surprised that this part was missing previously...
https://github.com/llvm/llvm-project/pull/91750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -24,6 +24,7 @@ add_clang_unittest(ASTTests
CommentLexer.cpp
CommentParser.cpp
CommentTextTest.cpp
+ ConceptPrinterTest.cpp
zyn0217 wrote:
Note: we probably want to update the gn build as well:
https://github.com/llvm/llvm-project/tree/main/llvm/util
@@ -2583,11 +2580,27 @@ struct ConvertConstructorToDeductionGuideTransform {
//-- The types of the function parameters are those of the constructor.
for (auto *OldParam : TL.getParams()) {
- ParmVarDecl *NewParam =
- transformFunctionTypeParam(OldPara
@@ -79,14 +79,14 @@ template struct Y2 {}; //
expected-note {{partial
template class U, typename... Z>
struct Y3 { Y3()=delete; };
template class U, typename... Z>
-struct Y3 { Y3()=delete; };
+struct Y3 { Y3()=delete; }; // expected-note {{partial
specialization matches [wit
@@ -2257,6 +2257,11 @@ void StmtProfiler::VisitSubstNonTypeTemplateParmExpr(
const SubstNonTypeTemplateParmExpr *E) {
// Profile exactly as the replacement expression.
Visit(E->getReplacement());
+ if (auto *NTTP =
+ dyn_cast_if_present(E->getParameter());
---
@@ -79,14 +79,14 @@ template struct Y2 {}; //
expected-note {{partial
template class U, typename... Z>
struct Y3 { Y3()=delete; };
template class U, typename... Z>
-struct Y3 { Y3()=delete; };
+struct Y3 { Y3()=delete; }; // expected-note {{partial
specialization matches [wit
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
@@ -9806,7 +9806,7 @@ QualType Sema::BuildCountAttributedArrayType(QualType
WrappedTy,
/// that expression, according to the rules in C++11
/// [dcl.type.simple]p4 and C++11 [expr.lambda.prim]p18.
QualType Sema::getDecltypeForExpr(Expr *E) {
- if (E->isTypeDependent())
+ if
https://github.com/zyn0217 approved this pull request.
Thanks for the prompt fix! I think this looks good now, but please wait for
@erichkeane for the final stamp.
https://github.com/llvm/llvm-project/pull/91933
___
cfe-commits mailing list
cfe-commit
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/92104
Clangd uses it to determine whether the argument is within the selection range.
Fixes https://github.com/clangd/clangd/issues/2033
>From d9c0121067162ffb68bc70b9a0a3f10e0b05674c Mon Sep 17 00:00:00 2001
From: Yo
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/92104
>From d9c0121067162ffb68bc70b9a0a3f10e0b05674c Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Tue, 14 May 2024 19:46:20 +0800
Subject: [PATCH 1/2] [Clang] Retain the angle loci for invented template
parameter
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86629
>From b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 16 Mar 2024 23:30:10 +0800
Subject: [PATCH 01/10] [clangd] Support go-to-definition on type hints. The
core p
zyn0217 wrote:
Thanks for the review!
The Linux CI is green, so I presume so is the sluggish Windows CI. Landing it
now.
https://github.com/llvm/llvm-project/pull/92104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/92104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86629
>From b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 16 Mar 2024 23:30:10 +0800
Subject: [PATCH 01/10] [clangd] Support go-to-definition on type hints. The
core p
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/92385
We previously doubled the id-expression expansion, even when the pack was
expanded to empty. The previous condition for determining whether we should
expand couldn't distinguish between cases where 'the expansio
@@ -4381,11 +4381,13 @@ class PackIndexingExpr final
PackIndexingExpr(QualType Type, SourceLocation EllipsisLoc,
SourceLocation RSquareLoc, Expr *PackIdExpr, Expr
*IndexExpr,
- ArrayRef SubstitutedExprs = {})
+ ArrayRef
zyn0217 wrote:
> So, I think the correct fix is to propagate dependence in
> ASTContext::getUnconstrainedType. I have a branch that implements this here.
> WDYT @erichkeane @cor3ntin @zyn0217
That looks similar to the approach which I investigated some time ago. The
difference is that I remov
https://github.com/zyn0217 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/92425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -723,6 +723,7 @@ Bug Fixes to C++ Support
- Clang now ignores template parameters only used within the exception
specification of candidate function
templates during partial ordering when deducing template arguments from a
function declaration or when
taking the addres
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/92425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/92385
>From 7acbb1dd89dbe266c3e53ab30178ac570722c759 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 16 May 2024 19:06:25 +0800
Subject: [PATCH 1/2] [Clang][Sema] Avoid pack expansion for expanded empty
PackInd
https://github.com/zyn0217 commented:
@cor3ntin PTAL. Thanks!
https://github.com/llvm/llvm-project/pull/92385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2157,11 +2157,11 @@ void ASTStmtWriter::VisitSizeOfPackExpr(SizeOfPackExpr
*E) {
void ASTStmtWriter::VisitPackIndexingExpr(PackIndexingExpr *E) {
VisitExpr(E);
Record.push_back(E->TransformedExpressions);
+ Record.push_back(E->EmptyPack);
Record.AddSourceLocation(E
@@ -4377,15 +4377,20 @@ class PackIndexingExpr final
// The pack being indexed, followed by the index
Stmt *SubExprs[2];
- size_t TransformedExpressions;
+ // The size of the trailing expressions.
+ unsigned TransformedExpressions : 31;
zyn0217 wrote:
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/92385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4377,15 +4377,20 @@ class PackIndexingExpr final
// The pack being indexed, followed by the index
Stmt *SubExprs[2];
- size_t TransformedExpressions;
+ // The size of the trailing expressions.
+ unsigned TransformedExpressions : 31;
zyn0217 wrote:
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/92385
>From 7acbb1dd89dbe266c3e53ab30178ac570722c759 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 16 May 2024 19:06:25 +0800
Subject: [PATCH 1/3] [Clang][Sema] Avoid pack expansion for expanded empty
PackInd
@@ -2157,11 +2157,11 @@ void ASTStmtWriter::VisitSizeOfPackExpr(SizeOfPackExpr
*E) {
void ASTStmtWriter::VisitPackIndexingExpr(PackIndexingExpr *E) {
VisitExpr(E);
Record.push_back(E->TransformedExpressions);
+ Record.push_back(E->EmptyPack);
Record.AddSourceLocation(E
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/92385
>From 7acbb1dd89dbe266c3e53ab30178ac570722c759 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 16 May 2024 19:06:25 +0800
Subject: [PATCH 1/4] [Clang][Sema] Avoid pack expansion for expanded empty
PackInd
@@ -2157,11 +2157,11 @@ void ASTStmtWriter::VisitSizeOfPackExpr(SizeOfPackExpr
*E) {
void ASTStmtWriter::VisitPackIndexingExpr(PackIndexingExpr *E) {
VisitExpr(E);
Record.push_back(E->TransformedExpressions);
+ Record.push_back(E->EmptyPack);
Record.AddSourceLocation(E
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/92385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
Thanks! I added that test to check if the instantiation stack guard takes
effect in clangd. And the change makes sense to me.
https://github.com/llvm/llvm-project/pull/92888
___
cfe-commits mailin
zyn0217 wrote:
@jyu2-git Are you sure this is the patch you’re looking for? The diagnostic
there is completely unrelated and I think the right patch is
https://github.com/llvm/llvm-project/pull/90152.
https://github.com/llvm/llvm-project/pull/89019
_
zyn0217 wrote:
> It seems this change cause https://godbolt.org/z/311nb6xYe to fail. Could you
> please take look?
> Also:
> https://godbolt.org/z/bYs7Y9v11
I don't see any justification that these examples should compile: the first
example is a typical one handled by #90152
(from the release
zyn0217 wrote:
@HighCommander4 No problem, I'm always delighted to receive responses! However
it might take me some time to pick up my thoughts, as the patch has been a
while. Anyway, I will try to revive this patch in the next few days and let's
see if we can make it into clangd 19.
https://
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/93206
This patch picks up #78598 with the hope that we can address such crashes in
`tryCaptureVariable` for unevaluated lambdas.
Fixes #88081
Fixes #69307
Fixes #91633
Fixes #90669
Fixes #89496
>From 4419914727aeb
zyn0217 wrote:
Unfortunately, @l1nxy told me privately that he will not take over that patch
as anticipated. So I hope I can continue the work.
I'll add a release note and supplement some comments tomorrow.
https://github.com/llvm/llvm-project/pull/93206
___
@@ -1036,6 +1036,7 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
// be dependent, because there are template parameters in scope.
CXXRecordDecl::LambdaDependencyKind LambdaDependencyKind =
CXXRecordDecl::LDK_Unknown;
+
z
zyn0217 wrote:
(What's going on with the pre-commit CI? Does it disappear?)
https://github.com/llvm/llvm-project/pull/93206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -111,6 +111,14 @@ def warn_cxx98_compat_raw_string_literal : Warning<
"raw string literals are incompatible with C++98">,
InGroup, DefaultIgnore;
+def warn_cxx26_compat_raw_string_literal_character_set : Warning<
+ "'%0'in a raw string literal delimiter is incompatible
@@ -111,6 +111,14 @@ def warn_cxx98_compat_raw_string_literal : Warning<
"raw string literals are incompatible with C++98">,
InGroup, DefaultIgnore;
+def warn_cxx26_compat_raw_string_literal_character_set : Warning<
+ "'%0'in a raw string literal delimiter is incompatible
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 1/9] [Sema] Preserve ContainsUnexpandedParameterPack in
TransformL
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/93206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/93206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/93206
>From 658e9d46adf6dd79aa6aef03a1817444a880348a Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 23 May 2024 22:35:11 +0800
Subject: [PATCH] [Clang][Sema] Tweak tryCaptureVariable for unevaluated
lambdas
T
@@ -1576,7 +1576,10 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer(
TrailingReturnTypeLoc, &DS),
std::move(Attributes), DeclEndLoc);
-Actions.ActOnLambdaClosureQualifiers(Intro, MutableLoc);
+// We have called ActOnLa
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/93404
The issue with the previous implementation bc31be7 was that getApproximateType
could potentially return a null QualType for a dereferencing operator, which is
not what its caller wants.
>From 7639cb738dfb876c7a
@@ -7216,9 +7216,30 @@
TreeTransform::TransformElaboratedType(TypeLocBuilder &TLB,
return QualType();
}
- QualType NamedT = getDerived().TransformType(TLB, TL.getNamedTypeLoc());
- if (NamedT.isNull())
-return QualType();
+ QualType NamedT;
+ if (SemaRef.getLa
@@ -28,16 +28,17 @@ namespace PR12884_original {
typedef int arg;
};
struct C {
- typedef B::X x; // precxx17-warning{{missing 'typename'
prior to dependent type name B::X; implicit 'typename' is a C++20 extension}}
zyn0217 wrote:
A drive-b
@@ -7216,9 +7216,30 @@
TreeTransform::TransformElaboratedType(TypeLocBuilder &TLB,
return QualType();
}
- QualType NamedT = getDerived().TransformType(TLB, TL.getNamedTypeLoc());
- if (NamedT.isNull())
-return QualType();
+ QualType NamedT;
+ if (SemaRef.getLa
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/93404
>From 7639cb738dfb876c7abdf7337fad3aa80e912736 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sun, 26 May 2024 15:52:31 +0800
Subject: [PATCH 1/2] [clang][CodeComplete] Recurse into the subexpression of
deref
@@ -5680,8 +5680,16 @@ QualType getApproximateType(const Expr *E) {
}
}
if (const auto *UO = llvm::dyn_cast(E)) {
-if (UO->getOpcode() == UnaryOperatorKind::UO_Deref)
- return UO->getSubExpr()->getType()->getPointeeType();
+if (UO->getOpcode() == UnaryOpera
zyn0217 wrote:
(I'll merge it shortly if CI turns green because I encountered the bug the
other day in our codebase. Apologies I didn't point it out in my review for
https://github.com/llvm/llvm-project/commit/bc31be7949a3d5382be0e15e3957fa957da9de45)
https://github.com/llvm/llvm-project/pull/
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/93404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/93460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
Thanks! LG modulo one nit.
https://github.com/llvm/llvm-project/pull/93460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -797,6 +797,8 @@ Bug Fixes to C++ Support
in dependent contexts. Fixes (#GH92680).
- Fixed a crash when diagnosing failed conversions involving template parameter
packs. (#GH93076)
+- Fixed a regression introduced in Clang 18 causing a static function
overloading a non-
zyn0217 wrote:
I remembered @LYP951018 shared me with a case involving PackIndexingExprs that
was incorrectly rejected due to the mishandling of PackExpansionExprs:
```cpp
namespace init_capture_pack {
void init_capture() {
auto L = [](auto... x) {
return [x...](auto... y) {
retur
zyn0217 wrote:
Sorry I was wrong. I mixed up my patch along with this fix so I reapplied it to
a clean branch locally, and this could also *fix* the above case. With this
patch, we don't need to bother to handling PackExpansionExpr in the transform
pass of PackIndexingExpr, which is great!
ht
https://github.com/zyn0217 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/101385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4006,6 +4007,37 @@ class TreeTransform {
NumExpansions);
}
+ void RebuildLambdaExprImpl(SourceLocation StartLoc, SourceLocation EndLoc,
+ LambdaScopeInfo *LSI) {}
+
+ ExprResult RebuildLambdaExpr(SourceL
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 01/23] [Sema] Preserve ContainsUnexpandedParameterPack in
Transfor
@@ -1105,6 +1107,8 @@ void
Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro,
CXXMethodDecl *Method = CreateLambdaCallOperator(Intro.Range, Class);
LSI->CallOperator = Method;
+ // Temporarily set the lexical declaration context to the current
+ // cont
https://github.com/zyn0217 commented:
Thanks so much for continuing the effort to implement this! I haven't dived
into the details yet, so here are some nits from me.
(I'd also prefer the pronouns he/him if you'd like. ;)
https://github.com/llvm/llvm-project/pull/101448
___
@@ -487,7 +487,26 @@ void DeclPrinter::VisitDeclContext(DeclContext *DC, bool
Indent) {
}
this->Indent();
-Visit(*D);
+
+// Group friend declarations if need be.
+if (isa(*D)) {
+ auto *FD = cast(*D);
+ VisitFriendDecl(FD);
+ SourceLocation
@@ -4437,6 +4441,31 @@ ExpectedDecl ASTNodeImporter::VisitFriendDecl(FriendDecl
*D) {
return FrD;
}
+ExpectedDecl ASTNodeImporter::VisitFriendPackDecl(FriendPackDecl *D) {
+ // Import the major distinguishing characteristics of a declaration.
+ DeclContext *DC, *LexicalDC
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/101448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -754,6 +754,10 @@ static void InitializeCPlusPlusFeatureTestMacros(const
LangOptions &LangOpts,
Builder.defineMacro("__cpp_multidimensional_subscript", "202211L");
Builder.defineMacro("__cpp_auto_cast", "202110L");
}
+ // C++26 features.
+ if (LangOpts.CPlusPlus
@@ -1442,8 +1442,49 @@ Decl
*TemplateDeclInstantiator::VisitFriendDecl(FriendDecl *D) {
if (D->isUnsupportedFriend()) {
InstTy = Ty;
} else {
- InstTy = SemaRef.SubstType(Ty, TemplateArgs,
- D->getLocation(), DeclarationName()
https://github.com/zyn0217 approved this pull request.
Makes sense to me. Thanks
https://github.com/llvm/llvm-project/pull/101395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/101020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
@MitalAshok Can you rebase the patch so that I can help you merge it? thanks!
https://github.com/llvm/llvm-project/pull/101385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
zyn0217 wrote:
Gently Ping
https://github.com/llvm/llvm-project/pull/101020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 commented:
LGTM
(It's not neglected because I want to take a look when I get some time but you
have beaten me to it. :)
https://github.com/llvm/llvm-project/pull/101782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/101385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
> I might be stupid but i still do not get why fold expressions are special,
> they should not be.
Sorry I was inaccurate suggesting fold expressions are special, it's actually
*constraints involving pack expansions* who are special. (I admit inventing
another `collectUnexpande
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 01/24] [Sema] Preserve ContainsUnexpandedParameterPack in
Transfor
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 01/25] [Sema] Preserve ContainsUnexpandedParameterPack in
Transfor
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/86265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 01/26] [Sema] Preserve ContainsUnexpandedParameterPack in
Transfor
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 01/27] [Sema] Preserve ContainsUnexpandedParameterPack in
Transfor
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/86265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
Thanks for the review! I've just merged it.
> We should probably backport that
SGTM but given that this bug persists in so many versions, I think it is also
fine to leave the fix just on trunk - especially since this is actually a
partial fix.
We could issue a backport to 19 a
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/102131
Fixes https://github.com/llvm/llvm-project/issues/101735
(I'll add a release note and some comments later)
>From 0727e47124af564826a22a718a64a1da79e6131d Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Tue,
@@ -13830,61 +13820,27 @@
TreeTransform::TransformLambdaExpr(LambdaExpr *E) {
getSema().AddTemplateParametersToLambdaCallOperator(NewCallOperator, Class,
TPL);
- // Transform the type of the original lambda's call o
@@ -361,3 +361,11 @@ LLVM_DUMP_METHOD void ConceptReference::dump(raw_ostream
&OS) const {
ASTDumper P(OS, Ctx, Ctx.getDiagnostics().getShowColors());
P.Visit(this);
}
+
+//===--===//
+// Attr method imple
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/85325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 commented:
Thanks for the patch. IIUC this patch does 2~3 things:
- Add a `dump()` method to `Attr`
- Refactor the pertaining transformation logic of `TransformLambdaExpr()`
- Refactor some other logic in `ASTContext::AdjustType()`
They're really great works, but I su
@@ -13830,61 +13820,27 @@
TreeTransform::TransformLambdaExpr(LambdaExpr *E) {
getSema().AddTemplateParametersToLambdaCallOperator(NewCallOperator, Class,
TPL);
- // Transform the type of the original lambda's call o
@@ -13830,61 +13820,27 @@
TreeTransform::TransformLambdaExpr(LambdaExpr *E) {
getSema().AddTemplateParametersToLambdaCallOperator(NewCallOperator, Class,
TPL);
- // Transform the type of the original lambda's call o
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102857
>From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 12 Aug 2024 23:32:34 +0800
Subject: [PATCH 1/5] [Clang][NFCI] Slightly refactor
getTemplateInstantiationArgs
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102857
>From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 12 Aug 2024 23:32:34 +0800
Subject: [PATCH 1/6] [Clang][NFCI] Slightly refactor
getTemplateInstantiationArgs
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102857
>From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 12 Aug 2024 23:32:34 +0800
Subject: [PATCH 1/7] [Clang][NFCI] Slightly refactor
getTemplateInstantiationArgs
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/102857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102857
>From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 12 Aug 2024 23:32:34 +0800
Subject: [PATCH 1/8] [Clang][NFCI] Slightly refactor
getTemplateInstantiationArgs
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/102857
>From 1119f0a8d180e482bff45c999d488827ac5ae49e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Mon, 12 Aug 2024 23:32:34 +0800
Subject: [PATCH 1/9] [Clang][NFCI] Slightly refactor
getTemplateInstantiationArgs
801 - 900 of 1617 matches
Mail list logo