Re: r339581 - [SEMA] add more -Wfloat-conversion to compound assigment analysis

2018-08-13 Thread Vitaly Buka via cfe-commits
Looks like this patch: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/13867/steps/ninja%20check%201/logs/stdio FAIL: Clang :: Sema/conversion.c (12530 of 44133) TEST 'Clang :: Sema/conversion.c' FAILED Script: -- : 'RUN: at line 1'; /ho

Re: [libcxx] r339943 - Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815

2018-08-16 Thread Vitaly Buka via cfe-commits
This brakes some bots http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22441 /b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/algorithm:648:10: fatal error: 'bit' file not found #include ^ 1 error generated. On Thu, Aug 16, 2018 at 2:36 PM M

Re: [libcxx] r339943 - Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815

2018-08-16 Thread Vitaly Buka via cfe-commits
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/27733 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14670 On Thu, Aug 16, 2018 at 3:30 PM Vitaly Buka wrote: > This brakes some bots > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/2

[libcxx] r339971 - Revert "Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815"

2018-08-16 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Aug 16 16:57:16 2018 New Revision: 339971 URL: http://llvm.org/viewvc/llvm-project?rev=339971&view=rev Log: Revert "Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815"; Breaks build on sanitizer bots. This reverts commit r339943. Removed:

r325182 - [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

2018-02-14 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Feb 14 14:41:15 2018 New Revision: 325182 URL: http://llvm.org/viewvc/llvm-project?rev=325182&view=rev Log: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK Summary: TypeID summaries are used by CFI and need to be serialized by ThinLTO indexing for

r325184 - Moved CHECK in test closer to source code

2018-02-14 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Feb 14 14:52:49 2018 New Revision: 325184 URL: http://llvm.org/viewvc/llvm-project?rev=325184&view=rev Log: Moved CHECK in test closer to source code Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Modified: cfe/trunk/test/CodeGen/thinlto-distr

r325410 - [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Feb 16 15:34:16 2018 New Revision: 325410 URL: http://llvm.org/viewvc/llvm-project?rev=325410&view=rev Log: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set Summary: ThinLTO compilation may decide not to split module and keep at as regu

r325411 - [ThinLTO] Allow indexing to request backend to ignore the module

2018-02-16 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Feb 16 15:38:22 2018 New Revision: 325411 URL: http://llvm.org/viewvc/llvm-project?rev=325411&view=rev Log: [ThinLTO] Allow indexing to request backend to ignore the module Summary: Gold plugin does not add pass to ThinLTO modules without useful symbols. In this case

Re: r304017 - CodeGen: Define Swift's legal vector types for AArch64, ARM

2017-05-26 Thread Vitaly Buka via cfe-commits
Could this be the patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5228/steps/check-llvm%20msan/logs/stdio FAIL: LLVM :: CodeGen/ARM/arm-shrink-wrapping.ll (5392 of 20818) TEST 'LLVM :: CodeGen/ARM/arm-shrink-wrapping.ll' FAILED S

r334216 - Introducing single for loop into clang_proto_fuzzer

2018-06-07 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jun 7 12:17:46 2018 New Revision: 334216 URL: http://llvm.org/viewvc/llvm-project?rev=334216&view=rev Log: Introducing single for loop into clang_proto_fuzzer Summary: Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire C++ code in a single

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

2018-06-17 Thread Vitaly Buka via cfe-commits
Hi Richard, After this patch check-all fails for me with: llvm-project/libcxx/utils/libcxx/test/config.py", line 467, in configure_features int(macros['__cpp_deduction_guides']) < 201611: ValueError: invalid literal for int() with base 10: '201703L' On Wed, Jun 13, 2018 at 5:44 PM Richard Sm

[libcxxabi] r334924 - Fix libcxx tests after clang r334677.

2018-06-17 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Sun Jun 17 23:24:29 2018 New Revision: 334924 URL: http://llvm.org/viewvc/llvm-project?rev=334924&view=rev Log: Fix libcxx tests after clang r334677. Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

2018-06-17 Thread Vitaly Buka via cfe-commits
asive the issue is. I'll take a look >> in the morning. If this is blocking anything in the mean time, feel free to >> revert this (or fix libc++ yourself). >> >> >> On Sun, 17 Jun 2018, 01:40 Vitaly Buka via cfe-commits, < >> cfe-commits@lists.llvm.org>

[libcxxabi] r334926 - Fix libcxxabi tests after clang r334924

2018-06-17 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Sun Jun 17 23:43:55 2018 New Revision: 334926 URL: http://llvm.org/viewvc/llvm-project?rev=334926&view=rev Log: Fix libcxxabi tests after clang r334924 Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL

r348327 - [asan] Add clang flag -fsanitize-address-use-odr-indicator

2018-12-04 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Dec 4 17:44:31 2018 New Revision: 348327 URL: http://llvm.org/viewvc/llvm-project?rev=348327&view=rev Log: [asan] Add clang flag -fsanitize-address-use-odr-indicator Reviewers: eugenis, m.ostapenko, ygribov Subscribers: hiraditya, llvm-commits Differential Revision

r355442 - [docs] Update the list of ThreadSanitizer supported OSes

2019-03-05 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Mar 5 12:53:34 2019 New Revision: 355442 URL: http://llvm.org/viewvc/llvm-project?rev=355442&view=rev Log: [docs] Update the list of ThreadSanitizer supported OSes Modified: cfe/trunk/docs/ThreadSanitizer.rst Modified: cfe/trunk/docs/ThreadSanitizer.rst URL: ht

r355445 - [docs] Add some architectures into the list of supported ThreadSanitizer platforms

2019-03-05 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Mar 5 13:10:42 2019 New Revision: 355445 URL: http://llvm.org/viewvc/llvm-project?rev=355445&view=rev Log: [docs] Add some architectures into the list of supported ThreadSanitizer platforms Some platforms for which TSAN has build rules are omitted for the lack of kn

Re: r357323 - [analyzer] Introduce a simplified API for adding custom path notes.

2019-03-29 Thread Vitaly Buka via cfe-commits
Bot detects memory leak probably after this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/30957/steps/check-clang%20asan/logs/stdio = ==22233==ERROR: LeakSanitizer: detected memory leaks Direct leak of

r359366 - [AArch64] Initialize HasMTE

2019-04-26 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Apr 26 19:40:01 2019 New Revision: 359366 URL: http://llvm.org/viewvc/llvm-project?rev=359366&view=rev Log: [AArch64] Initialize HasMTE Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp URL: http://llvm.org/viewv

Re: r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

2018-09-25 Thread Vitaly Buka via cfe-commits
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/24083 FAIL: Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp (1692 of 13357) TEST 'Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/sanitiz

r343150 - Init LookupResult::AmbiguityKind

2018-09-26 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Sep 26 15:58:53 2018 New Revision: 343150 URL: http://llvm.org/viewvc/llvm-project?rev=343150&view=rev Log: Init LookupResult::AmbiguityKind We don't expect useful value there unless it's "ambiguous". However we use read it for copying and moving, so we need either in

r343183 - Revert "[DebugInfo] Generate debug information for labels."

2018-09-27 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Sep 27 01:15:24 2018 New Revision: 343183 URL: http://llvm.org/viewvc/llvm-project?rev=343183&view=rev Log: Revert "[DebugInfo] Generate debug information for labels." This reverts commit r343148. It crashes on sanitizer-x86_64-linux-autoconf. Removed: cfe/trunk

r343369 - [cxx2a] Fix warning triggered by r343285

2018-09-28 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL: http://llv

[clang-tools-extra] r343369 - [cxx2a] Fix warning triggered by r343285

2018-09-28 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: clang-tools-extra/trunk/clang-doc/BitcodeWriter.h Modified: clang-tools-extra/trunk/clang-doc/BitcodeWri

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

2018-09-28 Thread Vitaly Buka via cfe-commits
https://reviews.llvm.org/rL343369 On Fri, Sep 28, 2018 at 4:51 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke couple of our builders: > > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 > http://lab.llvm.or

r312407 - Don't search libxml2 if using msan. LLVM already has similar check.

2017-09-01 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Sep 1 20:53:42 2017 New Revision: 312407 URL: http://llvm.org/viewvc/llvm-project?rev=312407&view=rev Log: Don't search libxml2 if using msan. LLVM already has similar check. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL: http://llvm

r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

2017-09-18 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Sep 18 01:26:01 2017 New Revision: 313521 URL: http://llvm.org/viewvc/llvm-project?rev=313521&view=rev Log: Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture] Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/P

Re: r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-20 Thread Vitaly Buka via cfe-commits
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8038/steps/check-clang%20ubsan/logs/stdio -- /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/lib/AST/Decl.cpp:1333:42: runtime error: load of value 15, which is not a valid value for type 'clang::LV

r313856 - Revert "Give external linkage and mangling to lambdas inside inline variables and variable templates."

2017-09-20 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Sep 20 19:51:56 2017 New Revision: 313856 URL: http://llvm.org/viewvc/llvm-project?rev=313856&view=rev Log: Revert "Give external linkage and mangling to lambdas inside inline variables and variable templates." To fix: runtime error: load of value 15, which is not a

Re: r313827 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

2017-09-20 Thread Vitaly Buka via cfe-commits
reverted by r313856 On Wed, Sep 20, 2017 at 6:30 PM, Richard Smith wrote: > Thanks, I'll fix this tomorrow; if that's not soon enough, please go ahead > and revert (or fix by adding a dummy enumerator in lib/AST/Linkage.h). > > On 20 Sep 2017 17:39, "Vitaly Buka via c

Re: r314037 - DR1113: anonymous namespaces formally give their contents internal linkage.

2017-09-22 Thread Vitaly Buka via cfe-commits
This breaks check-clang-tools http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12310/steps/test/logs/stdio On Fri, Sep 22, 2017 at 3:21 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Sep 22 15:21:44 2017

Re: [PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

2019-06-20 Thread Vitaly Buka via cfe-commits
Not much, but it's not abandoned. I was interrupted by other stuff. Also I am concerned by the fact that zero initialization without any new optimization is cheaper than pattern even with patches in progress. On Thu, Jun 20, 2019 at 9:05 AM JF Bastien via Phabricator < revi...@reviews.llvm.org> wr

r365822 - CodeGen, NFC: Test for auto-init for 32bit pointers

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 13:51:59 2019 New Revision: 365822 URL: http://llvm.org/viewvc/llvm-project?rev=365822&view=rev Log: CodeGen, NFC: Test for auto-init for 32bit pointers Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init

r365835 - CodeGen: Suppress c++ warnings in test

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 14:59:09 2019 New Revision: 365835 URL: http://llvm.org/viewvc/llvm-project?rev=365835&view=rev Log: CodeGen: Suppress c++ warnings in test Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL: ht

r365857 - Codegen, NFC: 32bit test in auto-var-init.cpp

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 18:36:11 2019 New Revision: 365857 URL: http://llvm.org/viewvc/llvm-project?rev=365857&view=rev Log: Codegen, NFC: 32bit test in auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp U

r365858 - Handle IntToPtr in isBytewiseValue

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 18:42:03 2019 New Revision: 365858 URL: http://llvm.org/viewvc/llvm-project?rev=365858&view=rev Log: Handle IntToPtr in isBytewiseValue Summary: This helps with more efficient use of memset for pattern initialization From @pcc prototype for -ftrivial-auto-var-

r365921 - CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-12 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Jul 12 10:21:55 2019 New Revision: 365921 URL: http://llvm.org/viewvc/llvm-project?rev=365921&view=rev Log: CodeGet: Init 32bit pointers with 0x Summary: Patch makes D63967 effective for 32bit platforms and improves pattern initialization there. It cuts size o

r364492 - [NFC] Remove unneeded local variables

2019-06-26 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jun 26 18:34:21 2019 New Revision: 364492 URL: http://llvm.org/viewvc/llvm-project?rev=364492&view=rev Log: [NFC] Remove unneeded local variables Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp URL: http://llvm.org/viewvc/ll

r364495 - [NFC] Return early for types with size zero

2019-06-26 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jun 26 19:08:15 2019 New Revision: 364495 URL: http://llvm.org/viewvc/llvm-project?rev=364495&view=rev Log: [NFC] Return early for types with size zero Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp URL: http://llvm.org/vie

r365706 - GodeGen, NFC: Add test to track emitStoresForConstant behavior

2019-07-10 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jul 10 15:47:07 2019 New Revision: 365706 URL: http://llvm.org/viewvc/llvm-project?rev=365706&view=rev Log: GodeGen, NFC: Add test to track emitStoresForConstant behavior Reviewers: eugenis, pcc Reviewed By: eugenis Subscribers: cfe-commits Tags: #clang Differenti

r365708 - NFC: Convert large lambda into method

2019-07-10 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jul 10 15:53:50 2019 New Revision: 365708 URL: http://llvm.org/viewvc/llvm-project?rev=365708&view=rev Log: NFC: Convert large lambda into method Reviewers: pcc, eugenis Reviewed By: eugenis Subscribers: cfe-commits, lldb-commits Tags: #clang, #lldb Differential R

r365709 - NFC: Pass DataLayout into isBytewiseValue

2019-07-10 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jul 10 15:53:52 2019 New Revision: 365709 URL: http://llvm.org/viewvc/llvm-project?rev=365709&view=rev Log: NFC: Pass DataLayout into isBytewiseValue Summary: We will need to handle IntToPtr which I will submit in a separate patch as it's not going to be NFC. Reviewe

r349015 - [asan] Don't check ODR violations for particular types of globals

2018-12-13 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Dec 13 01:47:39 2018 New Revision: 349015 URL: http://llvm.org/viewvc/llvm-project?rev=349015&view=rev Log: [asan] Don't check ODR violations for particular types of globals Summary: private and internal: should not trigger ODR at all. unnamed_addr: current ODR checki

r373992 - [clang] Accept -ftrivial-auto-var-init in clang-cl

2019-10-07 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 7 16:57:11 2019 New Revision: 373992 URL: http://llvm.org/viewvc/llvm-project?rev=373992&view=rev Log: [clang] Accept -ftrivial-auto-var-init in clang-cl Reviewers: eugenis, rnk Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.

r374110 - [clang] Add llvm-ifs in test deps

2019-10-08 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 8 13:23:24 2019 New Revision: 374110 URL: http://llvm.org/viewvc/llvm-project?rev=374110&view=rev Log: [clang] Add llvm-ifs in test deps Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project

r374113 - [clang] enable_trivial_var_init_zero should not be Joined<>

2019-10-08 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 8 13:34:53 2019 New Revision: 374113 URL: http://llvm.org/viewvc/llvm-project?rev=374113&view=rev Log: [clang] enable_trivial_var_init_zero should not be Joined<> Reviewers: rnk Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.

r374481 - [tsan,msan] Insert module constructors in a module pass

2019-10-10 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Oct 10 16:49:10 2019 New Revision: 374481 URL: http://llvm.org/viewvc/llvm-project?rev=374481&view=rev Log: [tsan,msan] Insert module constructors in a module pass Summary: If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. R

r374527 - Insert module constructors in a module pass

2019-10-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Oct 11 01:47:03 2019 New Revision: 374527 URL: http://llvm.org/viewvc/llvm-project?rev=374527&view=rev Log: Insert module constructors in a module pass Summary: If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. Reviewers: eu

Re: Zorg migration to GitHub/monorepo

2019-10-18 Thread Vitaly Buka via cfe-commits
On Mon, Oct 14, 2019 at 6:16 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello everyone, > > > > We are in the middle of porting the majority of zorg to > GitHub/monorepo. The following build factories will be ported and if you > use one of those for your bots, you a

[clang] 088fb97 - [NFC, StackSafety] LTO tests for MTE and StackSafety

2020-05-25 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-05-23T17:39:54-07:00 New Revision: 088fb9734843c09493d5965baed775c4ec32d5fb URL: https://github.com/llvm/llvm-project/commit/088fb9734843c09493d5965baed775c4ec32d5fb DIFF: https://github.com/llvm/llvm-project/commit/088fb9734843c09493d5965baed775c4ec32d5fb.diff L

[clang] 14de6e2 - [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

2020-05-26 Thread Vitaly Buka via cfe-commits
Author: Marco Elver Date: 2020-05-26T13:36:21-07:00 New Revision: 14de6e29b1315e9abe61d71e3e13f75bff80e1be URL: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be DIFF: https://github.com/llvm/llvm-project/commit/14de6e29b1315e9abe61d71e3e13f75bff80e1be.diff L

[clang] 2f430f7 - [StackSafety] Remove SetMetadata parameter

2020-05-28 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-05-28T13:32:57-07:00 New Revision: 2f430f7a51693c9d5c648179f2341b541be44000 URL: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000 DIFF: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000.diff L

[clang] 232d348 - [MTE] Convert StackSafety into analysis

2020-06-02 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-06-02T16:08:14-07:00 New Revision: 232d348c6eff8493fc016b1ea8a99db0e5620d81 URL: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81 DIFF: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81.diff L

[clang] 85fdec9 - [NFC,MTE] Drop unneeded attribute from test

2020-06-02 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-06-02T18:28:45-07:00 New Revision: 85fdec988fc55d56988d57fa88e2b870f6e0e8e9 URL: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9 DIFF: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9.diff L

[clang] ced398f - [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

2020-04-09 Thread Vitaly Buka via cfe-commits
Author: Pratyai Mazumder Date: 2020-04-09T02:40:55-07:00 New Revision: ced398fdc813930bfe88df5252c0f5405af541fc URL: https://github.com/llvm/llvm-project/commit/ced398fdc813930bfe88df5252c0f5405af541fc DIFF: https://github.com/llvm/llvm-project/commit/ced398fdc813930bfe88df5252c0f5405af541fc.di

[clang] 6dd738e - [StackSafety,NFC] Switch tests to aarch64

2020-06-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-06-05T00:24:02-07:00 New Revision: 6dd738e2f0609f7d3313b574a1d471263d2d3ba1 URL: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1 DIFF: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1.diff L

[clang] c1e47b4 - [StackSafety] Run ThinLTO

2020-06-12 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-06-12T18:11:29-07:00 New Revision: c1e47b47f8848bb4c1ead8c530940d783c1fbf46 URL: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46 DIFF: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46.diff L

[clang] 04bd2c3 - [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-05-05T23:08:08-07:00 New Revision: 04bd2c37caf48e79589dbccc486c6ad2541bec7a URL: https://github.com/llvm/llvm-project/commit/04bd2c37caf48e79589dbccc486c6ad2541bec7a DIFF: https://github.com/llvm/llvm-project/commit/04bd2c37caf48e79589dbccc486c6ad2541bec7a.diff L

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-19 Thread Vitaly Buka via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added a comment. The patch was split in two and I moved the test into the wrong one. I'll fix this. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-09-19 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 71856. vitalybuka added a comment. Removed unrelated test https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/lifetime2.c Index: test/CodeGen/lifetime2.c ==

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-19 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 71858. vitalybuka added a comment. recovered test https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/Cod

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-09-19 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 71860. vitalybuka added a comment. Fixed accidentally changed test https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h ===

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-19 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 71862. vitalybuka added a comment. Test https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/CodeGen/VarBy

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-21 Thread Vitaly Buka via cfe-commits
Intrinsics are invalid there, code is generated in such way that variable is being accessed after lifetime.end. I suspect that optimizer can make invalid code because of this, but I can't reproduce. So I think it's safer to remove them at all and don't wait for miscompile reports. Still if perform

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-21 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Intrinsics are invalid there, code is generated in such way that variable is being accessed after lifetime.end. I suspect that optimizer can make invalid code because of this, but I can't reproduce. So I think it's safer to remove them at all and don't wait for miscom

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-21 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Miscompile. Here assert fails without the patch. int* p1; int* p2; int use2() { assert(p1 != p2 || !"reuse"); return p1 == p2; } void f3(int cond) { { int tmp[1024]; p1 = tmp; goto l2; l1: int tmp2[1024]; p2 = tmp2; exit(use2());

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-23 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. In https://reviews.llvm.org/D24693#550119, @ahatanak wrote: > Thank you for the great example! I can now see this patch does fix > mis-compiles. > > There are probably other lifetime bugs you'll see when the code being > compiled includes gotos that jump past variabl

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-26 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. My assumption is that "start" makes access valid, and "end" makes access invalid, up to the next "start". I see no problems problems with loops and multiple regions, as soon as access is happening between start and end. Loops always call "start" for nested alloca on

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-09-28 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 72907. vitalybuka added a comment. Herald added subscribers: mgorny, beanz. rebase https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-09-28 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 72908. vitalybuka added a comment. rebase https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-28 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 72909. vitalybuka added a comment. rebase https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/CodeGen/Var

Re: r283092 - [analyzer] Extend bug reports with extra notes

2016-10-03 Thread Vitaly Buka via cfe-commits
This patch breaks Windows: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/29769/ On Mon, Oct 3, 2016 at 1:07 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dergachev > Date: Mon Oct 3 02:58:26 2016 > New Revision: 283092 > > URL: http://llvm.org/vie

Re: r283092 - [analyzer] Extend bug reports with extra notes

2016-10-03 Thread Vitaly Buka via cfe-commits
is failure? Cause i haven't > received an email for this failure. Hope there aren't more failures. > > > > 03/10/2016 21:46, Vitaly Buka via cfe-commits пишет: > > This patch breaks Windows: > http://lab.llvm.org:8011/builders/sanitizer-windows/builds/29769/ > &g

Re: r283092 - [analyzer] Extend bug reports with extra notes

2016-10-03 Thread Vitaly Buka via cfe-commits
from looking at the code. > > Also, should i have received an email for this failure? Cause i haven't > received an email for this failure. Hope there aren't more failures. > > > > 03/10/2016 21:46, Vitaly Buka via cfe-commits пишет: > > This patch breaks Wind

r283179 - Revert "[analyzer] A blind attempt to fix a buildbot" as it does not help.

2016-10-03 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 3 21:19:12 2016 New Revision: 283179 URL: http://llvm.org/viewvc/llvm-project?rev=283179&view=rev Log: Revert "[analyzer] A blind attempt to fix a buildbot" as it does not help. This reverts commit r283141. Modified: cfe/trunk/include/clang/StaticAnalyzer/Co

r283180 - Revert "[analyzer] Extend bug reports with extra notes" to fix Windows bot.

2016-10-03 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 3 21:19:17 2016 New Revision: 283180 URL: http://llvm.org/viewvc/llvm-project?rev=283180&view=rev Log: Revert "[analyzer] Extend bug reports with extra notes" to fix Windows bot. This reverts commit r283092. Modified: cfe/trunk/include/clang/StaticAnalyzer/C

r283181 - Revert "[analyzer] Add extra notes to ObjCDeallocChecker" as its depends on reverted r283092

2016-10-03 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 3 21:36:58 2016 New Revision: 283181 URL: http://llvm.org/viewvc/llvm-project?rev=283181&view=rev Log: Revert "[analyzer] Add extra notes to ObjCDeallocChecker" as its depends on reverted r283092 This reverts commit r283093. Modified: cfe/trunk/lib/StaticAn

r283182 - Revert "[analyzer] Improve CloneChecker diagnostics" as its depends on reverted r283092

2016-10-03 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 3 21:40:35 2016 New Revision: 283182 URL: http://llvm.org/viewvc/llvm-project?rev=283182&view=rev Log: Revert "[analyzer] Improve CloneChecker diagnostics" as its depends on reverted r283092 This reverts commit r283094. Removed: cfe/trunk/test/Analysis/copy

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

2016-10-03 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. reverted with r283182 https://reviews.llvm.org/D24916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

2016-10-03 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Reverted with r283181 as it depends r283092 https://reviews.llvm.org/D24915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

2016-10-03 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. reverted with r283182 as it depends on r283092 https://reviews.llvm.org/D24916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

2016-10-04 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Out of curiosity, how was MSVC crash solved? Repository: rL LLVM https://reviews.llvm.org/D24916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

2016-10-10 Thread Vitaly Buka via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: test/Driver/fsanitize.c:124 +// RUN: %clang -target x86_64-linux-gnu -fsanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-WITHOUT-USE-AFTER-SCOPE +// CHECK-ASAN-WITHOUT

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

2016-10-10 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 74176. vitalybuka added a comment. resolved comments https://reviews.llvm.org/D25453 Files: include/clang/Driver/Options.td lib/Driver/SanitizerArgs.cpp lib/Frontend/CompilerInvocation.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c

r283801 - Add -fno-sanitize-address-use-after-scope flag

2016-10-10 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Oct 10 16:31:50 2016 New Revision: 283801 URL: http://llvm.org/viewvc/llvm-project?rev=283801&view=rev Log: Add -fno-sanitize-address-use-after-scope flag Reviewers: eugenis Differential Revision: https://reviews.llvm.org/D25453 Modified: cfe/trunk/include/clang

[PATCH] D25453: Add -fno-sanitize-address-use-after-scope flag

2016-10-11 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283801: Add -fno-sanitize-address-use-after-scope flag (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D25453?vs=74176&id=74210#toc Repository: rL LLVM https://reviews.ll

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

2016-10-14 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. This change breaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25625/steps/build%2032-bit%20symbolizer%20for%20compiler_rt_build/logs/stdio https://reviews.llvm.org/D24864 ___ cfe-commits mailing list

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

2016-10-14 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. So there is: - Looking for __cxa_thread_atexit_impl in c - Looking for __cxa_thread_atexit_impl in c - not found and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF https://reviews.llvm.org/D24864 ___ cfe-commits

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

2016-10-14 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Maybe? - if (UNIX AND NOT (APPLE OR CYGWIN)) + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN)) list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp) endif() https://reviews.llvm.org/D24864 ___ cfe-co

[libcxxabi] r284294 - Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF

2016-10-14 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Oct 14 18:51:41 2016 New Revision: 284294 URL: http://llvm.org/viewvc/llvm-project?rev=284294&view=rev Log: Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF Reviewers: rmaprath Subscribers: beanz, mgorny Differential Revision: https://reviews.llv

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

2016-10-14 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Thanks, done https://reviews.llvm.org/D25636 https://reviews.llvm.org/D24864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r284295 - Fix typo in comment

2016-10-14 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Oct 14 19:02:20 2016 New Revision: 284295 URL: http://llvm.org/viewvc/llvm-project?rev=284295&view=rev Log: Fix typo in comment Modified: libcxxabi/trunk/src/cxa_thread_atexit.cpp Modified: libcxxabi/trunk/src/cxa_thread_atexit.cpp URL: http://llvm.org/viewvc/ll

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-16 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 74813. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. Herald added a subscriber: modocache. - updated comments - indirect jumps - optimized Detect() https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/C

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-16 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 74814. vitalybuka added a comment. - fixed comment - added test for indirect jumps https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-16 Thread Vitaly Buka via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added a comment. Please take a look. Meanwhile, I will investigate performance footprint. In https://reviews.llvm.org/D24693#559781, @rsmith wrote: > Is there some reasonable base set of functionality between this and > JumpDiagnostics tha

[clang] b31b72a - [test][msan] Simplify tests with --implicit-check-not

2022-08-28 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-28T22:43:04-07:00 New Revision: b31b72ad7ed9b75c55771caf1176b989642964eb URL: https://github.com/llvm/llvm-project/commit/b31b72ad7ed9b75c55771caf1176b989642964eb DIFF: https://github.com/llvm/llvm-project/commit/b31b72ad7ed9b75c55771caf1176b989642964eb.diff L

[clang] 9c29bdf - [test][msan] Remov unneeded CHECK-NOT

2022-08-29 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-29T17:49:44-07:00 New Revision: 9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763 URL: https://github.com/llvm/llvm-project/commit/9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763 DIFF: https://github.com/llvm/llvm-project/commit/9c29bdf84ab1bdd89fe8c36974c3bf0543eb9763.diff L

[clang] ed4e95c - [test][msan] Add more Debug Info use-after-dtor tests

2022-08-29 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-29T17:49:44-07:00 New Revision: ed4e95c1f68abe8fffe8b54139d268924d554381 URL: https://github.com/llvm/llvm-project/commit/ed4e95c1f68abe8fffe8b54139d268924d554381 DIFF: https://github.com/llvm/llvm-project/commit/ed4e95c1f68abe8fffe8b54139d268924d554381.diff L

[clang] c7df82e - [test][msan] Don't ignore the suffix if use-after-dtor callback

2022-08-29 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-29T18:10:57-07:00 New Revision: c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59 URL: https://github.com/llvm/llvm-project/commit/c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59 DIFF: https://github.com/llvm/llvm-project/commit/c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59.diff L

[clang] 582ec4b - [test][msan] Don't ignore prefix of sanitizer_dtor_callback

2022-08-29 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-29T18:26:04-07:00 New Revision: 582ec4b0aa55bff84490e1c89e55066bf6603212 URL: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212 DIFF: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212.diff L

  1   2   3   4   5   6   7   8   9   10   >