@@ -43,8 +43,8 @@
// RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \
// RUN: -### %t.o 2>&1 \
-// RUN: | FileCheck --check-prefix=NOSDK %s
+// RUN: | FileCheck --check-prefix=INFERRED-SDK %s
cachemeifyoucan wrote:
I see. The value of
cachemeifyoucan wrote:
> Is there any reason why default builds don't just use the macOS spelling, at
> least for modern versions of macOS?
I don't think anyone has looked into changing the host guess script. I am ok to
switch to macOS spelling.
> I'm wondering if it's worth reviving the CLAN
@@ -2257,17 +2261,25 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
// Warn if the path does not exist.
if (!getVFS().exists(A->getValue()))
getDriver().Diag(clang::diag::warn_missing_sysroot) << A->getValue();
- } else {
-if (char *env =
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
> For reference, the failure from dropping `XFAIL` from
> `darwin-ld-platform-version-macos.c`:
>
> Failure Log
> ```
> + /Users/carlocab/github/llvm-project/build-xcselect/bin/FileCheck
> --check-prefix=NOSDK
> /Users/carlocab/github/llvm-project/clang/test/Driver/darw
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
Let's investigate to see all those test failed (many of them have versioned
deployment target).
Maybe it is because the `darwin` legacy OS in the triple? Maybe don't use
`xcselect` when it is darwin since the modern spelling should `macOS` family?
@@ -1,3 +1,6 @@
+// XFAIL: xcselect
cachemeifyoucan wrote:
I don't feel XFAIL is correct to use here in general. It is possible to have a
different host SDK and the test will actually pass, right?
https://github.com/llvm/llvm-project/pull/119670
___
https://github.com/cachemeifyoucan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/122390
Rename `ReadPCHAndPreprocessAction` class. This frontend action is used
for dependency scanning only and the current name is confusing for what
it actually does. Rename the class to `DependencyScanningFro
https://github.com/cachemeifyoucan updated
https://github.com/llvm/llvm-project/pull/122390
>From 1796a6e4fa0492b9676637245a394d3029474d4e Mon Sep 17 00:00:00 2001
From: Steven Wu
Date: Thu, 9 Jan 2025 15:46:06 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/124003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1346,14 +1344,30 @@ static void runThinLTOBackend(
}
}
-void clang::EmitBackendOutput(
-DiagnosticsEngine &Diags, const HeaderSearchOptions &HeaderOpts,
-const CodeGenOptions &CGOpts, const clang::TargetOptions &TOpts,
-const LangOptions &LOpts, StringRef TDe
@@ -1346,14 +1344,30 @@ static void runThinLTOBackend(
}
}
-void clang::EmitBackendOutput(
-DiagnosticsEngine &Diags, const HeaderSearchOptions &HeaderOpts,
-const CodeGenOptions &CGOpts, const clang::TargetOptions &TOpts,
-const LangOptions &LOpts, StringRef TDe
https://github.com/cachemeifyoucan approved this pull request.
This looks much better. Thanks!
https://github.com/llvm/llvm-project/pull/15
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/123098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,11 @@
+// RUN: %clang %s -### --target=arm64-apple-darwin -arch x86_64 -arch arm64
-fuse-lipo=llvm-lipo 2>&1 | FileCheck -check-prefix=TEST1 %s
cachemeifyoucan wrote:
Nit: Add a test case to check when the flag is not supplied.
https://github.com/llv
https://github.com/cachemeifyoucan commented:
LGTM in general with a comment in test.
For discussion. Is it better if the option supplies the full path to lipo or
just the name? Full path seems to be easy to use, but might deserve a warning
if the tool doesn't exist.
If just the name, it might
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/122976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -136,12 +137,18 @@ relative ordering of values is important. For example:
``Obj2`` will be initialized *before* ``Obj1`` despite the usual order of
initialization being the opposite.
+Note that this attribute does not control the initialization order of objects
+across fina
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
Merged. Thanks for your contribution!
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
I updated the title and PR message. Let me know if that looks ok for you.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@khyperia Sure, I can help you merge. Code change looks good as I don't see any
open review feedback and no objection from adding the option.
Can you please update the PR message to be a better formatted commit message?
The squash commit will use that as commit message,
cachemeifyoucan wrote:
@adrian-prantl for the debug directory option since that might interact how
debugger working with the option.
I think we need a solution approved by debugger forks for how to avoid stamping
CWD into debug info and when it is safe to do so (for example, we guarantee all
cachemeifyoucan wrote:
> This is clearer as we are currently only going to distribute the ThinLTO part
> and have no plans to distribute the FullLTO part. Making the name more
> general could confuse users who might then expect in e.g., a mixed Thin+Full
> link that the Full bitcode part would
https://github.com/cachemeifyoucan commented:
Some high level comments:
* Should we just call it distributedLTO, or DLTO? Feel like we can drop the
thin part for less typing, and from the user's point of view, using thinLTO
infrastructure is just implementation details.
* Are you going to imple
@@ -18,7 +18,7 @@
// RUN: c-index-test -test-load-source local %s -include %t.clang.h -fmodules
-fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin |
FileCheck %s
// FIXME: Still fails on at least some linux boxen.
-// REQUIRES: system-darwin
+// REQUIRES
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/130138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
I think the fix makes sense for a linux toolchain running on Darwin. I am still
surprised that you have a "system-darwin" platform where you don't want the
default target triple to be darwin.
I am ok with the fix but it will be good to update the R
cachemeifyoucan wrote:
Do you have a bot or build to point to for test failures?
There is no way to disable Darwin target from clang driver. I think the test
might be related to the host platform is not Darwin so the driver didn't infer
the target correctly without a default target triple?
I
https://github.com/cachemeifyoucan approved this pull request.
LGTM. Thanks for looking into the question I have. I slightly prefer if it is
an option, making your platform either be darwin, or be entirely not darwin.
But since you only need test update, I am ok with it since it doesn't make th
@@ -709,7 +711,7 @@ static AvailabilityResult CheckAvailability(ASTContext
&Context,
<< EnvName << HintMessage;
cachemeifyoucan wrote:
Do you want to avoid the extra space here?
https://github.com/llvm/llvm-project/pull/138610
_
https://github.com/cachemeifyoucan approved this pull request.
Thanks. LGTM.
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 239 of 239 matches
Mail list logo
