https://github.com/cachemeifyoucan commented:

LGTM in general with a comment in test.

For discussion. Is it better if the option supplies the full path to lipo or 
just the name? Full path seems to be easy to use, but might deserve a warning 
if the tool doesn't exist.
If just the name, it might be better to rename the option to something like 
`-fuse-lipo-program=`. 

https://github.com/llvm/llvm-project/pull/121231
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to