[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. @pengfei Would you be happy to commandeer this patch to make it match D96231 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179

[PATCH] D96244: [clangd] Introduce Modules

RKSimon added a comment. In D96244#2558345 , @sammccall wrote: > I'm a little bit nervous about adding this with *no* usage, but it keeps the > patch size down :-) Indeed - this has broken at least one buildbot (http://lab.llvm.org:8011/#/builders/57) d

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RKSimon added a comment. @RedDocMD Please can you take a look at this buildbot failure: http://lab.llvm.org:8011/#/builders/124 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 _

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

RKSimon added a comment. In D94213#2579932 , @jyknight wrote: > Ping. Hi @jyknight - sorry for going quiet - 12.xx has brewed long enough that I think we can start looking at this again in trunk - I'll take a look in the next day or so. Repository:

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon created this revision. RKSimon added reviewers: nikic, bkramer, craig.topper, dblaikie, rsmith, zturner. Herald added subscribers: ormris, dexonsmith, martong, usaxena95, pengfei, kadircet, arphaman, kbarton, hiraditya, nemanjai. Herald added a reviewer: aaron.ballman. RKSimon requested r

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

RKSimon created this revision. RKSimon added reviewers: pgousseau, filcab, bkramer. Herald added a subscriber: dexonsmith. RKSimon requested review of this revision. Herald added a project: clang. We include the MathExtras.h header purely for the countPopulation() method - by moving this into San

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

RKSimon added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3129 static CheckRecoverableKind getRecoverableKind(SanitizerMask Kind) { - assert(Kind.countPopulation() == 1); + assert(Kind.isPowerOf2()); if (Kind == SanitizerKind::Function || Kind == SanitizerKind

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG206a66de5902: Sanitizers.h - remove MathExtras.h include dependency (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D103953?vs=350845&id=350882#toc Repository: rG LLVM Github

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon updated this revision to Diff 350893. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103888/new/ https://reviews.llvm.org/D103888 Files: clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-too

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

RKSimon added a comment. I don't know much about target feature inheritance - does this guarantee that the entire sse/avx/avx512 level chain is correctly disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61cdaf66fe22: [ADT] Remove APInt/APSInt toString() std::string variants (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon added a comment. In D103888#2811305 , @dblaikie wrote: > Sounds OK. > > I wouldn't mind the places that can use op<< to use that - not sure > preserving the explicit radix argument is super high value. (I think people > would generally assume th

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

RKSimon added reviewers: pengfei, craig.topper. RKSimon added a comment. This leaves the question - what hardware should we align each of the CK_x86_64_v* targets with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104116/new/ https://reviews.llvm

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

RKSimon added a comment. Thanks - that makes sense - LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon created this revision. RKSimon added a reviewer: rsmith. RKSimon requested review of this revision. Herald added a project: clang. As reported on https://pvs-studio.com/en/blog/posts/cpp/0771/ (Snippet 2) - (and mentioned on rGdc4259d5a38409

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9528 QualType T2 = NextParam(F2, I2, I == 0); -if (!T1.isNull() && !T1.isNull() && !Context.hasSameUnqualifiedType(T1, T2)) +if (!T1.isNull() && !T2.isNull() && !Context.hasSameUnqualifiedTyp

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

RKSimon added a comment. @gAlfonso-bit Do you have commit access? I don't think there's any reason to merge this - it fixes no bug or regression - it's just a cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 __

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added a comment. ping - any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/ https://reviews.llvm.org/D107347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc72dede68c: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from… (authored by gAlfonso-bit, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2373 + (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C), \ + (__mmask32)-1, (int)(R)) + Add outer brackets to all the defines to prevent precedence i

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2900 + (__v4sf)(__m128h)(C), (__v4sf)(__m128h)(A), (__v4sf)(__m128h)(B), \ + (__mmask8)-1, (int)(R)) + Outer brackets Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon added a comment. In D107477#2954764 , @gAlfonso-bit wrote: > gentle ping Sorry I forgot about this - I'll deal with this but you really need to request commit access CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://r

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0bf0b2e79e8: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const. (authored by gAlfonso-bit, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon added a comment. In D107477#2954787 , @gAlfonso-bit wrote: > How do I request it? https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

RKSimon added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4231 + // Only look at the first documentation if there are several. + // (As of now, only one attribute has multiple documentation entries). + break; sammccall wr

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; I realize its a lot of work, but is there any chance that we could get doxygen

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; pengfei wrote: > RKSimon wrote: > > I realize its a lot of work, but is there an

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll:7 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512f,+avx512bw | FileCheck %s --check-prefixes=ALL,AVX512 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512f,+

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ScheduleZnver3.td:64 - let CompleteModel = 1; + let CompleteModel = 0; } You could avoid this change if you add a scheduler class to whatever instruction is complaining? Repository: rG LL

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

RKSimon added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14563 -if (isa(Order)) { - int ord = cast(Order)->getZExtValue(); +switch (BuiltinID) { +case AMDGPU::BI__builtin_amdgcn_atomic_inc32: @saiislam @arsenm Coverity is warn

[PATCH] D112914: Misleading identifier detection

RKSimon added a comment. @serge-sans-paille Any luck with a fix for all the buildbot failures or should we revert ? https://lab.llvm.org/buildbot/#/builders/109/builds/25932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://review

[PATCH] D112914: Misleading identifier detection

RKSimon added a comment. In D112914#3119103 , @serge-sans-paille wrote: > Yep, I'm currently validating locally, I somehow messed up a rebase :-/ I'm sorry @serge-sans-paille I missed this reply before pushing the revert :( Repository: rG LLVM Githu

[PATCH] D112914: Misleading identifier detection

RKSimon added a comment. @serge-sans-paille Still failing on https://lab.llvm.org/buildbot/#/builders/139/builds/12974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914

[PATCH] D112914: Misleading identifier detection

RKSimon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp:3 + +#include + @serge-sans-paille Any chance you can remove the include and just forward declare printf()? Repository: rG LLVM Github Mono

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

RKSimon added a comment. @yubing I've reverted this as it was failing on a lot of buildbots: http://lab.llvm.org:8011/#/builders/109/builds/9867 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

RKSimon added a comment. @azabaznov This has broken some buildbots http://lab.llvm.org:8011/#/builders/105/builds/6855 - can you take a look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058 ___

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

RKSimon added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h" Is there a better comment? "unblock the XL bu

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson, Meinersbur, jansvoboda11, gbedwell. Herald added subscribers: dexonsmith, mstorsjo, mgorny. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MS

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390082. RKSimon added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/UsersMa

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MS

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390283. RKSimon added a comment. rebase and add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Use

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. > Have you checked whether there are any bots in the lab that will need to be > updated? I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and window

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. Thanks - I think all the MSVC bot admins are now on this patch, so I can avoid writing yet another email! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162000 , @mehdi_amini wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >> GCC/Clang/AppleClang

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390824. RKSimon edited the summary of this revision. RKSimon added a comment. Changed cmake example back to VS2019 Added note for minimum cmake version necessary for VS2022 Updated the soft version limit to: _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162157 , @mehdi_amini wrote: > In D114639#3162141 , @erichkeane > wrote: > >>> Right, but last time we did the motivation was specifically to get to >>> c++14, while here th

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

RKSimon added a comment. @stuij This is causing buildbot failures, please can you take a look? https://lab.llvm.org/buildbot/#/builders/139 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 ___

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

RKSimon added inline comments. Comment at: llvm/test/MC/X86/x86-64-cmpccxadd-att.s:1 +// RUN: llvm-mc -triple x86_64 --show-encoding %s | FileCheck %s + Drop the -att.s and add intel test coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. Can you fix the MC + disasm test file names - drop att/intel and ensure you test both syntaxes for 32 and 64 bits. Ideally the 32/64 bit names should be close to each other in a file list (e.g. avx-vnni-int8-32.s + avx-vnni-int8-64.s ?) Repository: rG LLVM Github Mo

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added a comment. Please can you update the summary now that raptorlake + meteorlake are in the same patch? Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2233 +// RUN: %clang -march=raptorlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added a comment. merge att/intel test coverage files and rename the 32/64 bit files so that they are close together in the file lists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135930/new/ https://reviews.llvm.org/D135930 _

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added a comment. Add a short description to clang ReleaseNotes about the new bf/bh types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 ___ cfe-commit

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 ___ cfe-commits mailing list cfe-commits

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. In D135938#3867170 , @FreddyYe wrote: > I get your point of "close to each other" and updated. And I merged the > Disasm tests, while I didn't merge the MC tests because it is not so > convenient to do. See latest updated. > > D

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

RKSimon added inline comments. Comment at: clang/test/Driver/x86-march.c:120 +// RUN: | FileCheck %s -check-prefix=meteorlake +// meteorlake: "-target-cpu" "meteorlake" // Move these after alderlake instead of the old atom cores? Repository: rG LLVM Github

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

RKSimon added a comment. Herald added a subscriber: StephenFan. @pengfei Do we still need this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 ___ cfe-commits

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

RKSimon added inline comments. Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:46 + auto SecondSemiPos = Line.find(';', FirstSemiPos + 1); + if (FirstSemiPos == std::string::npos) +continue; @cor3ntin Should this be SecondSemi

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2098 +TARGET_BUILTIN(__builtin_ia32_vpdpbssd128, "V4iV4iV4iV4i", "ncV:128:", "avxvnniint8") +TARGET_BUILTIN(__builtin_ia32_vpdpbssd256, "V8iV8iV8iV8i", "ncV:256:", "avxvnniint8")

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added a comment. Possibly rename the x86-64-* test files to *-64 (and *-32 equivalent) so that the 32/64 bit files are closer together for tracking (and to help avoid bitrot). Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135951/new/ https://reviews.llvm.org/D135951 _

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) Is there no way for __attribute__ to allow different attribute permutations? Also, c

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137054/new/ https://reviews.llvm.org/D137054 _

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { craig.topper wrote: > craig.topp

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/rdrand-builtins.c:20 #if __x86_64__ int rdrand64(unsigned long long *p) { why do you still need the #if-else-endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D132372: [X86][AVX512FP16] Add the missing const modifiers. NFCI

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132372/new/ https://reviews.llvm.org/D132372 _

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { RKSimon wrote: > craig.topper wr

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { yubing wrote: > RKSimon wrote: >

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + Doesn't this have to be the general case like in other places in the headers? ``` #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:13 +#ifdef __SSE2__ + pengfei wrote: > RKSimon wrote: > > Doesn't this have to be the general case like in other places in the > > headers? > > ``` > > #if !(defined(_MSC_VER) || d

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Headers/immintrin.h:223 +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +(defined(__AVX512VL__) && defined

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 _

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added a comment. A few minors - and this probably needs a release notes entry for 16.x? Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +setOperationAction(ISD::BUILD_VECTOR, MVT::v8bf16, Custom); --

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/avx512bf16-intrinsics-upgrade.ll:30 ; X64-NEXT:kmovd %edi, %k1 # encoding: [0xc5,0xfb,0x92,0xcf] -; X64-NEXT:vcvtne2ps2bf16 %zmm1, %zmm0, %zmm0 {%k1} {z} # encoding: [0x62,0xf2,0x7f,0xc9,0x72,0xc1] +; X64-

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/avxifma-builtins.c:1 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +avxifma -emit-llvm -o - -Wall -Werror | FileCheck %s + 32-bit test coverage?

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/cmpccxadd-builtins-error.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown \ +// RUN: -target-feature +cmpccxadd -emit-llvm -fsyntax-only -verify + Add 32-bit test coverage

[PATCH] D135936: [X86] Support -march=raptorlake

RKSimon added inline comments. Comment at: llvm/lib/Support/Host.cpp:828 + *Subtype = X86::INTEL_COREI7_RAPTORLAKE; + break; // Icelake Xeon: newline to separate the defs Comment at: llvm/lib/Target/X86/X86.td:1423

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1424 +def : ProcModel<"meteorlake", SLMModel, ProcessorFeatures.ADLFeatures, +ProcessorFeatures.TRMTuning>; This should be with the alderlake/raptorlake defs below (and use AD

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/avxvnniint8-builtins.c:1 +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avxvnniint8 -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avxneconvert-builtins.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +avx2 -target-feature +avxneconvert \ +// RUN: -target-feature +avx512fp16 -emit-llvm -o - -Wall -Werr

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added a comment. Please add this to llvm-project\llvm\test\CodeGen\X86\cpus-intel.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 ___ cfe-commits mai

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135966/new/ https://reviews.llvm.org/D135966 _

[PATCH] D135951: [X86] SUPPORT RAO-INT

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:801 +RXOR, +RAND, + very pedantic, but are these likely to get confused with ROR / RAND instructions? Would it be better to use a RAO_ prefix? Comment at:

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Support ISA of ``AVX-VNNI-INT8``. Please add a bullet list of the added intrinsics Comment

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: llvm/test/MC/X86/avx-ne-convert-att.s:1 +// RUN: llvm-mc -triple i686-unknown-unknown --show-encoding %s | FileCheck %s + merge the att + intel test files and use --check-prefixes to test both Repository: rG LLVM Gi

[PATCH] D140547: Perform access checking to private members in simple requirement.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:739 +- Correctly handle access-checks in requires expression. Fixes `GH53364 `_, + `GH53334 `_. C++2b Fe

[PATCH] D140547: Perform access checking to private members in simple requirement.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:739 +- Correctly handle access-checks in requires expression. Fixes `GH53364 `_, + `GH53334 `_. C++2b Fe

[PATCH] D140992: clang: Add __builtin_elementwise_fma

RKSimon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer + T __builtin_elementwise_fma(T x, T y, T z) fused multiply add.

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1528 +ProcessorFeatures.TRMTuning>; +def : ProcModel<"grandridge", SLMModel, ProcessorFeatures.GRRFeatures, +ProcessorFeatures.TRMTuning>; SLMModel explicitly do

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

RKSimon added a comment. What are the rules on this? Do we just handle this as an ABI breaking change and document it in the release notes - or do we need to provide any auto-upgrade path (with a warning?)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

RKSimon added reviewers: stuij, tra. RKSimon added a comment. Do you think this patch needs to be expanded to handle ARM/AArch64/NVPTX - all of which override getBFloat16Mangling in similar ways? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919

[PATCH] D142477: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The macro `_mm_test_all_ones(V)` was defined as `_mm_testc_si128((V), _mm_c

[PATCH] D142477: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b28233599a: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006) (authored by RKSimon). Repository: rG LLVM Github Monorep

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon added a comment. What do we gain from using __builtin_nondeterministic_value instead of just setzero? https://godbolt.org/z/zrb6858Mr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 _

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon created this revision. RKSimon added reviewers: rsmith, chapuni, MaskRay, kristina, erik.pilkington. Herald added subscribers: wenlei, hiraditya. Herald added a project: All. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commit

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon added a comment. In D143318#4104408 , @MaskRay wrote: > `ItaniumManglingCanonicalizer.cpp` doesn't have many includes. I think it is > fine to remain in llvm/lib/Support ... The frontend cost might not be high - but ItaniumManglingCanonicalizer.

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon added a comment. In D143318#4104410 , @phosek wrote: > Another alternative would be to move these classes to the Demangle library. I'm happy to move this to LLVMDemangle instead if everyone agrees. Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3   4   5   6   7   >