sfantao added a comment.
Hi Kelvin,
Thanks for working on this! I have some minor comments inlined.
Comment at: lib/Sema/SemaOpenMP.cpp:9392
@@ +9391,3 @@
+ SemaRef.Diag(ELoc, diag::err_omp_map_shared_storage) << ERange;
+else
+ SemaRef.Dia
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
Target regions require globals to be captured. The capturing scope has been
determine by matching the scope of the capture
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
The current offloading implementation is using -omptargets and
-omp-host-ir-file-path options in the frontend. This causes
sfantao added a comment.
Ping!
http://reviews.llvm.org/D16749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Mon Mar 14 10:57:41 2016
New Revision: 263442
URL: http://llvm.org/viewvc/llvm-project?rev=263442&view=rev
Log:
[OpenMP] Replace offloading option that start with -o with -fo.
Summary:
The current offloading implementation is using -omptargets and
-omp-host-ir-file-path opt
sfantao created this revision.
sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits.
This patch introduces the concept of offloading tool chain and offloading kind.
Each tool chain may have associated an of
sfantao created this revision.
sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits.
This patch replaces the CUDA specific action by a generic offload action. The
offload action may have multiple dependence
sfantao created this revision.
sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits.
This patch proposes a new class to generate and record action dependences
related with offloading. The builder provides t
sfantao added a comment.
Thanks Kelvin,
I'm fine with the patch. Let's wait for Alexey to see if he has any concern.
Thanks again!
Samuel
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
sfantao added a comment.
Hi Alexey,
I am afraid I don't understand what you are trying to accomplish with this. I
was unable to compile your patch as is, I think what you intended is something
like this:
// If we are mapping a field of 'this' we attempt to generate a
// OMPCapturedExprDec
sfantao added a comment.
Hi Alexey,
I am sorry but I don't think I am following. So in your example:
#pragma omp target map(to: this->A)
[]()->void {++A}();
the map clause is going to make sure the runtime library allocates the section
of `this` that contains A and that is what is used in
sfantao added a comment.
Hi Richard,
Thanks for your review. I partitioned some of the stuff I am proposing here in
smaller patches:
http://reviews.llvm.org/D18170
http://reviews.llvm.org/D18171
http://reviews.llvm.org/D18172
These patches already try to incorporate the feedback I got in
http
sfantao added a comment.
In http://reviews.llvm.org/D16749#378969, @ABataev wrote:
> Samuel, this is true for device part of codegen. But what about host? If
> this code must be executed on host, will it be handled correctly?
Hi Alexey,
Yes, it will be handled correctly. The map clause doesn
sfantao added a comment.
Ping!
http://reviews.llvm.org/D18110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Michael,
In http://reviews.llvm.org/D9888#380225, @mkuron wrote:
> The three smaller patches into which you divided this one appear to be
> missing some things. For example, `AddOpenMPLinkerScript` in
> //lib/Driver/Tools.cpp// from this patch appears to still be ne
sfantao added a comment.
Thanks for the fix!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingTeams(const Stmt *TargetBody) {
+ if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir;
+
I think that this can be simplified to:
```
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingTeams(const Stmt *TargetBody) {
+ if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir;
+
carlo.bertolli wrote:
> sfantao wrote:
> > I think that this
sfantao added a comment.
Ping!
http://reviews.llvm.org/D18110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Ping!
http://reviews.llvm.org/D16749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Tue Jan 5 12:02:24 2016
New Revision: 256854
URL: http://llvm.org/viewvc/llvm-project?rev=256854&view=rev
Log:
[OpenMP] Allow file ID to be signed in the offloading metadata.
This fixes a regression introduced by rL256842.
Modified:
cfe/trunk/test/OpenMP/target_codege
sfantao updated this revision to Diff 44124.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D7606
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaCast.cpp
test/CodeGen/address-space-explicit-cast.c
Index: test/CodeGen/address-space-explicit-cast.c
Author: sfantao
Date: Thu Jan 7 08:58:16 2016
New Revision: 257065
URL: http://llvm.org/viewvc/llvm-project?rev=257065&view=rev
Log:
[OpenMP] Fix issue in the offloading metadata testing.
- Allow device ID to be signed.
- Add missing semicolon to some of the CHECK directives.
Thanks to Amjad
Author: sfantao
Date: Tue Jan 19 13:15:56 2016
New Revision: 258165
URL: http://llvm.org/viewvc/llvm-project?rev=258165&view=rev
Log:
[OpenMP] Parsing + sema for "target enter data" directive.
Patch by Arpith Jacob. Thanks!
Added:
cfe/trunk/test/OpenMP/target_enter_data_ast_print.cpp
cf
sfantao closed this revision.
sfantao added a comment.
Committed revision 258165.
Thanks,
Samuel
http://reviews.llvm.org/D15989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Tue Jan 19 14:04:50 2016
New Revision: 258177
URL: http://llvm.org/viewvc/llvm-project?rev=258177&view=rev
Log:
[OpenMP] Parsing + sema for "target exit data" directive.
Patch by Arpith Jacob. Thanks!
Added:
cfe/trunk/test/OpenMP/target_exit_data_ast_print.cpp
cfe/t
sfantao closed this revision.
sfantao added a comment.
Committed revision 258177.
Thanks,
Samuel
http://reviews.llvm.org/D16279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Tue Jan 19 14:40:49 2016
New Revision: 258179
URL: http://llvm.org/viewvc/llvm-project?rev=258179&view=rev
Log:
[OpenMP] Detect implicit map type to report unspecified map type for target
enter/exit data directives.
Support for the following OpenMP 4.5 restriction on 'targe
sfantao closed this revision.
sfantao added a comment.
Committed revision 258179.
Thanks,
Samuel
http://reviews.llvm.org/D16280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, kkwli0, arpith-jacob, carlo.bertolli.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
Extend support in the map clause SEMA for the expressions supported in the
OpenMP 4.5 specification, namely member express
sfantao updated this revision to Diff 45557.
sfantao retitled this revision from " [OpenMP] Update map clause SEMA to
support OpenMP 4.5 possible list items." to "[OpenMP] Update map clause SEMA to
support OpenMP 4.5 possible list items.".
sfantao updated the summary for this revision.
sfantao ad
Author: sfantao
Date: Fri Jan 22 14:21:36 2016
New Revision: 258543
URL: http://llvm.org/viewvc/llvm-project?rev=258543&view=rev
Log:
[OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.
Summary:
Extend support in the map clause SEMA for the expressions supported in the
Ope
Author: sfantao
Date: Fri Jan 22 14:52:54 2016
New Revision: 258550
URL: http://llvm.org/viewvc/llvm-project?rev=258550&view=rev
Log:
[OpenMP] Remove '#if 1' hanging in target_map_messages.cpp.
Modified:
cfe/trunk/test/OpenMP/target_map_messages.cpp
Modified: cfe/trunk/test/OpenMP/target_
sfantao created this revision.
sfantao added reviewers: rjmccall, rnk, ABataev, hfinkel.
sfantao added a subscriber: cfe-commits.
This patch changes the generation of `CGFunctionInfo` to contain the
`FunctionProtoType` if it is available. This enables the code generation for
call instructions to
sfantao added a comment.
Ping!
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Ping!
http://reviews.llvm.org/D7606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 40587.
sfantao added a comment.
Create `CGCalleeInfo` to forward the declaration and function type information
during the emission of calls.
http://reviews.llvm.org/D14796
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeG
sfantao added a comment.
In http://reviews.llvm.org/D14796#292336, @rjmccall wrote:
> What I was thinking was something more along the lines of a little struct
> that stored either a Decl * or a FunctionType *, and you could change the
> TargetDecl argument to functions like EmitCall and Constr
sfantao updated this revision to Diff 40646.
sfantao added a comment.
Update comment as suggested by John.
http://reviews.llvm.org/D14796
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGObjC.cpp
sfantao added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3751
@@ +3750,3 @@
+ // Preserve the non-canonical function type because things like exception
+ // specifications disappear in the canonical type. That information is useful
+ // to drive the generation of more
Author: sfantao
Date: Mon Nov 23 16:04:44 2015
New Revision: 253926
URL: http://llvm.org/viewvc/llvm-project?rev=253926&view=rev
Log:
Preserve exceptions information during calls code generation.
This patch changes the generation of CGFunctionInfo to contain
the FunctionProtoType if it is availa
sfantao updated this revision to Diff 40977.
sfantao added a comment.
Fix typo in comment.
http://reviews.llvm.org/D14796
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGOb
sfantao added a comment.
Committed in r253926!
Thanks,
Samuel
Comment at: lib/CodeGen/CGCall.cpp:1420
@@ +1419,3 @@
+ // If we have information about the function prototype, we can learn
+ // attributes form there.
+ AddAttributesFromFunctionProtoType(getContext(), FuncAttrs
sfantao updated this revision to Diff 40992.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/Driver/CC1Options.td
include/clang/Drive
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 40999.
sfantao updated the summary for this revision.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D13909
Files:
tools/CMakeLists.txt
tools/Makefile
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bundler/ClangOffloadBundl
sfantao updated this revision to Diff 41001.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D9888
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/CC1Options.td
include/clang/Driver/Driver.h
include/clang/Driver/Options.t
Author: sfantao
Date: Mon Nov 30 11:26:28 2015
New Revision: 254306
URL: http://llvm.org/viewvc/llvm-project?rev=254306&view=rev
Log:
Add --gcc-toolchain= to one of the libclang unitests to fix issue related to
the gcc libraries clang picks for when it was configures with a user defined
path.
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/AST/Stmt.h:2018-2020
@@ -2016,2 +2017,5 @@
break;
+ case VCK_ByCopy:
+assert(Var && "capturing by copy must have a variable!");
+break;
case VCK_VLAType:
--
sfantao added a comment.
Are there any more comments for this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 41676.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D7606
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaCast.cpp
test/CodeGen/address-space-explicit-cast.c
Index: test/CodeGen/address-space-explicit-cast.c
==
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D7606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Any more comments on this patch?
Thanks,
Samuel
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 453 of 453 matches
Mail list logo
