sfantao updated this revision to Diff 33111.
sfantao added a comment.
Move map type and device id enums from CGOpenMPRuntime.h to CGOpenMPRuntime.cpp.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/Op
sfantao added a comment.
Thanks for the review!
In http://reviews.llvm.org/D11361#232045, @ABataev wrote:
> Samuel, Yes, I thought about different files and different classes. Runtime
> for offloading codegen is not a part of libomp and it would be good to have
> separate runtime handler class
sfantao updated this revision to Diff 33640.
sfantao added a comment.
Address last review comments.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_codegen.cpp
Index: test/OpenMP/target_
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2991-3005
@@ +2990,17 @@
+
+/// \brief Values for bit flags used to specify the mapping type for
+/// offloading.
+enum OpenMPOffloadMappingFlags {
+ /// \brief Allocate memory on the device and move data
sfantao updated this revision to Diff 33712.
sfantao added a comment.
Rebase on top of the last changes in http://reviews.llvm.org/D11361.
http://reviews.llvm.org/D12262
Files:
include/clang/Basic/OpenMPKinds.h
include/clang/Sema/Sema.h
lib/Basic/OpenMPKinds.cpp
lib/Sema/SemaExpr.cpp
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:702
@@ +701,3 @@
+ return true;
+}
+ }
Alexey, after rebasing this patch with the latest changes, I started having a
regression related with how `DSAStack->hasDirective` works. In my und
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel, tra.
sfantao added a subscriber: cfe-commits.
In order to offloading work properly two things need to be in place:
- a descriptor with all the offloading information (device entry functions, and
global variable) h
sfantao abandoned this revision.
sfantao added a comment.
I am closing this revision as I added the functionality for the device codegen
on top of this patch in http://reviews.llvm.org/D12614 because the two are
tightly coupled.
Thanks,
Samuel
http://reviews.llvm.org/D12306
___
sfantao updated this revision to Diff 36812.
sfantao added a comment.
Rebase and fix typo in regression test directive.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/
sfantao updated this revision to Diff 36816.
sfantao added a comment.
Make the offloading ELF sections consistent with what is in
http://reviews.llvm.org/D12614.
Fix bug in AtTopLevel flag, so that the bundling job is considered always top
level job.
Fix several typos.
http://reviews.llvm.or
sfantao added a comment.
Art, Jonas,
Thanks for the comments!
In http://reviews.llvm.org/D9888#261434, @Hahnfeld wrote:
> Currently trying to test, but
>
> 1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu`
> as host and device) - this was working with `clang-omp` The
sfantao added a comment.
In http://reviews.llvm.org/D9888#262325, @tra wrote:
> In http://reviews.llvm.org/D9888#257904, @sfantao wrote:
>
> > This diff refactors the original patch and is rebased on top of the latests
> > offloading changes inserted for CUDA.
> >
> > Here I don't touch the CUDA
sfantao updated this revision to Diff 36880.
sfantao added a comment.
Use class instead of structs if aggregate have private or protected fields.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/Lang
sfantao added a comment.
Thanks for the comments!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
ABataev wrote:
> Maybe it is better to make it a class if it has some non-pu
sfantao added a comment.
Are there any more comments/suggestions about this patch?
Thanks!
Samuel
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Ping!
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 37802.
sfantao added a comment.
Use `GlobalDecl` to forward information about the name of OpenMP region's
enclosing function to the OpenMP outlined functions. This replaces the initial
implementation that was using a stack to keep this information.
Add regr
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962
@@ +1961,3 @@
+[LineNum][ColNum];
+assert(Entry.Order != -1u && "Entry not initialized!");
+assert(!Entry.Addr && !Entry.ID && "Entry registered alre
sfantao created this revision.
sfantao added reviewers: hfinkel, rsmith, echristo, ABataev, chandlerc.
sfantao added a subscriber: cfe-commits.
One of the goals of programming models that support offloading (e.g. OpenMP) is
to enable users to offload with little effort, by annotating the code wit
sfantao updated this revision to Diff 37903.
sfantao added a comment.
Move clang-offload-bundler to to a separate review:
http://reviews.llvm.org/D13909.
This patch depends on http://reviews.llvm.org/D13909.
http://reviews.llvm.org/D9888
Files:
include/clang/Basic/DiagnosticDriverKinds.td
sfantao created this revision.
sfantao added a reviewer: bkramer.
sfantao added a subscriber: cfe-commits.
If the user configured clang with a custom GCC toolchain that will take
precedence on what the ToolChainTest.cpp expects to evaluate. This was causing
the test to fail in these cases.
This
sfantao added a comment.
Hi John,
Thanks for the remark!
In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
> CurFuncDecl is supposed to be the enclosing user function. Things like
> outlined functions should be getting stored in CurCodeDecl; that's how it's
> done for blocks and lam
Author: sfantao
Date: Tue Oct 27 17:20:26 2015
New Revision: 251459
URL: http://llvm.org/viewvc/llvm-project?rev=251459&view=rev
Log:
Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain.
If the user configured clang with a custom GCC toolchain that will take
precedence on what the
sfantao closed this revision.
sfantao added a comment.
Committed in r251459.
Thanks!
Samuel
http://reviews.llvm.org/D13920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 39588.
sfantao added a comment.
Use `CurFuncDecl` to generate offload kernel names as suggested by John McCall.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/
sfantao added a comment.
In http://reviews.llvm.org/D12614#278101, @rjmccall wrote:
> In http://reviews.llvm.org/D12614#274349, @sfantao wrote:
>
> > Hi John,
> >
> > Thanks for the remark!
> >
> > In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
> >
> > > CurFuncDecl is supposed to be
sfantao updated this revision to Diff 39590.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D13909
Files:
tools/CMakeLists.txt
tools/Makefile
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bundler/ClangOffloadBundler.cpp
tools/clang-offload-bundler/Makefile
sfantao updated this revision to Diff 39594.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D9888
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/CC1Options.td
include/clang/Driver/Driver.h
include/clang/Driver/Options.t
sfantao updated this revision to Diff 39619.
sfantao added a comment.
Rebase and add check to make sure the pointee of the pointers being casted
match.
In a previous review, it was suggested by Richard Smith to move the check to
the end of `TryReinterpretCast`. However, that does not solve the
Author: sfantao
Date: Mon Jul 18 18:22:11 2016
New Revision: 275930
URL: http://llvm.org/viewvc/llvm-project?rev=275930&view=rev
Log:
[OpenMP] Remove dead code in conditional of mappable expressions SEMA.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cp
sfantao created this revision.
sfantao added reviewers: tra, rsmith.
sfantao added subscribers: cfe-commits, rsmith.
This patch adds clang system include path when offloading tool chains, e.g.
CUDA, are used in the current compilation.
This fixes an issue detected by @rsmith in response to r2756
sfantao updated this revision to Diff 64428.
sfantao added a comment.
- Add missing context for review.
https://reviews.llvm.org/D22490
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib
Author: sfantao
Date: Mon Jul 18 19:01:12 2016
New Revision: 275931
URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev
Log:
Append clang system include path for offloading tool chains.
Summary:
This patch adds clang system include path when offloading tool chains, e.g.
CUDA, are used i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275931: Append clang system include path for offloading tool
chains. (authored by sfantao).
Changed prior to commit:
https://reviews.llvm.org/D22490?vs=64428&id=64432#toc
Repository:
rL LLVM
https:/
sfantao created this revision.
sfantao added reviewers: tra, rsmith.
sfantao added subscribers: cfe-commits, rsmith.
This patch aims at removing redundancy in the way include paths for the regular
and offloading toolchains are appended to the arguments list in the clang tool.
This was suggested
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch fixes a bug in the map of array sections whose base is a reference
to a pointer. The existing mapping support was not prepared to deal with
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch adds support for the use_device_ptr clause. It includes changes in
SEMA that could not be tested without codegen, namely, the
sfantao updated this revision to Diff 65123.
sfantao added a comment.
- Use the correct enumerator for return pointer, as specified in the design
document.
https://reviews.llvm.org/D22691
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
l
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch add support to map pointers through references in class members.
Although a reference does not have storage that a user can a
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch adds support for the is_device_ptr clause. It expands SEMA to use
the mappable expression logic that can only be tested with
sfantao updated this revision to Diff 65747.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Remove of use of SmallVector and include CUDA args only for the regular
toolchain.
https://reviews.llvm.org/D22518
Files:
lib/Driver/Tools.cpp
test/Driver/cuda-version-check.cu
sfantao added a comment.
Hi Art, Richard,
Thanks for looking at this patch. I tried to address Richard concerns in the
last diff.
Let me know your thoughts,
Thanks again,
Samuel
Comment at: lib/Driver/Tools.cpp:308-335
@@ -349,1 +307,30 @@
+Action::OffloadKind ActiveOffl
sfantao updated this revision to Diff 65751.
sfantao marked an inline comment as done.
sfantao added a comment.
- Use castAs instead of getAs in pointer type.
https://reviews.llvm.org/D22690
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_map_codegen
sfantao updated this revision to Diff 65810.
sfantao marked 8 inline comments as done.
sfantao added a comment.
- Remove unnecessary brief directives and refactor target data privatization
code genenration.
https://reviews.llvm.org/D22691
Files:
include/clang/AST/OpenMPClause.h
lib/AST/Ope
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3410-3411
@@ +3409,4 @@
+ llvm::DenseSet EmittedAsFirstprivate;
+ CGCapturedStmtInfo CapturesInfo(cast(*D.getAssociatedStmt()));
+ for (const auto *C : D.getClausesOfKind()) {
sfantao updated this revision to Diff 65813.
sfantao updated the summary for this revision.
sfantao added a comment.
- Remove unecessary brief directives from comments.
https://reviews.llvm.org/D22788
Files:
include/clang/AST/OpenMPClause.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/A
Author: sfantao
Date: Wed Jul 27 17:46:31 2016
New Revision: 276929
URL: http://llvm.org/viewvc/llvm-project?rev=276929&view=rev
Log:
Refactor how include paths are appended to the command arguments.
Summary:
This patch aims at removing redundancy in the way include paths for the regular
and off
Author: sfantao
Date: Wed Jul 27 17:49:49 2016
New Revision: 276933
URL: http://llvm.org/viewvc/llvm-project?rev=276933&view=rev
Log:
[OpenMP] Add support for mapping array sections through pointer references.
Summary:
This patch fixes a bug in the map of array sections whose base is a reference
Author: sfantao
Date: Wed Jul 27 17:52:16 2016
New Revision: 276934
URL: http://llvm.org/viewvc/llvm-project?rev=276934&view=rev
Log:
[OpenMP] Add support to map member expressions with references to pointers.
Summary: This patch add support to map pointers through references in class
members. A
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob,
kkwli0, tra.
sfantao added subscribers: cfe-commits, caomhin.
This patch prevents OpenMP flags from being forwarded to CUDA device commands.
That was causing the CUDA frontend to attempt to em
Author: sfantao
Date: Thu Jul 28 09:23:26 2016
New Revision: 276977
URL: http://llvm.org/viewvc/llvm-project?rev=276977&view=rev
Log:
[OpenMP] Codegen for use_device_ptr clause.
Summary: This patch adds support for the use_device_ptr clause. It includes
changes in SEMA that could not be tested w
Author: sfantao
Date: Thu Jul 28 09:25:09 2016
New Revision: 276978
URL: http://llvm.org/viewvc/llvm-project?rev=276978&view=rev
Log:
[OpenMP] Code generation for the is_device_ptr clause
Summary: This patch adds support for the is_device_ptr clause. It expands SEMA
to use the mappable expressio
Author: sfantao
Date: Thu Jul 28 09:29:18 2016
New Revision: 276979
URL: http://llvm.org/viewvc/llvm-project?rev=276979&view=rev
Log:
[OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.
Summary:
This patch prevents OpenMP flags from being forwarded to CUDA device commands.
That w
Author: sfantao
Date: Thu Jul 28 09:47:35 2016
New Revision: 276981
URL: http://llvm.org/viewvc/llvm-project?rev=276981&view=rev
Log:
[OpenMP] Do not use default argument in lambda from mappable expressions
handlers.
Windows bots were complaining about that.
Modified:
cfe/trunk/lib/CodeGen
Author: sfantao
Date: Thu Jul 28 09:56:19 2016
New Revision: 276983
URL: http://llvm.org/viewvc/llvm-project?rev=276983&view=rev
Log:
[OpenMP] Fix link command pattern in offloading interoperability test.
It was causing a few bots to fail.
Modified:
cfe/trunk/test/Driver/offloading-interope
Author: sfantao
Date: Thu Jul 28 10:31:29 2016
New Revision: 276988
URL: http://llvm.org/viewvc/llvm-project?rev=276988&view=rev
Log:
[OpenMP] Change name of variable in mappble expression.
This attempts to fix a failure in Windows bots pottentially related with a
reserved keyword.
Modified:
Author: sfantao
Date: Thu Jul 28 11:12:30 2016
New Revision: 276995
URL: http://llvm.org/viewvc/llvm-project?rev=276995&view=rev
Log:
[CUDA] Rename cuda_phases.cu test to cuda-phases.cu to be consistent with the
other tests.
Added:
cfe/trunk/test/Driver/cuda-phases.cu
Added: cfe/trunk/test/
Author: sfantao
Date: Thu Jul 28 11:18:31 2016
New Revision: 276996
URL: http://llvm.org/viewvc/llvm-project?rev=276996&view=rev
Log:
[CUDA] Remove duplicated test that should have been removed in r276995.
Removed:
cfe/trunk/test/Driver/cuda_phases.cu
Removed: cfe/trunk/test/Driver/cuda_phas
sfantao updated this revision to Diff 66017.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 66016.
sfantao added a comment.
- Remove redundant phases from cuda-phases.cu and use DAG check.
- Rebase.
https://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/c
sfantao updated this revision to Diff 66018.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool
sfantao updated this revision to Diff 66019.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/
sfantao updated this revision to Diff 66020.
sfantao added a comment.
- Add option to dump and test the linker script contents.
- Rebase.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index
sfantao updated this revision to Diff 66023.
sfantao added a comment.
- Fix bug in conditional.
- Rebase.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-
sfantao updated this revision to Diff 66027.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Types.cpp
test/Driver/o
sfantao updated this revision to Diff 66025.
sfantao added a comment.
- Refactor code to dump contents of temporary file instead of creating the
actual file in dry-run mode.
- Rebase.
https://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
test/Driver/clang-offload-bundl
sfantao updated this revision to Diff 66026.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
=
sfantao updated this revision to Diff 66028.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 66029.
sfantao added a comment.
- Fix type qualifier.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver
sfantao updated this revision to Diff 66021.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/ToolChain.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolCha
sfantao added a comment.
Any more comments on this patch or depending ones?
Thanks!
Samuel
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Thu Jul 28 17:42:42 2016
New Revision: 277064
URL: http://llvm.org/viewvc/llvm-project?rev=277064&view=rev
Log:
[CUDA] Unswitch enumerators in the selection of the offloading tool chain.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
U
sfantao added a comment.
In https://reviews.llvm.org/D22518#500066, @tra wrote:
> Samuel, the patch breaks CUDA. With the patch clang no longer adds include
> paths to standard c++ library during device-side compilation.
> if you run "clang++ -### -c -x cuda /dev/null" you will see that host si
sfantao created this revision.
sfantao added a reviewer: tra.
sfantao added a subscriber: cfe-commits.
Add test to detect the C++ include paths are passed to both CUDA host and
device frontends.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-simple.cu
Index: test/Driver/cuda-simple.
sfantao updated this revision to Diff 66189.
sfantao added a comment.
- Remove duplicate keyword in linker script.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-of
sfantao added a comment.
Friendly ping.
Thanks!
https://reviews.llvm.org/D22946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 67335.
sfantao marked an inline comment as done.
sfantao added a comment.
- Move CUDA C++ include path tests to cuda-detect.cu. Address other Art's
comments.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-detect.cu
Index: test/Driver/cuda-detec
sfantao updated this revision to Diff 67366.
sfantao marked an inline comment as done.
sfantao added a comment.
- Remove redundant test - copied by mistake.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-detect.cu
Index: test/Driver/cuda-detect.cu
===
sfantao added inline comments.
Comment at: test/Driver/cuda-detect.cu:75-77
@@ -74,1 +74,5 @@
+// Verify that compiler accepts CUDA syntax with "-x cuda-cpp-output".
+// RUN: %clang -Werror -fsyntax-only -x cuda-cpp-output -c %s
+//
+// Verify that C++ include paths are passed f
Author: sfantao
Date: Tue Aug 9 12:27:24 2016
New Revision: 278140
URL: http://llvm.org/viewvc/llvm-project?rev=278140&view=rev
Log:
[CUDA] Regression test to make sure C++ include path are forwarded to host and
device frontends.
Summary: Add test to detect the C++ include paths are passed to b
sfantao updated this revision to Diff 46825.
sfantao marked 4 inline comments as done.
sfantao added a comment.
Clean up changes that are not required now.
Use CGOpenMPRuntime to contain everything that requires sharing.
Create diagnostic to notify user about unsupported OpenMP targets.
http:/
sfantao added a comment.
Hi Alexey,
Thanks again for the review!
Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1
@@ +1,2 @@
+//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen
==//
+//
ABataev wrote:
> I don't think we need this new
sfantao added a comment.
Hi Alexey,
Thanks for the feedback!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:340-341
@@ +339,4 @@
+ case llvm::Triple::nvptx64:
+assert(CGM.getLangOpts().OpenMPIsDevice &&
+ "OpenMP NVPTX is only prepared to deal with device code.");
+
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555
@@ -551,2 +551,6 @@
+ /// \brief Create specialized OpenMP runtime code generation class for NVPTX
+ /// targets.
+ static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM);
+
publ
Author: sfantao
Date: Thu Feb 4 02:13:16 2016
New Revision: 259769
URL: http://llvm.org/viewvc/llvm-project?rev=259769&view=rev
Log:
Add -nocudainc option to CUDA preprocessor test.
If include files are used in the CUDA preprocessor tests it will cause a
failure due to a missing header file in
sfantao updated this revision to Diff 46935.
sfantao added a comment.
Create CGOpenMPRuntimeNVPTX header file and mike specialization selection in
CodeGenModule.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Co
sfantao updated this revision to Diff 46937.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove return statement and use 'false' instead of relying on OpenMPIsDevice.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpen
sfantao added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:218
@@ -204,1 +217,3 @@
+ }
+ return;
}
ABataev wrote:
> I think this must be removed
Ok, done.
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+
sfantao updated this revision to Diff 46939.
sfantao added a comment.
Add comment.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenM
sfantao updated this revision to Diff 46941.
sfantao added a comment.
Change diagnostic for invalid host target.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
lib/CodeGen/CMakeLi
sfantao marked an inline comment as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+ Diags.Report(clang::diag::err_drv_omp_host_target_not_supported)
+ << TargetOpts.Triple;
+ break;
Ok, I did as you say. thanks!
http
Author: sfantao
Date: Fri Feb 5 20:12:34 2016
New Revision: 259977
URL: http://llvm.org/viewvc/llvm-project?rev=259977&view=rev
Log:
[OpenMP] Reorganize code to allow specialized code generation for different
devices.
Summary:
Different devices may in some cases require different code generatio
Author: sfantao
Date: Sat Feb 6 00:22:46 2016
New Revision: 259984
URL: http://llvm.org/viewvc/llvm-project?rev=259984&view=rev
Log:
Revert r259977 - [OpenMP] Reorganize code to allow specialized code generation
for different devices.
It triggered some problem in the configuration related with
Author: sfantao
Date: Sat Feb 6 00:52:48 2016
New Revision: 259985
URL: http://llvm.org/viewvc/llvm-project?rev=259985&view=rev
Log:
Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code
generation for different devices.
This was reverted due to a failure in a buildbot, but it t
Author: sfantao
Date: Mon Feb 8 09:59:20 2016
New Revision: 260106
URL: http://llvm.org/viewvc/llvm-project?rev=260106&view=rev
Log:
Re-apply for the 2nd-time r259977 - [OpenMP] Reorganize code to allow
specialized code generation for different devices.
This was reverted by r260036, but was not
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
This patch implements the launching of a target region in the presence of a
nested teams region, i.e calls tgt_target_team
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, arpith-jacob, carlo.bertolli, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
Unlike other outlined regions in OpenMP, offloading entry points have to have
be visible (external linkage) for the device
sfantao added a comment.
Ping!
http://reviews.llvm.org/D16749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Sat Feb 13 17:35:10 2016
New Revision: 260837
URL: http://llvm.org/viewvc/llvm-project?rev=260837&view=rev
Log:
[OpenMP] Rename the offload entry points.
Summary:
Unlike other outlined regions in OpenMP, offloading entry points have to have
be visible (external linkage) for
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGExpr.cpp:2937-2943
@@ -2936,2 +2936,9 @@
QualType BaseTy = Base.getType();
+ // If the base is a pointer, we actually need to compute the offset in the
+ // pointee.
+ if (BaseTy->isAnyPo
101 - 200 of 453 matches
Mail list logo
