sfantao added inline comments. ================ Comment at: lib/Sema/SemaOpenMP.cpp:702 @@ +701,3 @@ + return true; + } + } ---------------- Alexey, after rebasing this patch with the latest changes, I started having a regression related with how `DSAStack->hasDirective` works. In my understanding it requires that a valid scope exists in the stack, or alternatively that 2 or more entries exist in the stack. In some cases `DSAStack->hasDirective` was being called with only one entry causing the iterators in there not to work properly. The fix for that was adding `DSAStack->getCurScope()`. It seems to be a harmless change, but still wanted to make sure you agree with that.
Thanks! http://reviews.llvm.org/D12262 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
