[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. Oh I see. lgtm. Do we need to update any tests? I see we won't have a wasm-ld.c test yet? We should add one? Repository: rC Clang https://reviews.llvm.org/D40739 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. By the way, thank you for all these wasm patches! Repository: rC Clang https://reviews.llvm.org/D40739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. Sure I'll land this now. Repository: rC Clang https://reviews.llvm.org/D40739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41073: Wasm: add support in libcxx

sbc100 added a comment. Do you want to land this dan? Or I can if you prefer. Repository: rCXX libc++ https://reviews.llvm.org/D41073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

This revision was automatically updated to reflect the committed changes. Closed by commit rG849df8f6f0a6: [clang][WebAssembly] Pass `-Wa,--no-type-check` through to the MC layer (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D131217?vs=454128&id=457215#toc Repository:

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

sbc100 added a comment. This change also broken emscripten in some odd ways: https://app.circleci.com/pipelines/github/emscripten-core/emscripten/23359/workflows/4080be5f-bd82-45b9-a355-3a5d4f4ef977/jobs/564543. The revert seems to have fixed it. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 updated this revision to Diff 557937. sbc100 added a comment. - rename flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/test/wasm/stri

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 added a comment. Updated to use `--keep-section`. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

sbc100 updated this revision to Diff 557958. sbc100 marked an inline comment as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 Files: clang/lib/Driver/ToolChain

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

sbc100 updated this revision to Diff 557959. sbc100 marked an inline comment as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 Files: clang/lib/Driver/ToolChain

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

sbc100 updated this revision to Diff 557960. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/test/wasm/strip-a

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

sbc100 added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG89d5635f0a83: [lld][WebAssembly] Add --keep-section flag (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D149917?vs=557960&id=557993#toc Repository: rG LLVM Github Monorepo C

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Do you think we should backport this to llvm 15, since it missed the branch point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/ ht

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. Repository: rG LLV

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 added a comment. Work in progress -- still needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 added a comment. In D131217#3701363 , @MaskRay wrote: > Test? > > And we should not have `llvm::dbgs() << "Main " << Opts.NoTypeCheck << "\n";` > by default. Sorry, as as said above "Work in progress -- still needs a test." Repository: rG LLV

[PATCH] D131217: [WIP][clang][WebAssembly] Pass `-Wl, -no-type-check` through to the MC layer

sbc100 updated this revision to Diff 450196. sbc100 added a comment. - remove debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 Files: clang/include/clang/Basic/CodeGenOptions.def clang/includ

[PATCH] D118573: [clang][WebAssemmbly] Call TargetInfo::adjust in derived method.

sbc100 added a comment. Oddly enough and emscripten user just reported an issue that this patch fixes: https://github.com/emscripten-core/emscripten/issues/16241 PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118573/new/ https://reviews.llvm.

[PATCH] D118573: [clang][WebAssemmbly] Call TargetInfo::adjust in derived method.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecbcefd693dd: [clang][WebAssemmbly] Call TargetInfo::adjust in derived method. (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

sbc100 added a comment. This new test has been failing on the emscripten builders.. seemingly ever since it landed: https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8815286583388131569/overview It also fails for me locally: ../llvm-build/bin/llvm-lit clang/test

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. I don't really see why we can't just have the existing `-mexception-handling` take on this new meaning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208 ___

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. Is there some reason why clang can't pass the -exception-model=wasm flag programatically to llc when -mmexception-handling is set? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. But why not make -mexception-handling be the option that enabled everything? I mean -mexception-handling is a flag we have today.. if you add -fwasm-exceptions what does -mexception-handling meaning? Is it still useful? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. Derek, are you saying that `-mexception-handling` is somehow related to `-fno-exceptions`. What is the relationship?I wasn't aware this change was related to `-fno-exceptions`. `-pthreads` enabling `-matomics` and `-mbulk-memory`make some sense because each of t

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: This seems to disagree with the longer list in `callingConvSupported`.Is this going to generate unnecessary warnings?

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5589 + // alias for "main" in the no-argument case so that libc can detect when + // new-style no-argument main is in us

[PATCH] D87537: [lld][WebAssembly] Add mutable-globals to feature section if needed

sbc100 updated this revision to Diff 291317. sbc100 edited the summary of this revision. sbc100 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. switch to verification in wasm-ld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 added a comment. OK.. updated PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: lld/wasm/Writer.cpp:478 + toString(*sym) + "`. Use --no-check-features to suppress."); + else if (sym->isExported()) +error(Twine("mutable global exported but

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 updated this revision to Diff 291323. sbc100 edited the summary of this revision. sbc100 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 Files: clang/lib/Driver/ToolChains

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 updated this revision to Diff 291380. sbc100 added a comment. Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm-to

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG04febd30a8da: [lld][WebAssembly] Error on import/export of mutable global without `mutable… (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 added a comment. This came up again in wasi-sdk: https://github.com/WebAssembly/wasi-sdk/issues/153 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 added a comment. Seems reasonable. Do you think this way is cleaner than the way elf does it? Looks like ELF creates two different ELFWriter inside the ELFDwoObjectWriter subclass right? Are we going need to wasm-ld tests to followup or is this really independent of the linker? =

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 accepted this revision. sbc100 added a comment. I'd love to see this land so we can drop our downstream patch in emscripten and also fix the outstanding wasi-sdk issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://review

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 added a comment. Might even be worth backporting such as simple but useful fix to the 11 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___ cfe-c

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 accepted this revision. sbc100 added a comment. I don't really grok the `TargetFrameLowering::DwarfFrameBase` part but everything else LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 __

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 requested review of this revision. Herald added a subscriber: aheejin. These builtins don't have any actua

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 added a comment. I don't think so but I will double check. I'm in the middle of some TLS rethinking so I'll leave this open for now pending any changes to our TLS ABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://review

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 added a comment. Nope I was wrong, emscripten does use these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://reviews.llvm.org/D91222 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1353 if (Begin) { WasmIndices[cast(Begin)] = CustomSections.size(); -if (SectionName != Begin->getNam

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 added a comment. still lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > dblaikie wrote: > > dschuff

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:260 + if (!HasAtomics) { +Opts.POSIXThreads = false; +Opts.setThreadModel(LangOptions::ThreadModelKind::Single); POSIXThreads already defaults to false I think. It gets s

[PATCH] D96171: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__

sbc100 created this revision. Herald added subscribers: wingo, jfb, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Currently the emscripten frontend driver injects this when building with thread support. Moving thi

[PATCH] D96171: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38a285885dd5: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__ (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. Why not just use crt1.o in both cases?If you are going to prefer crt1-command.o in all cases then a toolchain would have no reason to ever ship crt1.o would it? (since it would always be ignored?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. In D89274#211 , @sunfish wrote: > It's to ensure that older LLVM works with newer WASI libc, and newer clang > works with older WASI libc. New-style commands require [lld support]. We can > assume that if clang is updated, lld

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Ok so we can see this as an interm thing. I think I'm OK with that. Could you add a comment about that, or at least say why we want to support both the old crt1 and the new crt1-command at t

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

sbc100 added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external This seems to break if the pathname where the llvm checkout lives contains the word "external" https://logs.chrom

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

sbc100 added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external tra wrote: > yaxunl wrote: > > sbc100 wrote: > > > This seems to break if the pathname where the llvm checkout live

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 created this revision. Herald added subscribers: wingo, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This means `max_align_t` is 8 bytes which also sets the alignment malloc. Since this is technically and

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. @sunfish what do you think about doing this for all WebAssembly targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104808/new/ https://reviews.llvm.org/D104808 ___ cfe-commits

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. In D104808#2836991 , @kripken wrote: > In D104808#2836942 , @sunfish wrote: > >> Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or >> wasm32-wasi eventually? This

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1138 + +Ops[0] = TableSet; // The new chain is the TableSet itself + } I was expecting to see a TABLE_SET back to a null after the call here to avoid the GC ro

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a96e906cc0: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes (authored by sbc100). Changed prior to commit: https://reviews.llv

[PATCH] D113435: [Clang][Emscripten]: Don't default to -fvisibility=hidden

sbc100 created this revision. Herald added subscribers: wingo, sunfish, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Emscripten wants `-fvisibility=default` by default. See: https://github.com/emscripten-core/ems

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328522. sbc100 added a comment. Herald added a project: libc++. Herald added a reviewer: libc++. Rebase against mono-repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328524. sbc100 added a comment. Herald added a subscriber: mgorny. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libc

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16 #include +#include curdeius wrote: > This doesn't seem to be necessary. Or? > In C++, `alignof` is a keyword. You are right its not necessary in C++ sin

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined curdeius wrote: > You should test that each of these macros is really defined when including > `cstdalign`. Done.

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328538. sbc100 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/incl

[PATCH] D46443: Add missing cstdalign header

sbc100 marked 2 inline comments as done. sbc100 added inline comments. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28 +#ifdef alignas +#error alignas should not be a macro in C++ +#endif + +#ifdef alignof +#error alignof should not be a macro in C

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328557. sbc100 marked 2 inline comments as done. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328561. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/inclu

[PATCH] D46443: [libc++] Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > This seems to be assuming that the underlying C library's `stdalign.h` is C++ > friendly. A C11 `stdalign.h` //does// define `

[PATCH] D46443: [libc++] Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > curdeius wrote: > > > > curdeius wrote: > > > > > hubert.reinterpretcas

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. I'm not totally sure but I think the change is responsible for the emscripten integration bot failing `InterpreterTest.CatchException`: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8807160007692150337/+/u/LLVM_regression/stdout [===

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. In D130788#3731232 , @sunho wrote: > In D130788#3730533 , @sbc100 wrote: > >> I'm not totally sure but I think the change is responsible for the >> emscripten integration bot failing `Inte

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sbc100 added a comment. https://chromium-review.googlesource.com/c/emscripten-releases/+/3842345... I suppose the alternative would be to keep the backup method that was previously working in our case (but not in yours)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

sbc100 added a comment. Emscripten-side change in preparation for this to land: https://github.com/emscripten-core/emscripten/pull/17689 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125728/new/ https://reviews.llvm.org/D125728 __

[PATCH] D131217: [WIP][clang][WebAssembly] Pass `-Wl, -no-type-check` through to the MC layer

sbc100 added a comment. ptal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 updated this revision to Diff 454122. sbc100 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

sbc100 updated this revision to Diff 454128. sbc100 added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clan

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. At least for WebAssembly object files, it looks like the symbol table now contains (what look like) demangled symbols. e.g.: $ llvm-nm /tmp/emscripten_temp/command_0.o 3ef5 D __odr_asan_gen__numargs 41a6 D __odr_asan_gen__stdcmd<1068>::init 41c3 D __

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. > The asan instrumentation just prepends `__odr_asan_gen_` to the symbol name > to form a new symbol name. For ELF every byte except `\0` can be used in a > symbol name, and this is totally fine. > > I am unfamiliar with WebAssembly. Does the aforementioned parsing tool

[PATCH] D142740: [WIP] [WebAssembly] Enable MemorySanitizer for emscripten

sbc100 created this revision. Herald added subscribers: Enna1, pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added pr

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

sbc100 created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Remove the `hasPrototype()` r

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

sbc100 updated this revision to Diff 437272. sbc100 edited the summary of this revision. sbc100 added a comment. Herald added a subscriber: asb. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127888/new/ https://reviews.llvm.org/D127888 F

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78747bd39af8: [clang][WebAssembly] Loosen restriction on `main` symbol mangling (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433138. sbc100 added a comment. Herald added subscribers: llvm-commits, asb, hiraditya. Herald added a project: LLVM. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D7

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added a comment. Currently waiting on https://github.com/emscripten-core/emscripten/pull/17099 to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 __

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433173. sbc100 added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp llvm/l

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:264 - } -} } sunfish wrote: > Why is this code going away? This isn't Emscripten-specific code. Ah.. I was hoping we could delete these codepaths,

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433191. sbc100 added a comment. - revert parts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sunfish wrote: > Can this use `GA->setVisibility(GlobalValue::Hi

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sunfish wrote: > sbc100 wrote: > > sunfish wrote: > > > Can this

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433386. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp Inde

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 434605. sbc100 added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp Index:

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sbc100 wrote: > sunfish wrote: > > sbc100 wrote: > > > sunfish w

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47039a1a4b29: [WebAssembly] Remove restriction on main name mangling (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 added a comment. I think we are vearing into somewhat uncharted territory here, but we should probably push forward and document the direction we choose. Should `-shared` modules also link with `crt1-reactor.o` by default then? Or should we add `crt1-shared.o` and use the whenever `-sh

[PATCH] D156205: wasm: link crt1 even in case of -shared

This revision was automatically updated to reflect the committed changes. Closed by commit rG989ce069a463: [clang][WebAssembly] Link crt1 even in case of -shared (authored by yamt, committed by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D156205: [clang][WebAssembly] Link crt1 even in case of -shared

sbc100 added a comment. (update change title to use the `[clang][WebAssembly]`convention) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 ___ cfe-commits mailin

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories">, G

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added a comment. In D158409#4603829 , @tlively wrote: > The other file to update here is clang/test/Driver/wasm-features.c. It looks > like we haven't been as consistent about updating that one. Darn it, you beat be by 2 minutes. Repository:

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

sbc100 added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

sbc100 added a comment. Very nice idea! Comment at: clang/lib/Interpreter/CMakeLists.txt:21 Value.cpp + WASM.cpp Elsewhere in LLVM either use WebAssembly (spelled out). If you really prefer to keep it short you should use `Wasm` (not all caps). Also,

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

sbc100 added a comment. I suppose you could build a similar thing that runs under node and uses that `wasi-unknown-unknown` target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158140/new/ https://reviews.llvm.org/D158140 ___

<    1   2   3   4   >