sbc100 marked an inline comment as done.
sbc100 added inline comments.
================
Comment at: lld/wasm/Writer.cpp:478
+ toString(*sym) + "`. Use --no-check-features to suppress.");
+ else if (sym->isExported())
+ error(Twine("mutable global exported but 'mutable-globals' feature
"
----------------
tlively wrote:
> could this `if (sym->isExported())` be turned into an
> `assert(sym->isExported())`?
I don't think so. What about regular internal globals that are neither
imported nor exported? Unless I'm missing something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87537/new/
https://reviews.llvm.org/D87537
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
