[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread Saleem Abdulrasool via cfe-commits
@@ -46,6 +46,9 @@ typedef struct { /** * Retrieve the character data associated with the given string. + * + * The caller shouldn't free the returned string data, and the returned string + * data shouldn't be accessed after the \c CXString disposed. compnerd

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-09 Thread Saleem Abdulrasool via cfe-commits
@@ -46,6 +46,9 @@ typedef struct { /** * Retrieve the character data associated with the given string. + * + * The caller shouldn't free the returned string data, and the returned string + * data shouldn't be accessed after the \c CXString disposed. compnerd

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-02-03 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/125384 >From 33f361fda5b27964037c061d7944c01d3891d914 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Sat, 1 Feb 2025 15:04:04 -0800 Subject: [PATCH] CodeGen: support static linking for libclosure When buildi

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-02-03 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: The other way works with warnings and some performance loss and code bloat (linking code designed for DLL as static). So far I've always mandated dynamic linking for BlocksRuntime on Windows within the Swift toolchain and by the Swift toolchain. You are correct that the `-stat

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-02-03 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: I can see that as being useful certainly. `-fblocks` could add `-lBlocksRuntime`. However, I think that the behaviour change with `-static-libclosure` would then impact both code generation (on Windows) and the linking, which would give the correct desired behaviour. Where as,

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-02-05 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/125384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake][MSVC] Install PDBs alongside executables (PR #126675)

2025-02-10 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/126675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b798679 - test: correct a typo in the check identifier (NFCI)

2025-02-01 Thread Saleem Abdulrasool via cfe-commits
Author: Saleem Abdulrasool Date: 2025-02-01T14:49:29-08:00 New Revision: b798679c076af4acaa806e893b038372f5954298 URL: https://github.com/llvm/llvm-project/commit/b798679c076af4acaa806e893b038372f5954298 DIFF: https://github.com/llvm/llvm-project/commit/b798679c076af4acaa806e893b038372f5954298.

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-02-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd created https://github.com/llvm/llvm-project/pull/125384 When building on Windows, dealing with the BlocksRuntime is slightly more complicated. As we are not guaranteed a formward declaration for the blocks runtime ABI symbols, we may generate the declarations for t

[clang] Allow 'inline' on some declarations in MS compatibility mode (PR #125250)

2025-01-31 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/125250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/119090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-12 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: I'll go ahead and merge the change on your behalf as I suspect that you do not have commit rights as this is your first PR to the project. Thank you for the contribution! https://github.com/llvm/llvm-project/pull/119090 ___ cfe-commit

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/119090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Avoid assertion failure with expensive checks (PR #120487)

2024-12-18 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/120487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][APINotes] Do not add duplicate lifetimebound annotation (PR #117194)

2024-11-21 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/117194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2025-01-08 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/119403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix a cmake error when using the Xcode generator. (PR #119403)

2025-01-08 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: (waiting to see if Aaron can also take a look) https://github.com/llvm/llvm-project/pull/119403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-10 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/122516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-10 Thread Saleem Abdulrasool via cfe-commits
@@ -19493,7 +19493,11 @@ void Sema::ActOnFields(Scope *S, SourceLocation RecLoc, Decl *EnclosingDecl, CDecl->setIvarRBraceLoc(RBrac); } } - ProcessAPINotes(Record); + + // If this is a class template instantiation, its API Notes attributes were + // added to the

[clang] [APINotes] Avoid duplicated attributes for class template instantiations (PR #122516)

2025-01-15 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/122516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Headers: prefer `corecrt_malloc.h` to `malloc.h` (PR #131668)

2025-03-17 Thread Saleem Abdulrasool via cfe-commits
@@ -13,7 +13,7 @@ #include #ifdef _WIN32 -#include +#include compnerd wrote: Thanks for the typo correction! I think that I can add in a `!defined(__MINGW32__)` condition. https://github.com/llvm/llvm-project/pull/131668 _

[clang] Headers: prefer `corecrt_malloc.h` to `malloc.h` (PR #131668)

2025-03-17 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/131668 >From 8415be6e59aa2f8a23a3e484b1c8053f4d0c7206 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 17 Mar 2025 13:31:05 -0700 Subject: [PATCH] Headers: prefer `corecrt_malloc.h` to `malloc.h` This all

[clang] Headers: prefer `corecrt_malloc.h` to `malloc.h` (PR #131668)

2025-03-17 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd created https://github.com/llvm/llvm-project/pull/131668 This allows us to target a lower level library (corecrt) rather than the higher level library (ucrt) which can be helpful in mordularising the SDK. >From f8dea4c8a85c018a3c7ef5eadd00f2da96fe1737 Mon Sep 17 00:

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-27 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: > > I wonder if we can do this check statically instead. > > I'm not sure I follow, what do you mean by "statically" in this context? Well, if this is less about ensuring the loader does the right thing and more about the encoding, we could simply check that the value for `DT_R

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-26 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. I wonder if we can do this check statically instead. https://github.com/llvm/llvm-project/pull/137411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] Silence -Wcast-function-type warnings on idiomatic Windows code (PR #135660)

2025-04-14 Thread Saleem Abdulrasool via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 %s -triple x86_64-windows -fsyntax-only -Wcast-function-type -Wno-cast-function-type-strict -verify=windows +// RUN: %clang_cc1 %s -triple x86_64-windows -fsyntax-only -Wcast-function-type -Wno-cast-function-type-strict -x c++ -verify=windows

[clang] [APINotes] Add support for SWIFT_RETURED_AS_UNRETAINED_BY_DEFAULT (PR #138699)

2025-05-06 Thread Saleem Abdulrasool via cfe-commits
@@ -624,6 +624,13 @@ class TagTableInfo ReleaseOpLength - 1); Data += ReleaseOpLength - 1; } +unsigned DefaultOwnershipLength = +endian::readNext(Data); +if (DefaultOwnershipLength > 0) { compner

[clang] CodeGen: support static linking for libclosure (PR #125384)

2025-03-08 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: @steakhal bleh, is the "New Features" a sub item of "Static Analyzer"? https://github.com/llvm/llvm-project/pull/125384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-13 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: > > Take the opportunity to tighten up the code slightly by ensuring that we do > > not access out-of-bounds characters when lexing the token. > > That's a nice touch :-) 😄 > Do we already have tests somewhere checking that we can codegen this, or do > we need to add that? I

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-13 Thread Saleem Abdulrasool via cfe-commits
@@ -13,16 +13,24 @@ __int64 w = 0x43ui64; __int64 z = 9Li64; // expected-error {{invalid suffix}} __int64 q = 10lli64; // expected-error {{invalid suffix}} -__complex double c1 = 1i; -__complex double c2 = 1.0i; +__complex double c1 = 1i; // GNU extension +__complex double c

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-13 Thread Saleem Abdulrasool via cfe-commits
@@ -3924,10 +3924,18 @@ ExprResult Sema::ActOnNumericConstant(const Token &Tok, Scope *UDLScope) { // to get the integer value from an overly-wide APInt is *extremely* // expensive, so the naive approach of assuming // llvm::IntegerType::MAX_INT_BITS is a big perfo

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-13 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: New version also includes the release notes for this. https://github.com/llvm/llvm-project/pull/130993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-13 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/130993 >From 1021d05a73cb990bcbdd1948fd372fdf4b1a21ec Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Wed, 12 Mar 2025 09:52:58 -0700 Subject: [PATCH] Lex: add support for `i128` and `ui128` suffixes Microsof

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/130993 >From ba82162bbc75ab6838f2c1aa0ad89cfe585a578f Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Wed, 12 Mar 2025 09:52:58 -0700 Subject: [PATCH] Lex: add support for `i128` and `ui128` suffixes Microsof

[clang] Lex: add support for `i128` and `ui128` suffixes (PR #130993)

2025-03-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd created https://github.com/llvm/llvm-project/pull/130993 Microsoft's compiler supports an extension for 128-bit literals. This is referenced in `intsafe.h` which is included transitievly. When building with modules, the literal parsing causes a failure due to the mi

[clang] [Clang][CMake][MSVC] Install PDBs alongside executables (PR #126961)

2025-02-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/126961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Headers: prefer `corecrt_malloc.h` to `malloc.h` (PR #131668)

2025-04-03 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: I don't think that this fully fixes the issue as it doesn't completely break the cycle. https://github.com/llvm/llvm-project/pull/131668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-14 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: The patch is meant to support the following pattern (which IMO is actually the proper way to deal with the path canonicalisation): ```cmd subst X: %UserProfile%\SourceCache X: cmake -B X:\b -G Ninja -S llvm-project\llvm ninja -C \b ``` Everything is being built in `S:`, there i

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-14 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/139938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] properly guard dump methods in Support lib classes (PR #139938)

2025-05-14 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/139938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    6   7   8   9   10   11