Author: Reid Kleckner
Date: 2019-11-22T11:28:42-08:00
New Revision: e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9
URL:
https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9
DIFF:
https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9.diff
Author: Reid Kleckner
Date: 2019-11-22T15:47:46-08:00
New Revision: 2692eb0b86c8f7ae1299d2e032f2778bb6e0a224
URL:
https://github.com/llvm/llvm-project/commit/2692eb0b86c8f7ae1299d2e032f2778bb6e0a224
DIFF:
https://github.com/llvm/llvm-project/commit/2692eb0b86c8f7ae1299d2e032f2778bb6e0a224.diff
Author: Reid Kleckner
Date: 2019-11-22T16:06:30-08:00
New Revision: a9cc64e50e64e76151679780f0ace11b48eadd44
URL:
https://github.com/llvm/llvm-project/commit/a9cc64e50e64e76151679780f0ace11b48eadd44
DIFF:
https://github.com/llvm/llvm-project/commit/a9cc64e50e64e76151679780f0ace11b48eadd44.diff
Author: Reid Kleckner
Date: 2019-11-22T16:16:10-08:00
New Revision: 019779dadfd7c98aedf0072d604ace295be6fa62
URL:
https://github.com/llvm/llvm-project/commit/019779dadfd7c98aedf0072d604ace295be6fa62
DIFF:
https://github.com/llvm/llvm-project/commit/019779dadfd7c98aedf0072d604ace295be6fa62.diff
Author: Reid Kleckner
Date: 2019-12-02T15:05:50-08:00
New Revision: 536cedaecbe586ec9cf86d5102872adc27e6ea23
URL:
https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23
DIFF:
https://github.com/llvm/llvm-project/commit/536cedaecbe586ec9cf86d5102872adc27e6ea23.diff
Author: Reid Kleckner
Date: 2019-12-03T14:46:32-08:00
New Revision: 705a6aef350246c790ff8e73864dd27a640c59c8
URL:
https://github.com/llvm/llvm-project/commit/705a6aef350246c790ff8e73864dd27a640c59c8
DIFF:
https://github.com/llvm/llvm-project/commit/705a6aef350246c790ff8e73864dd27a640c59c8.diff
Author: Soumi Manna
Date: 2019-12-04T14:39:41-08:00
New Revision: 9c29aed6980dce42f2a071db09663c435ac21ad1
URL:
https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1
DIFF:
https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1.diff
L
Author: Reid Kleckner
Date: 2019-12-05T16:24:24-08:00
New Revision: 1f822f212cde1ad9099cf45af0652a83380de772
URL:
https://github.com/llvm/llvm-project/commit/1f822f212cde1ad9099cf45af0652a83380de772
DIFF:
https://github.com/llvm/llvm-project/commit/1f822f212cde1ad9099cf45af0652a83380de772.diff
Author: Reid Kleckner
Date: 2019-12-06T15:30:49-08:00
New Revision: 60573ae6fe509b618dc6a2c5c55d921bccd77608
URL:
https://github.com/llvm/llvm-project/commit/60573ae6fe509b618dc6a2c5c55d921bccd77608
DIFF:
https://github.com/llvm/llvm-project/commit/60573ae6fe509b618dc6a2c5c55d921bccd77608.diff
Author: Reid Kleckner
Date: 2019-12-06T15:42:14-08:00
New Revision: eff08f40976e177923fe95759917e59375458f71
URL:
https://github.com/llvm/llvm-project/commit/eff08f40976e177923fe95759917e59375458f71
DIFF:
https://github.com/llvm/llvm-project/commit/eff08f40976e177923fe95759917e59375458f71.diff
Author: Reid Kleckner
Date: 2019-12-09T13:08:44-08:00
New Revision: 1164d43855fd5b58fde221445ab0e407c0bd92ee
URL:
https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee
DIFF:
https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee.diff
Author: Reid Kleckner
Date: 2019-12-09T16:17:18-08:00
New Revision: 9803178a78c1858b0ac868c2cdf402cec5a10db9
URL:
https://github.com/llvm/llvm-project/commit/9803178a78c1858b0ac868c2cdf402cec5a10db9
DIFF:
https://github.com/llvm/llvm-project/commit/9803178a78c1858b0ac868c2cdf402cec5a10db9.diff
Author: Reid Kleckner
Date: 2019-12-11T18:02:14-08:00
New Revision: 5d986953c8b917bacfaa1f800fc1e242559f76be
URL:
https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be
DIFF:
https://github.com/llvm/llvm-project/commit/5d986953c8b917bacfaa1f800fc1e242559f76be.diff
Author: Reid Kleckner
Date: 2019-12-18T13:47:00-08:00
New Revision: 71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a
URL:
https://github.com/llvm/llvm-project/commit/71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a
DIFF:
https://github.com/llvm/llvm-project/commit/71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a.diff
Author: Reid Kleckner
Date: 2019-12-22T12:54:06-08:00
New Revision: 891e25b02d760d0de18c7d46947913b3166047e7
URL:
https://github.com/llvm/llvm-project/commit/891e25b02d760d0de18c7d46947913b3166047e7
DIFF:
https://github.com/llvm/llvm-project/commit/891e25b02d760d0de18c7d46947913b3166047e7.diff
Author: Reid Kleckner
Date: 2019-12-22T19:00:48-08:00
New Revision: 5128026467cbc17bfc796d94bc8e40e52a9b0752
URL:
https://github.com/llvm/llvm-project/commit/5128026467cbc17bfc796d94bc8e40e52a9b0752
DIFF:
https://github.com/llvm/llvm-project/commit/5128026467cbc17bfc796d94bc8e40e52a9b0752.diff
Author: Arthur Eubanks
Date: 2020-03-05T15:17:06-08:00
New Revision: cfff4851acc5132c8dcaebca6af92f817e133d66
URL:
https://github.com/llvm/llvm-project/commit/cfff4851acc5132c8dcaebca6af92f817e133d66
DIFF:
https://github.com/llvm/llvm-project/commit/cfff4851acc5132c8dcaebca6af92f817e133d66.diff
Author: Reid Kleckner
Date: 2020-03-11T13:37:41-07:00
New Revision: c915cb957dc37275ce1ca1a0b993239c82f12692
URL:
https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692
DIFF:
https://github.com/llvm/llvm-project/commit/c915cb957dc37275ce1ca1a0b993239c82f12692.diff
Author: Reid Kleckner
Date: 2020-03-11T13:52:47-07:00
New Revision: 526a4f2ac365a5babbc80e0f7c17be310728a538
URL:
https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538
DIFF:
https://github.com/llvm/llvm-project/commit/526a4f2ac365a5babbc80e0f7c17be310728a538.diff
Author: Reid Kleckner
Date: 2020-03-11T13:53:12-07:00
New Revision: e08464fb450456881733c885267b32dc7339cf11
URL:
https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11
DIFF:
https://github.com/llvm/llvm-project/commit/e08464fb450456881733c885267b32dc7339cf11.diff
Author: Reid Kleckner
Date: 2020-03-11T15:45:34-07:00
New Revision: 213aea4c5836934771eb97eb97e4c964053a8596
URL:
https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596
DIFF:
https://github.com/llvm/llvm-project/commit/213aea4c5836934771eb97eb97e4c964053a8596.diff
Author: Reid Kleckner
Date: 2020-03-11T16:47:49-07:00
New Revision: d6497a521bbd4024ed39a384b44af5f4f4a81e05
URL:
https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05
DIFF:
https://github.com/llvm/llvm-project/commit/d6497a521bbd4024ed39a384b44af5f4f4a81e05.diff
Author: Reid Kleckner
Date: 2020-03-11T20:47:11-07:00
New Revision: d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0
URL:
https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0
DIFF:
https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0.diff
Author: Reid Kleckner
Date: 2020-03-11T21:05:20-07:00
New Revision: c4d23d8854840294bf49c524f93e2be85a401f00
URL:
https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00
DIFF:
https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00.diff
Author: Reid Kleckner
Date: 2020-03-12T09:07:57-07:00
New Revision: 7420f96924a3889af628c851ff1940aae614f3f3
URL:
https://github.com/llvm/llvm-project/commit/7420f96924a3889af628c851ff1940aae614f3f3
DIFF:
https://github.com/llvm/llvm-project/commit/7420f96924a3889af628c851ff1940aae614f3f3.diff
Author: Reid Kleckner
Date: 2020-03-12T11:54:31-07:00
New Revision: 26d254f084161f81f953cf3434e8d2ad9355b496
URL:
https://github.com/llvm/llvm-project/commit/26d254f084161f81f953cf3434e8d2ad9355b496
DIFF:
https://github.com/llvm/llvm-project/commit/26d254f084161f81f953cf3434e8d2ad9355b496.diff
Author: Reid Kleckner
Date: 2020-02-04T15:30:08-08:00
New Revision: 1091730f5fbb13c36e4099e765178c2d8fb7ba0c
URL:
https://github.com/llvm/llvm-project/commit/1091730f5fbb13c36e4099e765178c2d8fb7ba0c
DIFF:
https://github.com/llvm/llvm-project/commit/1091730f5fbb13c36e4099e765178c2d8fb7ba0c.diff
Author: Reid Kleckner
Date: 2020-02-11T16:49:28-08:00
New Revision: 2c6a3896ab1de706389f27c921cf58084650f439
URL:
https://github.com/llvm/llvm-project/commit/2c6a3896ab1de706389f27c921cf58084650f439
DIFF:
https://github.com/llvm/llvm-project/commit/2c6a3896ab1de706389f27c921cf58084650f439.diff
Author: Reid Kleckner
Date: 2020-02-13T11:57:00-08:00
New Revision: 0b2eaa373d12dacf58a72fd9e35ea6159a138647
URL:
https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647
DIFF:
https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647.diff
Author: Reid Kleckner
Date: 2020-02-13T12:51:06-08:00
New Revision: e3548e23657d6c4988f815e9c87350f53e48e783
URL:
https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783
DIFF:
https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783.diff
Author: Reid Kleckner
Date: 2020-02-18T12:59:50-08:00
New Revision: a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b
URL:
https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b
DIFF:
https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b.diff
Author: Reid Kleckner
Date: 2020-01-21T11:05:45-08:00
New Revision: f63d7637387995765e9ece0e10fe1b5a4f0612b5
URL:
https://github.com/llvm/llvm-project/commit/f63d7637387995765e9ece0e10fe1b5a4f0612b5
DIFF:
https://github.com/llvm/llvm-project/commit/f63d7637387995765e9ece0e10fe1b5a4f0612b5.diff
Author: Reid Kleckner
Date: 2020-01-23T16:04:00-08:00
New Revision: 2af74e27ed7d0832cbdde9cb969aaca7a42e99f9
URL:
https://github.com/llvm/llvm-project/commit/2af74e27ed7d0832cbdde9cb969aaca7a42e99f9
DIFF:
https://github.com/llvm/llvm-project/commit/2af74e27ed7d0832cbdde9cb969aaca7a42e99f9.diff
Author: Reid Kleckner
Date: 2020-01-24T13:42:28-08:00
New Revision: 8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082
URL:
https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082
DIFF:
https://github.com/llvm/llvm-project/commit/8a81daaa8b58aeaa192a47c4ce7f94b4d59ce082.diff
Author: Reid Kleckner
Date: 2020-01-24T17:35:39-08:00
New Revision: dd8e0a0a23bab23fee283145c599014bf4b450d3
URL:
https://github.com/llvm/llvm-project/commit/dd8e0a0a23bab23fee283145c599014bf4b450d3
DIFF:
https://github.com/llvm/llvm-project/commit/dd8e0a0a23bab23fee283145c599014bf4b450d3.diff
Author: Reid Kleckner
Date: 2020-01-24T17:48:38-08:00
New Revision: 0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1
URL:
https://github.com/llvm/llvm-project/commit/0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1
DIFF:
https://github.com/llvm/llvm-project/commit/0ebc8e6c42167ba049aef8d73cae7eb7a316c8a1.diff
Author: Reid Kleckner
Date: 2020-01-30T11:01:24-08:00
New Revision: af3e88495627c9b150814ff13e5749e1ed31c5d3
URL:
https://github.com/llvm/llvm-project/commit/af3e88495627c9b150814ff13e5749e1ed31c5d3
DIFF:
https://github.com/llvm/llvm-project/commit/af3e88495627c9b150814ff13e5749e1ed31c5d3.diff
Author: Reid Kleckner
Date: 2020-01-30T13:37:52-08:00
New Revision: 01943a59f51d8b5ede062305941c1f864b8a6a13
URL:
https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13
DIFF:
https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13.diff
Author: rnk
Date: Mon Mar 26 11:22:47 2018
New Revision: 328567
URL: http://llvm.org/viewvc/llvm-project?rev=328567&view=rev
Log:
[MS] Fix late-parsed template infinite loop in eager instantiation
Summary:
This fixes PR33561 and PR34185.
Don't store pending template instantiations for late-parse
Author: rnk
Date: Mon Mar 26 17:26:13 2018
New Revision: 328599
URL: http://llvm.org/viewvc/llvm-project?rev=328599&view=rev
Log:
Remove dead method
Modified:
cfe/trunk/include/clang/Basic/TargetCXXABI.h
Modified: cfe/trunk/include/clang/Basic/TargetCXXABI.h
URL:
http://llvm.org/viewvc/llvm
Author: rnk
Date: Tue Mar 27 10:44:12 2018
New Revision: 328645
URL: http://llvm.org/viewvc/llvm-project?rev=328645&view=rev
Log:
Attempt to fix clangd test on Windows by wildcarding drive letters
Modified:
clang-tools-extra/trunk/test/clangd/textdocument-didchange-fail.test
Modified: clang-
One of these new tests does not pass on Windows due to assumptions about
absolute path structure. The FileCheck output seems self-explanatory:
$ "FileCheck" "-strict-whitespace"
"C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\tools\extra\test\clangd\textdocument-
Author: rnk
Date: Wed Mar 28 11:23:35 2018
New Revision: 328723
URL: http://llvm.org/viewvc/llvm-project?rev=328723&view=rev
Log:
[MS] Fix bug in method vfptr location code
We were assuming that vbtable indices were assigned in layout order in
our comparison, which is not the case. When a virtual
Author: rnk
Date: Thu Mar 29 15:42:24 2018
New Revision: 328845
URL: http://llvm.org/viewvc/llvm-project?rev=328845&view=rev
Log:
Hoist MethodVFTableLocation out of MicrosoftVTableContext, NFC
This allows forward declaring it so that we can add it to
MicrosoftMangleContext::mangleVirtualMemPtrThu
Author: rnk
Date: Mon Apr 2 13:00:39 2018
New Revision: 329007
URL: http://llvm.org/viewvc/llvm-project?rev=329007&view=rev
Log:
Fix some DenseMap use-after-rehash bugs and hoist MethodVFTableLocation
This re-lands r328845 with fixes for crbug.com/827810.
The initial motiviation was to hoist Me
Author: rnk
Date: Mon Apr 2 13:20:33 2018
New Revision: 329009
URL: http://llvm.org/viewvc/llvm-project?rev=329009&view=rev
Log:
[MS] Emit vftable thunks for functions with incomplete prototypes
Summary:
The following class hierarchy requires that we be able to emit a
this-adjusting thunk for B:
On Wed, Oct 25, 2017 at 10:56 AM, Friedman, Eli
wrote:
> On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote:
>
>> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Too
>> lChains/Clang.cpp?rev=315126&r1=315125&r2=31512
On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli
wrote:
> Maybe we should just ignore -fno-short-wchar, instead? I think that's
> what gcc and released versions of clang do (that means -fno-short-wchar
> doesn't do anything for Windows targets, but that's probably fine).
>
No, the intention of t
Author: rnk
Date: Thu Oct 26 10:07:48 2017
New Revision: 316674
URL: http://llvm.org/viewvc/llvm-project?rev=316674&view=rev
Log:
Move MS inline asm parser methods out of line to reduce indentation, NFC
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm
Author: rnk
Date: Fri Oct 27 15:48:41 2017
New Revision: 316807
URL: http://llvm.org/viewvc/llvm-project?rev=316807&view=rev
Log:
[MS] Allow access to ambiguous, inaccessible direct bases
Summary:
Clang typically warns that in the following class hierarchy, 'A' is
inaccessible because there is no
Author: rnk
Date: Thu Nov 16 11:09:36 2017
New Revision: 318440
URL: http://llvm.org/viewvc/llvm-project?rev=318440&view=rev
Log:
[MS] Apply adjustments after storing 'this'
Summary:
The MS ABI convention is that the 'this' pointer on entry is the address
of the vfptr that was used to make the vi
Author: rnk
Date: Thu Nov 16 13:26:18 2017
New Revision: 318456
URL: http://llvm.org/viewvc/llvm-project?rev=318456&view=rev
Log:
Issue -Wempty-body warnings for else blocks
This looks like it was just an oversight.
Fixes http://llvm.org/pr35319
Modified:
cfe/trunk/include/clang/Basic/Diagn
Author: rnk
Date: Fri Nov 17 13:33:28 2017
New Revision: 318556
URL: http://llvm.org/viewvc/llvm-project?rev=318556&view=rev
Log:
Loosen -Wempty-body warning
Do not show it when `if` or `else` come from macros.
E.g.,
#define USED(A) if (A); else
#define SOME_IF(A) if (A)
void test()
Author: rnk
Date: Fri Nov 17 13:55:23 2017
New Revision: 318559
URL: http://llvm.org/viewvc/llvm-project?rev=318559&view=rev
Log:
Fix coverage test on Windows bot
Modified:
cfe/trunk/test/Driver/coverage.c
Modified: cfe/trunk/test/Driver/coverage.c
URL:
http://llvm.org/viewvc/llvm-project/c
Author: rnk
Date: Mon Nov 20 17:25:56 2017
New Revision: 318723
URL: http://llvm.org/viewvc/llvm-project?rev=318723&view=rev
Log:
[MS] Increase default new alignment for win64 and test it
Summary:
This raises __STDCPP_DEFAULT_NEW_ALIGNMENT__ from 8 to 16 on Win64.
This matches platforms that foll
Author: Reid Kleckner
Date: 2023-06-13T12:54:23-07:00
New Revision: 651e5ae62d29fdb07eb85f75ab7e686b98479f3a
URL:
https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a
DIFF:
https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a.diff
Author: rnk
Date: Wed Dec 14 11:44:11 2016
New Revision: 289678
URL: http://llvm.org/viewvc/llvm-project?rev=289678&view=rev
Log:
Improve our handling of tag decls in function prototypes
r289225 broke AST invariants by reparenting enumerators into function
decl contexts. This improves things by o
Author: rnk
Date: Fri Dec 16 16:11:28 2016
New Revision: 289997
URL: http://llvm.org/viewvc/llvm-project?rev=289997&view=rev
Log:
Really revert all changes from r289979. Apparently conflict resolution failed
Modified:
cfe/trunk/include/clang/Basic/OpenCLOptions.h
Modified: cfe/trunk/include/
This revert broke the build because you failed to resolve conflicts
in include/clang/Basic/OpenCLOptions.h caused by r289985. I've reverted
that file in r289997.
On Fri, Dec 16, 2016 at 1:23 PM, Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yaxunl
> Date: Fri Dec 16 15:
Author: rnk
Date: Fri Dec 16 17:44:44 2016
New Revision: 290009
URL: http://llvm.org/viewvc/llvm-project?rev=290009&view=rev
Log:
Fix MSVC build of libclang after r288438
Modified:
cfe/trunk/tools/libclang/CXType.cpp
Modified: cfe/trunk/tools/libclang/CXType.cpp
URL:
http://llvm.org/viewvc/
On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman
wrote:
> That change appears to have been lost, and I would like to see them
> brought back. I think they may have gotten lost during the rebase, as
> they were present in https://reviews.llvm.org/D26846?id=78569.
>
I removed the tablegen logic beca
I suspect this broke Win64:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/1410
On Mon, Dec 26, 2016 at 6:20 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Mon Dec 26 20:20:35 2016
> New Revision: 290569
>
> URL: http://llvm.o
This affected code generation of jump tables from switches. This was the
assembly difference for a switch when going from PIC to static:
$ cat t.cpp
void g(int);
void f(int x) {
switch (x) {
case 0: g(0); break;
case 1: g(1); break;
case 2: g(2); break;
case 3: g(3); break;
case 4: g(4
I filed https://llvm.org/bugs/show_bug.cgi?id=31488 for this.
On Wed, Dec 28, 2016 at 9:37 AM, Reid Kleckner wrote:
> This affected code generation of jump tables from switches. This was the
> assembly difference for a switch when going from PIC to static:
>
> $ cat t.cpp
> void g(int);
> void f
Author: rnk
Date: Wed Dec 28 11:41:36 2016
New Revision: 290672
URL: http://llvm.org/viewvc/llvm-project?rev=290672&view=rev
Log:
Revert "Driver: switch Windows to static RelocModel"
This reverts commit r290569. It caused unforeseen codegen changes for
switch jump tables described in PR31488.
Mo
Author: rnk
Date: Tue Jan 3 15:23:35 2017
New Revision: 290906
URL: http://llvm.org/viewvc/llvm-project?rev=290906&view=rev
Log:
[Win64] Don't widen integer literal zero arguments to unprototyped function
calls
The special case to widen the integer literal zero when passed to
variadic function
Author: rnk
Date: Tue Jan 3 15:29:51 2017
New Revision: 290907
URL: http://llvm.org/viewvc/llvm-project?rev=290907&view=rev
Log:
Relax CHECK line from r290906
Modified:
cfe/trunk/test/CodeGen/variadic-null-win64.c
Modified: cfe/trunk/test/CodeGen/variadic-null-win64.c
URL:
http://llvm.org/
Author: rnk
Date: Wed Jan 4 12:16:32 2017
New Revision: 290979
URL: http://llvm.org/viewvc/llvm-project?rev=290979&view=rev
Log:
Accept and ignore -Wa,-mbig-obj on COFF targets for gas compatibility
LLVM's integrated assembler will automatically switch to big objects
when there are more than 2**
Author: rnk
Date: Wed Jan 4 12:50:51 2017
New Revision: 290984
URL: http://llvm.org/viewvc/llvm-project?rev=290984&view=rev
Log:
Use -### so the mbig-obj.c test passes when there is no registered x86 target
Modified:
cfe/trunk/test/Driver/mbig-obj.c
Modified: cfe/trunk/test/Driver/mbig-obj.
Author: rnk
Date: Wed Jan 4 13:15:53 2017
New Revision: 290990
URL: http://llvm.org/viewvc/llvm-project?rev=290990&view=rev
Log:
Support -fno-delayed-template-parsing in clang-cl.exe
Summary:
This change adds support for the -fno-delayed-template-parsing option in
clang-cl.exe. This allows devel
Author: rnk
Date: Wed Jan 4 19:08:22 2017
New Revision: 291045
URL: http://llvm.org/viewvc/llvm-project?rev=291045&view=rev
Log:
[MS] Instantiate default args during instantiation of exported default ctors
Summary:
Replace some old code that probably pre-dated the change to delay
emission of dll
cuda-version-check.cu seems to be failing since this change:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1768
The relevant failing part:
$
"C:/b/slave/clang-x86-windows-msvc2015/clang-x86-windows-msvc2015/stage1/./bin/clang.EXE"
"-v" "-###" "--cuda-gpu-arch=sm_60"
"--sysro
Author: rnk
Date: Fri Jan 6 12:16:03 2017
New Revision: 291255
URL: http://llvm.org/viewvc/llvm-project?rev=291255&view=rev
Log:
[CUDA] Add a host target triple to cuda-version-check.cu
It passes --sysroot for the Linux CUDA installation. To make this test
pass when targetting Windows, you would
Author: rnk
Date: Mon Jan 9 11:09:59 2017
New Revision: 291450
URL: http://llvm.org/viewvc/llvm-project?rev=291450&view=rev
Log:
Follow up to r291448: use isStructorDecl in one more place
This pointer comparison has shown to be error-prone, so use the standard
helper for it. NFC
Modified:
c
Author: rnk
Date: Mon Jan 9 11:04:37 2017
New Revision: 291448
URL: http://llvm.org/viewvc/llvm-project?rev=291448&view=rev
Log:
[MS] Fix function type mangling of default ctor closures
Use the canonical decl in pointer comparisons with the default
constructor closure decl. Otherwise we don't pr
Author: rnk
Date: Mon Jan 9 11:25:30 2017
New Revision: 291452
URL: http://llvm.org/viewvc/llvm-project?rev=291452&view=rev
Log:
Split dllexport default constructor closure tests out into a separate file
test/CodeGenCXX/dllexport.cpp has grown quite large at this point. NFC
Added:
cfe/trunk
Author: rnk
Date: Mon Jan 9 11:27:17 2017
New Revision: 291453
URL: http://llvm.org/viewvc/llvm-project?rev=291453&view=rev
Log:
[MS] Mark default args of exported default constructors as used
Fixes a regression introduced in r291045, which would lead to link
errors. While we should no longer en
This appears to have broken the Chromium build:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/12620/steps/gclient%20runhooks/logs/stdio
FAILED: projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/chrono.cpp.o
/Applications/Xcode8.0.app/Contents/Developer/Toolchains/XcodeDe
Author: rnk
Date: Tue Jan 10 15:27:03 2017
New Revision: 291600
URL: http://llvm.org/viewvc/llvm-project?rev=291600&view=rev
Log:
Serialize the UsesSEH bit on FunctionDecl
Fixes PR31539
Added:
cfe/trunk/test/PCH/uses-seh.cpp
Modified:
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
cfe
rnk accepted this revision.
rnk added a comment.
lgtm
Comment at: clang/include/clang/Sema/Sema.h:9162
@@ -9161,1 +9161,3 @@
+ /// Check whether we're allowed to call Callee from the current context.
+ ///
FWIW I never insert doxygen annotations. I figure if
rnk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689
@@ -1687,3 +1687,4 @@
- if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())
+ if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() &&
+ !CXXDecl->hasAttr())
return true;
Author: rnk
Date: Tue Aug 16 11:04:14 2016
New Revision: 278814
URL: http://llvm.org/viewvc/llvm-project?rev=278814&view=rev
Log:
Revert "[X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to non-windows
platforms"
This reverts commit r278783. It breaks usage of _xgetbv on Windows.
Modified:
Reverted in r278814, it appears to break usage of _xgetbv on Windows:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dll%29/builds/5846/steps/compile/logs/stdio
../../base/cpu.cc(194,10): error: use of undeclared identifier '_xgetbv'
(_xgetbv(0) & 6) == 6 /* XSAVE enabled
Author: rnk
Date: Tue Aug 16 11:07:46 2016
New Revision: 278815
URL: http://llvm.org/viewvc/llvm-project?rev=278815&view=rev
Log:
Remove most instances of REQUIRES: shell from the tools/extra tests
None of these tests actually require bash, they just have quoting bugs
when paths contain backslash
rnk added a subscriber: rnk.
rnk added a comment.
Reverted in r278814, it appears to break usage of _xgetbv on Windows:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dll%29/builds/5846/steps/compile/logs/stdio
../../base/cpu.cc(194,10): error: use of undeclared identifier '_xge
Author: rnk
Date: Tue Aug 16 15:20:56 2016
New Revision: 278842
URL: http://llvm.org/viewvc/llvm-project?rev=278842&view=rev
Log:
Try to work around an MSVC 2013 bug around defaulted default ctors
An UnresolvedSetIterator() is supposed to be zeroed out, but MSVC 2013
does not do that.
Modified:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
The source isn't that interesting, it includes intrin.h and immintrin.h before
using _xgetbv.
I think the issue is that Nico added the _MSC_VER check to intrin.h in
http://reviews.llvm.org/D20291:
#if !defined(_MSC_VER) || __has_feature(modules) || defined(__XSAVE__)
#incl
rnk added a comment.
So, I actually went ahead and generated some MSYS makefiles and made a
compile_commands.json, and it doesn't work with clang-tidy. You get this kind
of output:
[
{
"directory": "C:/src/test_proj",
"command": "\"/C/Program
Files/mingw-w64/x86_64-6.1.0-win32-seh-
rnk added a comment.
Hm, resending my comments because it doesn't appear to work from email. I swear
it used to...
In https://reviews.llvm.org/D21959#519179, @guyblank wrote:
> Still, __XSAVE__ should have been defined when compiling for a target that
> supports the feature.
That's not how M
Clang isn't allowed to use LLVM's config.h, though, specifically to support
the standalone build.
You can either create equivalent LLVM_ prefixed macros in
llvm-config.h.cmake, or repeat the checks and define the same macros in
clang/include/clang/Config/config.h.cmake.
On Thu, Aug 18, 2016 at 9:
Author: rnk
Date: Thu Aug 18 13:45:07 2016
New Revision: 279116
URL: http://llvm.org/viewvc/llvm-project?rev=279116&view=rev
Log:
[MS] Silence -Wextern-init on const selectany variables
In C, 'extern' is typically used to avoid tentative definitions when
declaring variables in headers, but adding
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Thu Aug 25 13:23:28 2016
New Revision: 279764
URL: http://llvm.org/viewvc/llvm-project?rev=279764&view=rev
Log:
[MS] Pass non-trivially-copyable objects indirectly on Windows ARM
This isn't exactly what MSVC does, unfortunately. MSVC does not pass
objects with destructors but no
Author: rnk
Date: Thu Aug 25 15:40:23 2016
New Revision: 279772
URL: http://llvm.org/viewvc/llvm-project?rev=279772&view=rev
Log:
Fix clang-offload-bundler.c test on Windows
Modified:
cfe/trunk/test/Driver/clang-offload-bundler.c
Modified: cfe/trunk/test/Driver/clang-offload-bundler.c
URL:
This test failed on Windows because clang is called "clang.exe" not
"clang". Fixed in r279772.
On Wed, Aug 24, 2016 at 8:21 AM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Wed Aug 24 10:21:05 2016
> New Revision: 279632
>
> URL: http://llvm.org/view
Author: rnk
Date: Thu Aug 25 15:42:26 2016
New Revision: 279774
URL: http://llvm.org/viewvc/llvm-project?rev=279774&view=rev
Log:
[MS] Win64 va_arg should expect large arguments to be passed indirectly
Fixes PR20569
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
cfe/trunk/test/CodeGen/ms
Author: rnk
Date: Thu Aug 25 17:16:30 2016
New Revision: 279786
URL: http://llvm.org/viewvc/llvm-project?rev=279786&view=rev
Log:
Widen type of __offset_flags in RTTI on Mingw64
Otherwise we can't handle secondary base classes at offsets greater than
2**24. This agrees with libstdc++abi.
We coul
rnk added a comment.
I think these are known as "IDL attributes":
https://msdn.microsoft.com/en-us/library/8tesw2eh.aspx
Let's update the naming to use that terminology, so AS_MS should be AS_IDL, and
MaybeParseMicrosoftAttributes should be MaybeParseMicrosoftIDLAttributes, etc.
Also, doesn't t
rnk added a comment.
Now might be the time to solve the larger problem of wider intrinsic
availability. Like I mentioned, all these intrinsics really ought to be
available all the time, regardless of CPU subtarget.
Repository:
rL LLVM
https://reviews.llvm.org/D21959
_
501 - 600 of 1542 matches
Mail list logo