Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

[Reid Kleckner via cfe-commits]

rnk added a comment.

I think these are known as "IDL attributes":
https://msdn.microsoft.com/en-us/library/8tesw2eh.aspx

Let's update the naming to use that terminology, so AS_MS should be AS_IDL, and 
MaybeParseMicrosoftAttributes should be MaybeParseMicrosoftIDLAttributes, etc.

Also, doesn't this introduce ambiguities into the grammar? Something like this:

  void useit(int);
  int main() {
    int uuid = 42;
    [uuid]() {
      useit(uuid);
    }();
  }

Will we keep parsing that as a lambda after this change or not?


https://reviews.llvm.org/D23895



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits