@@ -32,6 +32,14 @@
// CHECK-LTO: "-o" "obj/dir{{/|}}save-stats.exe"
// CHECK-LTO: "-plugin-opt=stats-file=save-stats.stats"
+
+// RUN: %clang --target=powerpc-unknown-aix -save-stats -flto -o
obj/dir/save-stats %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-AIX-LTO
+//
https://github.com/qiongsiwu approved this pull request.
LGTM! Thanks so much!
https://github.com/llvm/llvm-project/pull/71738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu approved this pull request.
LGTM! Thanks Jake!
https://github.com/llvm/llvm-project/pull/72304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/76471
This PR exposes three PGO functions `__llvm_profile_reset_counters`,
`__llvm_profile_dump` and `__llvm_orderfile_dump` to user programs through the
new header `instr_prof_interface.h` under `compiler-rt/includ
qiongsiwu wrote:
Note to reviewers: I am only adding these three PGO functions because I am not
sure if more should be added. Please let me know, and I will revise the PR.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
c
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 1/5] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,6 +44,7 @@ endif(COMPILER_RT_BUILD_ORC)
if (COMPILER_RT_BUILD_PROFILE)
set(PROFILE_HEADERS
profile/InstrProfData.inc
+profile/instr_prof_interface.h
qiongsiwu wrote:
Yes absolutely! That said, I am following the existing convention for interfa
@@ -100,12 +103,6 @@ ValueProfNode *__llvm_profile_begin_vnodes();
ValueProfNode *__llvm_profile_end_vnodes();
uint32_t *__llvm_profile_begin_orderfile();
-/*!
- * \brief Clear profile counters to zero.
- *
- */
-void __llvm_profile_reset_counters(void);
qiong
https://github.com/qiongsiwu commented:
Thanks so much @snehasish for the fast review! I have two questions regarding
your comments. I will address the remaining comments soon as well!
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits m
@@ -100,12 +103,6 @@ ValueProfNode *__llvm_profile_begin_vnodes();
ValueProfNode *__llvm_profile_end_vnodes();
uint32_t *__llvm_profile_begin_orderfile();
-/*!
- * \brief Clear profile counters to zero.
- *
- */
-void __llvm_profile_reset_counters(void);
qiong
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -100,12 +103,6 @@ ValueProfNode *__llvm_profile_begin_vnodes();
ValueProfNode *__llvm_profile_end_vnodes();
uint32_t *__llvm_profile_begin_orderfile();
-/*!
- * \brief Clear profile counters to zero.
- *
- */
-void __llvm_profile_reset_counters(void);
qiong
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 1/6] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
@@ -100,12 +103,6 @@ ValueProfNode *__llvm_profile_begin_vnodes();
ValueProfNode *__llvm_profile_end_vnodes();
uint32_t *__llvm_profile_begin_orderfile();
-/*!
- * \brief Clear profile counters to zero.
- *
- */
-void __llvm_profile_reset_counters(void);
qiong
qiongsiwu wrote:
> > @teresajohnson I mentioned the same thing on
> > [discourse](https://discourse.llvm.org/t/pgo-are-the-llvm-profile-functions-stable-c-apis-across-llvm-releases/75832/5)
> > but it seems like linking on AIX does not support this model.
>
> I see. Perhaps instead of defining
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 1/7] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,26 @@
+// RUN: %clang_profgen %s -S -emit-llvm -o - | FileCheck %s
--check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
+// RUN: llvm-profdata merge -o %t.profdata %t.profraw
+// RUN: %clang_profuse=%t.profdata %s -S
@@ -1364,12 +1364,22 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
TI.getTargetDefines(LangOpts, Builder);
}
+static void InitializePGOProfileMacros(const CodeGenOptions &CodeGenOpts,
qiongsiwu wrote:
This
[comment](https://discourse.llv
@@ -0,0 +1,26 @@
+// RUN: %clang_profgen %s -S -emit-llvm -o - | FileCheck %s
--check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
+// RUN: llvm-profdata merge -o %t.profdata %t.profraw
+// RUN: %clang_profuse=%t.profdata %s -S
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 1/8] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu commented:
@snehasish I appreciate your timely feedback! The latest commit aims at
addressing all the comments.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
@@ -1364,12 +1364,22 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
TI.getTargetDefines(LangOpts, Builder);
}
+static void InitializePGOProfileMacros(const CodeGenOptions &CodeGenOpts,
qiongsiwu wrote:
Got it! Thanks for the clarification!
@@ -0,0 +1,17 @@
+// RUN: %clang_pgogen -o %t %s
+// RUN: not %t
+// RUN: %clang -o %t %s
+// RUN: %t
+
+__attribute__((weak)) void __llvm_profile_reset_counters(void);
+
+__attribute__((noinline)) int bar() { return 4; }
+int foo() {
+ if (__llvm_profile_reset_counters) {
+_
@@ -1364,12 +1364,22 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
TI.getTargetDefines(LangOpts, Builder);
}
+static void InitializePGOProfileMacros(const CodeGenOptions &CodeGenOpts,
+ MacroBuilder &Builder) {
+ if (
@@ -12,6 +12,19 @@
#include "InstrProfilingPort.h"
#include
+// Make sure __LLVM_INSTR_PROFILE_GENERATE is always defined before
+// including instr_prof_interface.h so the interface functions are
+// declared correctly for the runtime. Additionally, make sure
+// that __LLVM
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 1/9] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/10] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/11] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
@@ -0,0 +1,92 @@
+/*=== instr_prof_interface.h - Instrumentation PGO User Program API ===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier: Apach
qiongsiwu wrote:
Comments added.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,38 @@
+// RUN: %clang_profgen %s --target=ppc64le-unknown-linux-gnu -S \
+// RUN:-emit-llvm -o - | FileCheck %s --check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
qiongsiwu wrote:
> Nevertheles
@@ -0,0 +1,38 @@
+// RUN: %clang_profgen %s --target=ppc64le-unknown-linux-gnu -S \
+// RUN:-emit-llvm -o - | FileCheck %s --check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
qiongsiwu wrote:
> Relatedly,
qiongsiwu wrote:
> thanks! Mostly lg with a pending discussion on whether we want to have test
> coverage for `clang_pgogen` in `compiler-rt/test/profile/instrprof-api.c`,
> and the open-ended discussion about the observed build failure in another
> compiler-rt test.
Thanks for the feedback!
@@ -0,0 +1,16 @@
+// Test the linker feature that treats undefined weak symbols as null values.
+
+// RUN: %clang_pgogen -o %t %s
qiongsiwu wrote:
Ah no worries! I actually tried running this on AIX and the test is
unsupported. I think compiler-rt
[checks](http
@@ -0,0 +1,38 @@
+// RUN: %clang_profgen %s --target=ppc64le-unknown-linux-gnu -S \
+// RUN:-emit-llvm -o - | FileCheck %s --check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
qiongsiwu wrote:
Ah thanks for
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/12] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/13] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
qiongsiwu wrote:
I realized one problem during testing IRPGO (thanks again for the suggestion
@minglotus-6 !).
A functions control flow may change between `-fprofile-generate` and
`-fprofile-use` when we make use of definitions in the new header. For example,
one may have the following code:
qiongsiwu wrote:
Landing this PR. It seems that the format error is not caused by any changes in
this PR.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qiongsiwu wrote:
> Breaks https://lab.llvm.org/buildbot/#/builders/127/builds/60635 Please fix
> or revert.
Thanks for reporting the problem @vitalybuka !
I don't have a Windows machine to reproduce the issue. It is not clear to me
how the IR can contain names like `"??_C@_0BA@MIKMMAII@rawpr
qiongsiwu wrote:
> Sometimes godbolt output (like https://godbolt.org/z/MxbjcnanW) could be
> faster and more convenient (e.g., there is no need to get windows executable
> to for debugging, only LLVM IR is needed).
Thanks for the pointer! Yup godbolt can indeed reproduce IR quite well.
https
Author: Qiongsi Wu
Date: 2022-05-11T14:48:40-04:00
New Revision: 3ca6328637b3f42096c652e4df53282649956bdb
URL:
https://github.com/llvm/llvm-project/commit/3ca6328637b3f42096c652e4df53282649956bdb
DIFF:
https://github.com/llvm/llvm-project/commit/3ca6328637b3f42096c652e4df53282649956bdb.diff
LO
Author: Qiongsi Wu
Date: 2022-05-20T12:29:10-04:00
New Revision: 1f12718ccfd660f01ac0e444d4632cf8ce6b98e2
URL:
https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2
DIFF:
https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2.diff
LO
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/78285
https://github.com/llvm/llvm-project/pull/76471 caused buildbot failure on
Windows. For more details, see
https://github.com/llvm/llvm-project/issues/77546.
This PR revises the test and relands
https://gith
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/78285
>From d64fabb3911ae6990a87729a2477df32c837fb1f Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Fri, 12 Jan 2024 11:45:50 -0500
Subject: [PATCH 1/2] Reland https://github.com/llvm/llvm-project/pull/76471
---
.
qiongsiwu wrote:
> thanks for the fix!
>
> One test `Clang :: Preprocessor/init.c` failed
> (https://lab.llvm.org/buildbot/#/builders/74/builds/24843) and the error is
> due to mismatched macros (if I'm reading correctly wants `__LONG_LONG_MAX__`
> right after `__LLONG_WIDTH__` but sees `__LL
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/78285
>From ebae7155814ad83ebd1a0159b86550c14c72b2b6 Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Fri, 12 Jan 2024 11:45:50 -0500
Subject: [PATCH 1/2] Reland https://github.com/llvm/llvm-project/pull/76471
---
.
qiongsiwu wrote:
It seems that either the precommit CI has some problems, or there are existing
`compiler-rt` breakages. https://github.com/llvm/llvm-project/pull/78037 is
also failing the same test cases. The changes in #78037 does not look harmful
either. I took a brief look at the current b
qiongsiwu wrote:
Ok I think I have a good theory on why these tests are failing. Most likely the
test machine does not have the latest `lld` during the test. If we build `lld`
together with the project, these tests pass.
https://github.com/llvm/llvm-project/pull/78285
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/78285
>From ebae7155814ad83ebd1a0159b86550c14c72b2b6 Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Fri, 12 Jan 2024 11:45:50 -0500
Subject: [PATCH 1/3] Reland https://github.com/llvm/llvm-project/pull/76471
---
.
qiongsiwu wrote:
Thanks for to comments/suggestions @w2yehia ! The test is modified so that
1. The profile files are generated.
2. The test does not support Windows to avoid known limitations on Windows.
https://github.com/llvm/llvm-project/pull/78285
_
qiongsiwu wrote:
Hi @vitalybuka ! I am landing this PR. The precommit CI failures do not seem to
related to changes in this PR. Please let me know if you see failures and I
will revert. Thanks so much!
https://github.com/llvm/llvm-project/pull/78285
___
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qiongsiwu wrote:
> This patch broke both the
> [Solaris/sparcv9](https://lab.llvm.org/buildbot/#/builders/72/builds/2015)
> and [Solaris/amd64](https://lab.llvm.org/staging/#/builders/94/builds/394)
> buildbots.
>
> If it really requires recent `lld`, this is guaranteed to not work: `lld`
>
qiongsiwu wrote:
@w2yehia I think a reasonable way to go forward is to remove the testing of
`__llvm_orderfile_dump` from the main test, and add a separate test that runs
only on Darwin.
What do you think?
https://github.com/llvm/llvm-project/pull/78285
_
qiongsiwu wrote:
@w2yehia and I discussed, and we will remove `__llvm_orderfile_dump` from the
main test for now.
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
qiongsiwu wrote:
https://github.com/llvm/llvm-project/pull/79150 is posted to avoid calling
`_llvm_orderfile_dump()` in the test.
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
Author: Qiongsi Wu
Date: 2022-10-18T10:43:19-04:00
New Revision: 04615b695aadf5f3860e3be9631131518227f410
URL:
https://github.com/llvm/llvm-project/commit/04615b695aadf5f3860e3be9631131518227f410
DIFF:
https://github.com/llvm/llvm-project/commit/04615b695aadf5f3860e3be9631131518227f410.diff
LO
Author: Qiongsi Wu
Date: 2022-10-20T15:16:31-04:00
New Revision: f911598bd440182b1383aa570de66a574d468a42
URL:
https://github.com/llvm/llvm-project/commit/f911598bd440182b1383aa570de66a574d468a42
DIFF:
https://github.com/llvm/llvm-project/commit/f911598bd440182b1383aa570de66a574d468a42.diff
LO
Author: Qiongsi Wu
Date: 2022-10-22T11:09:03-04:00
New Revision: bdd11bbace5ee74036912a534ff5a7e07dd102de
URL:
https://github.com/llvm/llvm-project/commit/bdd11bbace5ee74036912a534ff5a7e07dd102de
DIFF:
https://github.com/llvm/llvm-project/commit/bdd11bbace5ee74036912a534ff5a7e07dd102de.diff
LO
Author: Qiongsi Wu
Date: 2022-10-28T09:13:17-04:00
New Revision: fd448bbedce91bcc6aad9072af58a4fcb7f7bf70
URL:
https://github.com/llvm/llvm-project/commit/fd448bbedce91bcc6aad9072af58a4fcb7f7bf70
DIFF:
https://github.com/llvm/llvm-project/commit/fd448bbedce91bcc6aad9072af58a4fcb7f7bf70.diff
LO
Author: Qiongsi Wu
Date: 2022-09-27T14:50:41-04:00
New Revision: 86cd3535206d6db611260aae6f2869202eae4bb4
URL:
https://github.com/llvm/llvm-project/commit/86cd3535206d6db611260aae6f2869202eae4bb4
DIFF:
https://github.com/llvm/llvm-project/commit/86cd3535206d6db611260aae6f2869202eae4bb4.diff
LO
Author: Qiongsi Wu
Date: 2022-10-06T20:27:55-04:00
New Revision: b924c8c71daaa1bb869c42d9afca2a09a9b94629
URL:
https://github.com/llvm/llvm-project/commit/b924c8c71daaa1bb869c42d9afca2a09a9b94629
DIFF:
https://github.com/llvm/llvm-project/commit/b924c8c71daaa1bb869c42d9afca2a09a9b94629.diff
LO
Author: Qiongsi Wu
Date: 2022-10-12T15:57:46-04:00
New Revision: ec94f372d1c13b40029519a50184258d4de24a13
URL:
https://github.com/llvm/llvm-project/commit/ec94f372d1c13b40029519a50184258d4de24a13
DIFF:
https://github.com/llvm/llvm-project/commit/ec94f372d1c13b40029519a50184258d4de24a13.diff
LO
https://github.com/qiongsiwu approved this pull request.
LGTM! Thanks!
https://github.com/llvm/llvm-project/pull/67853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/67853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Qiongsi Wu
Date: 2023-08-15T10:10:03-04:00
New Revision: 611ce24114aac1befac6e65d85b0daa721cf71fd
URL:
https://github.com/llvm/llvm-project/commit/611ce24114aac1befac6e65d85b0daa721cf71fd
DIFF:
https://github.com/llvm/llvm-project/commit/611ce24114aac1befac6e65d85b0daa721cf71fd.diff
LO
Author: Qiongsi Wu
Date: 2023-07-11T13:24:09-04:00
New Revision: 0b66b3417c026e145708d0e20bfd05a72e79f12a
URL:
https://github.com/llvm/llvm-project/commit/0b66b3417c026e145708d0e20bfd05a72e79f12a
DIFF:
https://github.com/llvm/llvm-project/commit/0b66b3417c026e145708d0e20bfd05a72e79f12a.diff
LO
Author: Qiongsi Wu
Date: 2023-07-12T13:22:02-04:00
New Revision: 41447f6fdfe4d67bbd130bc6035e66f3fa1ebeff
URL:
https://github.com/llvm/llvm-project/commit/41447f6fdfe4d67bbd130bc6035e66f3fa1ebeff
DIFF:
https://github.com/llvm/llvm-project/commit/41447f6fdfe4d67bbd130bc6035e66f3fa1ebeff.diff
LO
Author: Qiongsi Wu
Date: 2023-08-30T19:20:17-04:00
New Revision: a6e6abd76cd31011f7685bda2c95ac6468df4f65
URL:
https://github.com/llvm/llvm-project/commit/a6e6abd76cd31011f7685bda2c95ac6468df4f65
DIFF:
https://github.com/llvm/llvm-project/commit/a6e6abd76cd31011f7685bda2c95ac6468df4f65.diff
LO
Author: Qiongsi Wu
Date: 2022-11-30T10:22:26-05:00
New Revision: 3faab85c12bc1d96e144dcb6d8f75bcafa120c79
URL:
https://github.com/llvm/llvm-project/commit/3faab85c12bc1d96e144dcb6d8f75bcafa120c79
DIFF:
https://github.com/llvm/llvm-project/commit/3faab85c12bc1d96e144dcb6d8f75bcafa120c79.diff
LO
Author: Qiongsi Wu
Date: 2023-05-15T11:31:00-04:00
New Revision: 9715af434579022b5ef31781be40b722d7e63bee
URL:
https://github.com/llvm/llvm-project/commit/9715af434579022b5ef31781be40b722d7e63bee
DIFF:
https://github.com/llvm/llvm-project/commit/9715af434579022b5ef31781be40b722d7e63bee.diff
LO
Author: Qiongsi Wu
Date: 2023-05-15T12:54:09-04:00
New Revision: 80cf56ea1bae05298a823b96b6b545ebca33b44a
URL:
https://github.com/llvm/llvm-project/commit/80cf56ea1bae05298a823b96b6b545ebca33b44a
DIFF:
https://github.com/llvm/llvm-project/commit/80cf56ea1bae05298a823b96b6b545ebca33b44a.diff
LO
Author: Qiongsi Wu
Date: 2023-05-16T09:41:24-04:00
New Revision: 1b1f1b9079e2f01f963c6c7cd766d67029ba87cb
URL:
https://github.com/llvm/llvm-project/commit/1b1f1b9079e2f01f963c6c7cd766d67029ba87cb
DIFF:
https://github.com/llvm/llvm-project/commit/1b1f1b9079e2f01f963c6c7cd766d67029ba87cb.diff
LO
Author: Qiongsi Wu
Date: 2022-12-13T10:18:44-05:00
New Revision: 1fdbe5c573b920f00e5bfdbcea0e837833ae77a0
URL:
https://github.com/llvm/llvm-project/commit/1fdbe5c573b920f00e5bfdbcea0e837833ae77a0
DIFF:
https://github.com/llvm/llvm-project/commit/1fdbe5c573b920f00e5bfdbcea0e837833ae77a0.diff
LO
Author: Qiongsi Wu
Date: 2022-12-15T10:55:26-05:00
New Revision: de8deb5189c948db89c753ff2dff65b8e7840e8b
URL:
https://github.com/llvm/llvm-project/commit/de8deb5189c948db89c753ff2dff65b8e7840e8b
DIFF:
https://github.com/llvm/llvm-project/commit/de8deb5189c948db89c753ff2dff65b8e7840e8b.diff
LO
qiongsiwu wrote:
> > Thank you! However, we're getting pretty late in the release cycle and so
> > I'd like to see this backed out of 19.x ASAP (and given the direction the
> > discussion is going, I think it should be backed out of main as well).
>
> @qiongsiwu will you be able to get these c
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/102919
https://github.com/llvm/llvm-project/pull/99888 added a specific diagnostic for
`#pragma mc_func` on AIX. There are some disagreements on:
1. If the check should be on by default. Leaving the check off by def
qiongsiwu wrote:
https://github.com/llvm/llvm-project/pull/102919 is created to revert this
feature now. I will review our discussion and consider an improved
implementation. Thanks again for the input and discussion!
https://github.com/llvm/llvm-project/pull/101336
__
https://github.com/qiongsiwu milestoned
https://github.com/llvm/llvm-project/pull/102919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/102919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qiongsiwu wrote:
/cherry-pick 123b6fc
https://github.com/llvm/llvm-project/pull/102919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qiongsiwu closed
https://github.com/llvm/llvm-project/pull/99888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qiongsiwu wrote:
Thanks for chiming in and describing your concern @AaronBallman !
We think this feature should be in the community clang for the following
reasons.
1. It is useful for a community `clang` user on AIX to be aware of uses of
`#pragma mc_func` in their code. The community `cla
qiongsiwu wrote:
> this same logic can be applied to almost every pragma we don't support, but
> we don't want to add special handlers for every pragma we don't support.
> It doesn't seem particularly dangerous to ignore this pragma because ignoring
> it means no symbol is generated for the sy
qiongsiwu wrote:
> Is that not the case?
It does not seem so. See
[here](https://godbolt.org/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:___c,selection:(endColumn:40,endLineNumber:8,positionColumn:40,positionLineNumber:8,selectionStartColumn:40,selectionSta
qiongsiwu wrote:
> I'm wondering why this option isn't on by default for AIX. I don't think
> anyone is going to know to turn this option on, whereas if it's on by
> default, users have to make a decision as to how to proceed, which seems like
> the better default.
Yes I agree. This is at th
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/101336
https://github.com/llvm/llvm-project/pull/99888 added a check (and
corresponding options) to flag uses of `#pragma mc_func` on AIX.
This PR turns on the check by default.
>From e823d1e7eb3357fc5c15b614ac5f
qiongsiwu wrote:
> My preference is for this to be on-by-default (then it shows its utility),
> and I'd like to see those changes in the 19.x release (which means we'd need
> to turn this around fairly quickly as we've already put out rc1).
Sounds good! Thanks again for your input @AaronBallma
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/101336
>From e823d1e7eb3357fc5c15b614ac5fd94d331ac630 Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 31 Jul 2024 10:12:59 -0400
Subject: [PATCH 1/2] Turn on mc_func check by default.
---
clang/include/clang/D
@@ -562,7 +562,7 @@ void AIX::addClangTargetOptions(
CC1Args.push_back("-fno-sized-deallocation");
if (Args.hasFlag(options::OPT_ferr_pragma_mc_func_aix,
- options::OPT_fno_err_pragma_mc_func_aix, false))
+ options::OPT_fno_err_pragma_
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/101336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 211 matches
Mail list logo
