[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: ahatanak. plotfi added a comment. @ahatanak @mwyman @rjmccall @dmaclach I am going to work on a version of this patch where the visibility can be encoded into the objc_direct attribute. Does that seem reasonable to do from here? Repository: rG LLVM Github Monorepo

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak @rjmccall I think the decision tree goes 1. Do we change the existing visibility behavior of objc methods? Yes / No 2. If we leave hidden as the default do we change the behavior for objc_direct? Yes / No 3. If we leave objc_direct as hidden by default do we

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3812068 , @ahatanak wrote: > In D86049#3806898 , @plotfi wrote: > >> 1. Do we change the existing visibility behavior of objc methods? Yes / No > > I don't think we want to change t

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3812068 , @ahatanak wrote: > In D86049#3806898 , @plotfi wrote: > >> 1. Do we change the existing visibility behavior of objc methods? Yes / No > > I don't think we want to change t

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation = [ObjCD

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3814111 , @ahatanak wrote: > In D86049#3812412 , @plotfi wrote: > >> In D86049#3812068 , @ahatanak wrote: >> >>> In D86049#3806898

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462944. plotfi added a comment. Updated based on @ahatanak's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clan

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/AST/Mangle.cpp clang/lib/Cod

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @dmaclach @ahatanak @mwyman How do things look from here? Do you want something for properties as well or would it be ok if we did this in a later commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://rev

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 463064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/C

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3818435 , @mwyman wrote: > In D86049#3816006 , @plotfi wrote: > >> @dmaclach @ahatanak @mwyman How do things look from here? Do you want >> something for properties as well or woul

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:371 + OS << (MD->isInstanceMethod() ? '-' : '+'); + OS << (MD->hasMethodVisibilityDefault() ? '<' : '['); if (const auto *CID = MD->getCategory()) { ahatanak wrote: > Sorry, I might have miss

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: kyulee1. plotfi added a comment. In D86049#3818923 , @ahatanak wrote: > In D86049#3818696 , @plotfi wrote: > >> In D86049#3818435 , @mwyman wrote:

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak I can revive some of what I was working on from https://reviews.llvm.org/D86049?id=285923 if we think we need a thunk for the checks as @rjmccall mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3819109 , @mwyman wrote: > In D86049#3818981 , @plotfi wrote: > >> @ahatanak I can revive some of what I was working on from >> https://reviews.llvm.org/D86049?id=285923 if we thin

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3821183 , @plotfi wrote: > In D86049#3819109 , @mwyman wrote: > >> In D86049#3818981 , @plotfi wrote: >> >>> @ahatanak I can revive some of

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. @ahatanak how does this diff look to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. LGTM but waiting on Akira would be nice imho. Comment at: clang/lib/CodeGen/CGObjC.cpp:1192 // corresponding gcc code. -llvm::Value *cmd = - Builder.CreateLoad(GetAddrOfLocalVar(getterMethod->getCmdDecl()), "cmd"); +if (getterMethod->is

[PATCH] D128249: Adding clone_attrs attribute.

plotfi created this revision. plotfi added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. plotfi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just experimental for the time being. Posti

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. This is pretty incomplete. Please ignore for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128249/new/ https://reviews.llvm.org/D128249 ___ cfe-commits mailing list cfe-commi

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. Thanks for the feedback on corner cases @aaron.ballman, this will give me more concrete things to think about here. At the moment I mainly thinking about a case: typedef int foo; enum : foo {} __attribute__((__clone_attrs_from__(foo))); This is mostly because of how

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. plotfi updated this revision to Diff 253314. plotfi added a comment. Herald added a subscriber: wuzish. -U999 These file format changes have b

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253314. plotfi added a comment. Herald added a subscriber: wuzish. -U999 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/CompilerInvocation.c

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253360. plotfi added a comment. Changing some of the version checks. I don't think we need to have rigid checks considering this format is experimental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253367. plotfi added a comment. fixing linter errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Front

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253369. plotfi added a comment. Adding a better test to check the deprecated v1 format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/Compi

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254075. plotfi added a comment. Updating to change im about to land, to see what precommit changes show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/i

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254080. plotfi added a comment. Trying to fix precommit / clang tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/include/clang/Frontend/Fronte

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe3033c0ce551: [llvm][clang][IFS] Enhancing the llvm-ifs yaml format for symbol lists. (authored by plotfi). Repository:

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi created this revision. plotfi added reviewers: compnerd, manmanren. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. plotfi edited the summary of this revision. plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber: jfb.

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber: jfb.  Clipboard gave me junk the first submit. Sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files:

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254297. plotfi added a comment. Applying clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h clang/in

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, com

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for more decl types that need to be processable, as part of clang-ifs hardening. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG79e345fbcc82: [clang][IFS] Adds support for more decl types in clang interface stubs. (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D69995?vs=228383&id=228551#toc Repository:

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Up until now, clang interface stubs has replaced the standard PP -> C -> BE -> ASM -> LNK pipeline. With this change, it will happen in conjunction with it. So

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229699. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229698. plotfi added a comment. Adding test, and some additional features in the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/driver-test2.c:6 +// RUN: %clang -emit-interface-stubs -emit-merged-ifs \ +// RUN: driver-test2.o object.o weak.o -S -o - | FileCheck %s + I would use -

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229731. plotfi marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Interfa

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3500 + PL = CompilePhaseList; +} + compnerd wrote: > Do you use the `PhaseList` again? Why not `erase_if`? We tried this in getCompilationPhas

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229745. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Interfa

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229747. plotfi marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Interfa

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229973. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea00b51fe9: [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. Looking into it. This change also affected Green Dragon. Thanks for the heads up. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang :: Interface

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. I have a fix. About to push. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) > **

[PATCH] D70525: [clang][IFS][test] GreenDragon and Fuchsia Darwin bot fix: BindArchClass Nest.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a post commit review. If I can re-implement this in a nicer way I will do an NFC commit. On Darwin the clang driver does not invoke Driver::BuildActio

[PATCH] D70728: [clang][IFS] Adding support for new clang interface stubs decl types.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding support for NamespaceAliasDecl UnresolvedUsingTypenameDecl CXXDeductionGuideDecl ConstructorUsingShadowDecl Repository: rG LLVM Github Monorepo https

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows for -o to be used with -c when compiling with clang interface stubs enabled. This is because the second file will be an intermediate ifs stubs

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. I intend to add something like -Xifs, but for now if an InputArg is not a filename then I want to skip it. Repository: rG LLVM Github Mono

[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sometimes it is difficult to tell when you want your compile flags to be invoked with -emit-interface-stubs -c or with -emit-interface-stubs -emit-merged-ifs. O

[PATCH] D70728: [clang][IFS] Adding support for new clang interface stubs decl types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07e445103e36: [clang][IFS] Adding support for new clang interface stubs decl types. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70728

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ef9110b8d10: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/driver-test3.c:6 +// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs %s -o %t/driver-test3.o +// RUN: cat %t/driver-test3.ifs | FileCheck %s + -

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi updated this revision to Diff 232455. plotfi added a comment. Updating comments and altering test as per @cishida and @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70763/new/ https://reviews.llvm.org/D70763 Files: cla

[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

plotfi abandoned this revision. plotfi added a comment. This commit is no good. I got some wrong inspiration from a lot of the code claiming random args in the driver. abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70839/new/ https://re

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd694594d7650: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't chec

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't chec

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi abandoned this revision. plotfi added a comment. Abandoning. Duplicate diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71317/new/ https://reviews.llvm.org/D71317 ___ cfe-commits mailing list

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 233435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c clang/test/In

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1778834 , @compnerd wrote: > Should probably add a check for `__block` variables. I looked into it, I am not sure if anything special needs to be done for block. ie: echo "void f() { __block int x = 42; void (^sum)(i

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

plotfi added a comment. @thakis I got sidetracked by some other things and had not made more progress, if progress is not made yes I think -emit-interface-stubs should imply -fno-integrated-cc1 if that seems like the right thing to do to you. @erichkeane Thanks for filing the bugzilla bug. I wa

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

plotfi added a comment. Could this be reverted for the time being so that bots can go green? There appear to be an awful lot of commits piling up on top of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74372/new/ https://reviews.llvm.org

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

plotfi added a comment. In D74372#1873665 , @jdoerfert wrote: > In D74372#1873623 , @plotfi wrote: > > > Could this be reverted for the time being so that bots can go green? There > > appear to be an awful lot of c

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

plotfi added a comment. @MadCoder Could there be a way to mark objc_direct methods as something like __attribute__((visibility("default"))) or __declspec(dllexport) to denote that a given method should be directly callable but still retain the metadata to be called through an objc_msgSend from

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. Thanks for pinging on this @thegameg. I had been looking at this a day or two ago but got side-tracked. Will take another look. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. This appears to only happen with -fintegrated-cc1, with fno-integrated-cc1 it does not repro. Still looking into this. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dr

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

plotfi added a comment. In D69825#1831611 , @smeenai wrote: > CC @plotfi for the InterfaceStubs failures Thanks In D69825#1831611 , @smeenai wrote: > CC @plotfi for the InterfaceStubs failures @smeenai thanks

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. So, the culprit appears to be D69825 . The way InterfaceStubs assembles the pipeline appears to trigger an asan bug. For now I will alter the tests to get the bots green, but once I get my bugzilla access sorted I intend to file a bug. -P

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

plotfi added a comment. Why hasn't this patch landed in llvm.org? I see it on the github apple/master but not on llvm.org master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mail

<    1   2   3   4