plotfi added inline comments.
================
Comment at: clang/lib/AST/Mangle.cpp:371
+ OS << (MD->isInstanceMethod() ? '-' : '+');
+ OS << (MD->hasMethodVisibilityDefault() ? '<' : '[');
if (const auto *CID = MD->getCategory()) {
----------------
ahatanak wrote:
> Sorry, I might have missed the discussion, but what's the reason we need this
> change in mangling? Is it because the linker cannot handle the standard
> mangling scheme?
Yeah. These are for ld and dyld. Not having a preceding underscore and the
square brackets causes problems.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86049/new/
https://reviews.llvm.org/D86049
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
