[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

2018-02-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325746: FreeBSD driver / Xray flags moving pthread to compile flags. (authored by kamil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43378

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

2018-02-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325822: [OpenMP] Limit reduction support for pragma 'distribute' when combined with… (authored by cbertol, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D41102: Setup clang-doc frontend framework

2018-02-23 Thread Athos via Phabricator via cfe-commits
Athosvk added a comment. The change to USR seems like quite an improvement already! That being said, I do think that it might be preferable to opt out of the use of strings for linking things together. What we did with our clang-doc is that we directly used pointers to refer to other types. So

[PATCH] D43428: [CFG] [analyzer] NFC: Allow more complicated construction contexts.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325966: [CFG] [analyzer] NFC: Allow more complicated construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326014: [CFG] Provide construction contexts for lifetime-extended temporaries. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326014: [CFG] Provide construction contexts for lifetime-extended temporaries. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43477 Files: include/clang/Analy

[PATCH] D43480: [CFG] [analyzer] Add construction context when the constructor is treated like a functional cast.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326015: [CFG] Provide construction contexts for functional cast-like constructors. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D43481: [CFG] [analyzer] Add construction context when the constructor is being no-op-casted to a const value type.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326016: [CFG] Provide construction contexts for temporaries bound to const references. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43481 Files: lib/Analysi

[PATCH] D43483: [CFG] [analyzer] Add construction context when the constructor is on a branch of a ternary operator

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326019: [CFG] Provide construction contexts for temporaries in conditional operators. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D43483: [CFG] [analyzer] Add construction context when the constructor is on a branch of a ternary operator

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326019: [CFG] Provide construction contexts for temporaries in conditional operators. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43483 Files: lib/Analysis

[PATCH] D33393: [PATCH] Libcxxabi Demangler PR32890

2017-05-23 Thread marcel via Phabricator via cfe-commits
marcel abandoned this revision. marcel added a comment. Closed. Patch https://reviews.llvm.org/D33368 addresses PR32890 more comprehensively. https://reviews.llvm.org/D33393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

2017-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303718: [demangler] Fix a crash in the demangler during parsing of a lamdba (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33368?vs=99930&id=100041#toc Repository: rL LLVM h

[PATCH] D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics

2017-05-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303857: [X86] Adding avx512_vpopcntdq feature set and its intrinsics (authored by orenb). Changed prior to commit: https://reviews.llvm.org/D33170?vs=99685&id=100236#toc Repository: rL LLVM https://

[PATCH] D30837: [libcxx] Support for shared_ptr

2017-05-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303874: Add support for shared_ptr (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D30837?vs=97313&id=100251#toc Repository: rL LLVM https://reviews.llvm.org/D30837 Files:

[PATCH] D33178: Remove requirement for libunwind sources.

2017-05-25 Thread Shiz via Phabricator via cfe-commits
Shiz added a comment. @EricWF: Thanks for reviewing! Is there anything else I need to do at this point or will it be committed automatically? Repository: rL LLVM https://reviews.llvm.org/D33178 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303977: [clangd] Allow to use vfs::FileSystem for file accesses. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D33416?vs=100262&id=100389#toc Repository: rL LLVM https:/

[PATCH] D33637: [libcxxabi][demangler] Fix a exponential string copying bug

2017-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304113: [demangler] Fix a exponential string copying bug (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33637?vs=100568&id=100574#toc Repository: rL LLVM https://reviews.llv

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

2017-05-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304159: [analyzer] PthreadLockChecker: model failed pthread_mutex_destroy() calls. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D32449?vs=99970&id=100615#toc Repository:

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

2017-05-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304160: [analyzer] Initial commit for the upcoming refactoring of the IteratorChecker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D32592?vs=100239&id=100616#toc Reposito

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

2017-05-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304214: [clangd] Mark results of clangd requests with a tag provided by the… (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D33678?vs=100709&id=100711#toc Repository: rL L

[PATCH] D33661: [Sema][ObjC] Don't emit availability diagnostics for categories extending unavailable interfaces

2017-05-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304306: [Sema][ObjC] Don't emit availability diags for category @implementations (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33661?vs=100645&id=100869#toc Repository: rL L

[PATCH] D33711: [TableGen] Clang changes to support Record::getValueAsString and getValueAsListOfStrings returning StringRef instead of std::string

2017-05-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304326: [TableGen] Clang changes to support Record::getValueAsString and… (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D33711?vs=100826&id=100906#toc Repository: rL LLVM

[PATCH] D24371: Add diagnostics to require_constant_initialization

2017-06-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304451: [SemaCXX] Add diagnostics to require_constant_initialization (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D24371?vs=100949&id=101066#toc Repository: rL LLVM http

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

2017-06-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304459: [ubsan] Add a check for pointer overflow UB (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D33305?vs=100475&id=101078#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

2017-06-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304463: [Modules] Handle sanitizer feature mismatches when importing modules (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32724?vs=98371&id=101088#toc Repository: rL LLVM

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

2017-06-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304470: [CGDebugInfo] Finalize SubPrograms when we're done with them (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D33705?vs=101092&id=101107#toc Repository: rL LLVM http

[PATCH] D33597: [OpenCL] Fix pipe size in TypeInfo.

2017-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304708: [OpenCL] Fix pipe size in TypeInfo. (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D33597?vs=101236&id=101388#toc Repository: rL LLVM https://reviews.llvm.org/D3359

[PATCH] D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor.

2017-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304710: [analyzer] Nullability: fix notes around synthesized ObjC property accessors. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D32437?vs=100673&id=101392#toc Repositor

[PATCH] D33671: [analyzer] In plist alternate mode, don't add weird control flow pieces from ObjC property declarations to uses.

2017-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304713: [analyzer] Don't add arrow to the inlined function's decl when it has no body. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D33671?vs=100693&id=101396#toc Reposito

[PATCH] D33941: [Driver] Add test to cover case when LSan is not supported

2017-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304880: [Driver] Add test to cover case when LSan is not supported (authored by chefmax). Changed prior to commit: https://reviews.llvm.org/D33941?vs=101557&id=101672#toc Repository: rL LLVM https:/

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush updated this revision to Diff 101688. mharoush marked an inline comment as done. mharoush added a comment. Simplified the AsmRewrite condition in x86AsmParser. Some fixes to simplify the Intel State Machine immediate value rewrite treatment divergence. Repository: rL LLVM https://re

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush marked an inline comment as done. mharoush added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:722 + bool ParseIntelExpression(IntelExprStateMachine &SM, SMLoc &End, +bool &ReplaceEnumIdentifier); std::unique_ptr

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush updated this revision to Diff 101689. Repository: rL LLVM https://reviews.llvm.org/D33277 Files: lib/Sema/SemaStmtAsm.cpp test/CodeGen/x86-ms-inline-asm-enum_feature.cpp Index: lib/Sema/SemaStmtAsm.cpp === --- lib/Se

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush updated this revision to Diff 101693. mharoush added a comment. added struct case to the test Repository: rL LLVM https://reviews.llvm.org/D33277 Files: lib/Sema/SemaStmtAsm.cpp test/CodeGen/x86-ms-inline-asm-enum_feature.cpp Index: lib/Sema/SemaStmtAsm.cpp

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

2017-06-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305147: [clang] Implement -Wcast-qual for C++ (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D33102?vs=102119&id=102120#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

2017-06-12 Thread Matan via Phabricator via cfe-commits
mharoush updated this revision to Diff 102172. mharoush marked 6 inline comments as done. mharoush added a comment. Restored old test case for constant int folding and added check-label directives for each tester function. Repository: rL LLVM https://reviews.llvm.org/D33277 Files: lib/Sem

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-12 Thread Matan via Phabricator via cfe-commits
mharoush marked 3 inline comments as done. mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D33278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

2017-06-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305195: [Sema][C++1z] Ensure binding in dependent range for have non-null type (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D34096?vs=102149&id=102191#toc Repository: rL LLV

[PATCH] D33828: [analyzer] Don't crash when the code tries to construct an Objective-C object in AllocaRegion.

2017-06-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305211: [analyzer] Fix a crash when an ObjC object is constructed in AllocaRegion. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D33828?vs=101401&id=102206#toc Repository:

[PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

2017-06-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305216: [ubsan] Detect invalid unsigned pointer index expression (clang) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D33910?vs=101479&id=102214#toc Repository: rL LLVM h

[PATCH] D34106: [clangd] Use 'std::string' for VFSTag instead of 'int'

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305279: [clangd] Use 'std::string' for VFSTag instead of 'int' (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34106?vs=102189&id=102298#toc Repository: rL LLVM https://r

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305280: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34107?vs=102300&id=102301#toc Repository: rL LLV

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305291: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34146?vs=102328&id=102331#toc Repository: rL LLV

[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

2017-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305298: [clangd] Store references instead of unique_ptrs in ClangdServer. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34148?vs=102333&id=102344#toc Repository: rL LLVM

[PATCH] D34151: [clangd] Add a filename parameter to FileSystemProvider.

2017-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305376: [clangd] Add a filename parameter to FileSystemProvider. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34151?vs=102347&id=102508#toc Repository: rL LLVM https:/

[PATCH] D32428: Fix for Itanium mangler issue with templates (bug: 31405)

2017-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305377: Fix for Itanium mangler issue with templates (authored by dpolukhin). Changed prior to commit: https://reviews.llvm.org/D32428?vs=96380&id=102509#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

2017-06-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305546: [ubsan] PR33081: Skip the standard type checks for volatile (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34262?vs=102758&id=102778#toc Repository: rL LLVM https:

[PATCH] D34202: [clang-tidy] readability-function-size: fix nesting level calculation

2017-06-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305554: [clang-tidy] readability-function-size: fix nesting level calculation (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D34202?vs=102548&id=102813#toc Repository: rL

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-16 Thread wangxin via Phabricator via cfe-commits
wangxindsb created this revision. This implement a path-sensitive checker that warns if virtual calls are made from constructors and destructors. The checker use the GDM (generic data map) to store three integers in the program state for constructors, destructors and objects. Once enter one of

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-19 Thread Matan via Phabricator via cfe-commits
mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D33278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb updated this revision to Diff 103180. wangxindsb added a comment. Add test case for the patch https://reviews.llvm.org/D34275 Files: virtualcall.cpp Index: virtualcall.cpp === --- virtualcall.cpp +++ virtualcall.cpp @

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb added a comment. > I do not see any test cases for this patch. Could you add them as well? I add the test case just now. > How do you handle the following case? > > struct A { > A() { > X x; > x.virtualMethod(); // this virtual call is ok > } > } > int main(

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb added a comment. > What about: > > struct A { > A() { > X x; > x.virtualMethod(); // this virtual call is ok > foo(); // should warn here > } > virtual foo(); > } > int main() { > A a; > } > > > Does the checker warn on the second call? Yes,

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb updated this revision to Diff 103196. wangxindsb added a comment. Add test case for the virtual call checker. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp Index: test/Analysis/virtualcall.cpp

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb updated this revision to Diff 103199. wangxindsb added a comment. Add run line in the test case. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp Index: test/Analysis/virtualcall.cpp =

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305797: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse… (authored by akirtzidis). Changed prior to commit: https://reviews.llvm.org/D34263?vs=103067&id=103206#toc Repos

[PATCH] D34024: [OpenCL] Diagnose scoped address-space qualified variables

2017-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305798: [OpenCL] Diagnose scoped address-space qualified variables (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D34024?vs=101872&id=103207#toc Repository: rL LLVM https:/

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb marked 5 inline comments as done. wangxindsb added inline comments. Comment at: VirtualCallChecker.cpp:260 + if (SFC->inTopFrame()) { + const FunctionDecl *FD = SFC->getDecl()->getAsFunction(); +if (!FD) xazax.hun wrote: > The formatting seems to

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-20 Thread wangxin via Phabricator via cfe-commits
wangxindsb updated this revision to Diff 103214. wangxindsb added a comment. Correct some error in VirtualCallChecker.cpp. Complete the test case. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp Index: test/Analysis/vi

[PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

2017-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305862: Prevent devirtualization of calls to un-instantiated functions. (authored by ssrivastava). Changed prior to commit: https://reviews.llvm.org/D22057?vs=71432&id=103273#toc Repository: rL LLVM

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

2017-06-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305890: Moved code hanlding precompiled preamble out of the ASTUnit. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34287?vs=103216&id=103338#toc Repository: rL LLVM htt

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

2017-06-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305896: [analyzer] LocalizationChecker: Support new localizable APIs. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D34266?vs=102771&id=103347#toc Repository: rL LLVM ht

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305900: [analyzer] Bump a few default performance thresholds. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D34277?vs=102816&id=103349#toc Repository: rL LLVM https://re

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-21 Thread wangxin via Phabricator via cfe-commits
wangxindsb added a comment. > Oh, I think I see how it works now. How about: > > > struct A; > struct X { > void callFooOfA(A*); > }; > struct A { > A() { > X x; > x.virtualMethod(); // this virtual call is ok > x.callFooOfA(this) > } > virtual foo();

[PATCH] D34502: [analyzer] Do not continue to analyze a path if the constraints contradict with builtin assume

2017-06-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305991: [analyzer] Do not continue to analyze a path if the constraints contradict with… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34502?vs=103540&id=103544#toc Repository

[PATCH] D33565: [WebAssembly] Add default -allow-undefined-file to linker args

2017-06-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306074: [WebAssembly] Add default -allow-undefined-file to linker args (authored by sbc). Changed prior to commit: https://reviews.llvm.org/D33565?vs=103130&id=103668#toc Repository: rL LLVM https:/

[PATCH] D34562: [MSP430] Fix data layout string.

2017-06-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306161: [MSP430] Fix data layout string. (authored by dambrouski). Changed prior to commit: https://reviews.llvm.org/D34562?vs=103751&id=103771#toc Repository: rL LLVM https://reviews.llvm.org/D3456

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

2017-06-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306163: [ubsan] Improve diagnostics for return value checks (clang) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34299?vs=103632&id=103774#toc Repository: rL LLVM https:

[PATCH] D34563: [ubsan] Disable the object-size check at -O0

2017-06-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306181: [ubsan] Disable the object size check at -O0 (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34563?vs=103778&id=103796#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-24 Thread wangxin via Phabricator via cfe-commits
wangxindsb updated this revision to Diff 103832. wangxindsb added a comment. Add license to VirtualCallChecker.cpp https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp Index: test/Analysis/virtualcall.cpp ==

[PATCH] D32638: [x86][inline-asm][clang]Amend size directive deduction mechanism of unsized memory operands

2017-06-26 Thread coby via Phabricator via cfe-commits
coby abandoned this revision. coby added a comment. superseded by https://reviews.llvm.org/rL302179 Repository: rL LLVM https://reviews.llvm.org/D32638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D41217: [Concepts] Concept Specialization Expressions

2017-12-13 Thread changyu via Phabricator via cfe-commits
changyu added inline comments. Comment at: lib/AST/ExprCXX.cpp:1481 +if (E.isInvalid() || Trap.hasErrorOccurred()) { +// C++2a [temp.constr.atomic]p1 +// ...If substitution results in an invalid type or expression, the You have four spaces o

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-13 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. In https://reviews.llvm.org/D40671#954661, @alexfh wrote: > In https://reviews.llvm.org/D40671#953888, @aaron.ballman wrote: > > > FWIW, I think we should do something about unknown check names in NOLINT > > comments, but that can be done as a follow-up patch. If we're igno

[PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

2017-12-14 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. In https://reviews.llvm.org/D39622#954585, @probinson wrote: > Philosophically, mangled names and DWARF information serve different > purposes, and I don't think you will find one true solution where both of > them can yield the same name that everyone will be happy with.

[PATCH] D41189: [Frontend] Treat function with skipped body as definition

2017-12-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320696: [Frontend] Treat function with skipped body as definition (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41189?vs=126787&id=126932#toc Repository:

[PATCH] D40488: [clangd] Implemented tracing using Context

2017-12-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320706: [clangd] Implemented tracing using Context (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D40488 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D40489: [clangd] Changed tracing interfaces

2017-12-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320708: [clangd] Changed tracing interfaces (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D40489?vs=126957&id=126959#toc Repository: rCTE Clang Tools Ext

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

2017-12-14 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. Ping? The patch is ready to go, just needs a final approval... https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

2017-12-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320751: [debuginfo] Remove temporary FIXME. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41259?vs=127019&id=127025#toc Repository: rC Clang https://review

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

2017-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320804: [clang] Add PPCallbacks list to preprocessor when building a preacompiled… (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D39375?vs=126984&id=127092#to

[PATCH] D41149: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920)

2017-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320902: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920) (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41149?vs=126854&id=127220#toc Repository

[PATCH] D41073: Wasm: add support in libcxx

2017-12-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320925: [libcxx] Add WebAssembly support (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D41073?vs=127242&id=127251#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-16 Thread Anton via Phabricator via cfe-commits
xgsa created this revision. xgsa added reviewers: aaron.ballman, alexfh. xgsa added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. As discussed in the previous review [1], diagnostics about incorrect usage of NOLINT comment was added, i.e..: - usage of NOLINT wit

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-16 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 127260. xgsa added a comment. A few minor coding style fixes. https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test/clang-tidy/nolint-usage.cpp test/cl

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-16 Thread Anton via Phabricator via cfe-commits
xgsa marked 3 inline comments as done. xgsa added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339 std::unique_ptr OptionsProvider) : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), + Profile(nullptr), E

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-17 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 127267. xgsa added a comment. Review comments were applied. https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test/clang-tidy/nolint-usage.cpp test/clan

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-17 Thread Anton via Phabricator via cfe-commits
xgsa added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339 std::unique_ptr OptionsProvider) : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), + Profile(nullptr), xgsa wrote: > Eugene.Zelenko wrote: > >

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-17 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 127268. xgsa added a comment. Review comments applied. https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test/clang-tidy/nolint-usage.cpp test/clang-tid

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-17 Thread JVApen via Phabricator via cfe-commits
JVApen added a comment. I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas) https://reviews.llvm.org/D41326 ___

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-17 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. In https://reviews.llvm.org/D41326#957749, @JVApen wrote: > I'm missing some documentation to understand the corner cases. How does this > check behave with suppressed warnings for checks which ain't currently > checked. (Using -no-... on a code base or suppressing the war

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

2017-12-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321060: Teach clang/NetBSD about additional dependencies for sanitizers (authored by kamil, committed by ). Repository: rC Clang https://reviews.llvm.org/D41054 Files: lib/Driver/ToolChains/CommonAr

[PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

2017-12-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321128: [analyzer] Fix a crash during C++17 aggregate construction of base objects. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D40841?vs=125629&id=127624#t

[PATCH] D41253: [analyzer] WIP: trackNullOrUndefValue: track last store to symbolic pointers.

2017-12-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321130: [analyzer] trackNullOrUndefValue: track last store to non-variables. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41253 Files: lib/StaticAnalyzer/Co

[PATCH] D41258: [analyzer] trackNullOrUndefValue: deduplicate path pieces for each node.

2017-12-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321135: [analyzer] De-duplicate path diagnostics for each exploded graph node. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41258 Files: include/clang/Stati

[PATCH] D41237: [Frontend] Handle skipped bodies in template instantiations

2017-12-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321174: [Frontend] Handle skipped bodies in template instantiations (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41237 Files: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D41365: [clang] Add BeforeExecute method to PrecompiledPreamble

2017-12-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321189: [clang] Add BeforeExecute method to PrecompiledPreamble (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41365?vs=127715&id=127740#toc Repository: rC

[PATCH] D40700: [ubsan] Diagnose noreturn functions which return (compiler-rt)

2017-12-20 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL321232: [ubsan] Diagnose noreturn functions which return (compiler-rt) (authored by vedantk, committed by ). Changed prio

[PATCH] D40698: [ubsan] Diagnose noreturn functions which return

2017-12-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321231: [ubsan] Diagnose noreturn functions which return (authored by vedantk, committed by ). Repository: rC Clang https://reviews.llvm.org/D40698 Files: docs/UndefinedBehaviorSanitizer.rst lib/C

[PATCH] D40700: [ubsan] Diagnose noreturn functions which return (compiler-rt)

2017-12-20 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCRT321232: [ubsan] Diagnose noreturn functions which return (compiler-rt) (authored by vedantk, committed by ). Herald adde

[PATCH] D40381: Parse concept definition

2017-12-21 Thread changyu via Phabricator via cfe-commits
changyu marked 6 inline comments as done. changyu added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7735 + ActOnDocumentableDecl(NewDecl); + CurContext->addDecl(NewDecl); + return NewDecl; faisalv wrote: > Why not use 'PushOnScopeChains' onto the en

<    5   6   7   8   9   10   11   12   13   14   >