xgsa added inline comments.
================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339 std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider) : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), + Profile(nullptr), ---------------- xgsa wrote: > Eugene.Zelenko wrote: > > Please use default members initialization for DiagEngine and Profile. > Actually, it is not necessary, as unique_ptr is initialized with nullptr by > default. I have just removed initializing them here. Sorry, you are right, just ignore my previous comment. https://reviews.llvm.org/D41326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits