[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. That works because the argument list is just tok::identifier and TT_StartOfName so if we see StartOfName we are going to return true identifier will simply be skipped round the loop `` int Test(A a) {} AnnotatedTokens(L=0): M=0 C=0 T=Unknown S=1 B=0 BK=0 P=

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. of course, this isn't legal int TestFn(A=1) { return a; } and, would see the TT_StartOfName for (a) and would break int TestFn(A a = 1) { return a; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.or

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. In D59309#1428970 , @klimek wrote: > In D59309#1428969 , @MyDeveloperDay > wrote: > > > That works because the argument list is just tok::identifier and > > TT_StartOfName > > > Sho

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. In D59309#1428970 , @klimek wrote: > In D59309#1428969 , @MyDeveloperDay > wrote: > > > That works because the argument list is just tok::identifier and > > TT_StartOfName > > > Sho

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rC356148: Objective-C++11: Support static_assert() in @interface/@implementation ivar… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D59327: [Sema] Fix a use-after-free of a _Nonnull ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rL356187: [Sema] Fix a use-after-free of a _Nonnull ParsedAttr (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Pulling this revision down to build it caused build issues with missing SBBLO_Always, could you investigate before committing? Comment at: lib/Form

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. @to-miz do you have permission to commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 190737. MyDeveloperDay added a comment. Remove non related clang-format changes run git clang-format Add a Microsoft style (trying to match most closely the more traditional Microsoft style used for C#) This will allow, CSharp to be added to the confi

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356222: [analyzer] Support C++17 aggregates with bases without constructors. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59123: [analyzer] RetainCount: Fix a crash when a function follows retain/autorelease naming convention but takes no arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356223: [analyzer] RetainCount: A function isn't a CFRetain if it takes no arguments. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59123?vs=189807&id=190762

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 190789. LegalizeAdulthood added a comment. Herald added a subscriber: jdoerfert. To avoid passing lots of state to/from extracted functions, extract a class instead and use member variables for most of the state CHANGES SINCE LAST ACTION https:/

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. From what I can tell this looks OK as you seem to be mainly only passing down the boolean, my guess is that while most people don't use the -lines directly that often but it pr

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. So @russellmcc you've been bumping along this road nicely for 6 months, doing what people say... pinging every week or so in order to get your code reviewed, and you are getti

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, reuk, JonasToth, alexfh, krasimir, russellmcc. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. An addendum to D59087: [clang-format] [PR25010] AllowShortIfStatementsOn

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

MyDeveloperDay added a comment. > nobody being able to make changes Nobody IS able to make changes, but not because of complexity! We discourage away potential contributors/maintainers by leaving their reviews for weeks/months/years, not just not letting them in, not even discussing them.. M

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

This revision was automatically updated to reflect the committed changes. Closed by commit rL356250: Make getFullyQualifiedName qualify both the pointee and class type for member… (authored by d0k, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a warning is raised from the expansion of a system macro that involves pasted token, there was still situations were they were not skip

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

This revision was automatically updated to reflect the committed changes. Closed by commit rL356261: [clangd] Tune the fuzzy-matching algorithm (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356277: [HIP-Clang] propagate -mllvm options to opt and llc (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D59316?vs=190474&id=190850#toc Repository: rC

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. I'm happy to be wrong, but In current master, SpaceBeforeCpp11BracedList is a boolean not an enum (but I think I've seen a review changing it somewhere which maybe isn't landed) https://reviews.llvm.org/source/llvm-github/browse/master/clang/include/clang/Format

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > I'm sorry for not having a positive answer here, but I'm not in favor of this > change. The style rule looks like it introduces arbitrary complexity at a > point where I don't understand at all how it matters. We cannot possibly > support all style guides that

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker created this revision. Tyker added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. attributes after an if like: if (...) [[likely]] are now applied on the if instead of the following statement. i added the likely attribute in the necessary

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191031. Tyker added a comment. i added tests as you requested. i didn't add test for the codegen as it wasn't affected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/Basic/Attr.

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191034. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Parse/Par

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191035. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Parse/Par

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker marked an inline comment as done. Tyker added a comment. I added the sema testes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. if likely/unlikely can be applied to any statement or label what should be generated when it is applied to a statement that don't have any conditional branch ? should it be ignored without warning or error ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added inline comments. Comment at: include/clang/Format/Format.h:1578 /// \endcode bool SpaceBeforeCpp11BracedList; boolean here not enum see comment below Comment at: lib/Format/TokenAnnotator.cpp:2608 +(Style.Sp

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > I don't think risk is what matters - in the end it's about cost, and cost is > a very technical reason I'm really sorry I'm not trying to be difficult its just over the years I keep seeing this being said in reviews? but what is the cost? I assume you don't

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191115. Tyker added a comment. i think we are suppose to hook likely/unlikely on builtin_expected, for if, for, while, switch. but i have no idea how we could hook it if we need to support catch. i added a revision with likely/unlikely and the correct semanti

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC356397: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D58797?vs=190549&id=191142#toc Repository: rC Cl

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rC356423: [X86] Add gcc rotate intrinsics to ia32intrin.h (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D59346?vs=190943&id=191189#toc Repository: rC Clang CH

[PATCH] D59529: Refactor cast<>'s in if conditionals, which can only assert on failure.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356441: Refactor cast<>'s in if conditionals, which can only assert on failure. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D59529?vs=191228&id=191248#toc Re

[PATCH] D59440: add steps to preprocess file and reduce command line args

serge-sans-paille added inline comments. Comment at: clang/utils/creduce-clang-crash.py:45 + result = [] + for i, arg in enumerate(cmd): +if arg.startswith('$'): Useless enumerate here. You could even use a list comprehension here ``` return ' '.join(arg i

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JonasToth, aaron.ballman, alexfh, michaelplatings. MyDeveloperDay added a project: clang-tools-extra. Herald added subscribers: jdoerfert, xazax.hun. While testing clang-tidy for D59251: [Documentation] Proposal for plan to ch

[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

MyDeveloperDay added subscribers: mitchellwills, mprobst. MyDeveloperDay added a comment. ping @mprobst,@mitchellwills noticed you just reviewed another clang-format-js commit, wondered if you were interested in reviewing this for me?, finding it hard to get any review traction. CHANGES SINCE

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (landed here too https://github.com/mydeveloperday/clang-experimental/releases) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55170/new/ https://reviews.llvm.org

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC356450: [OpenCL] Improved testing of default header. (authored by stulova, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5948

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, JonasToth, reuk. MyDeveloperDay added a project: clang-tools-extra. Sometime after 6.0.0 and the current trunk 9.0.0 the following code would be considered as objective C and not C++ Reported by: https://twitt

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. In D59540#1434837 , @JonasToth wrote: > What happens on `[=]() ...`, direct capture `[&Columns]()...` and > `[Columns]()...`? Thanks for the review... in answer to your que

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay updated this revision to Diff 191311. MyDeveloperDay added a comment. Minor modification to improve the `[=]` case `[&Columns]` and `[Columns]` are not yet fixed and will not be correctly renamed to `[&columns]` and `[columns]` But at least they are left unaltered CHANGES SINCE

[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC356475: [Sema] Adjust addr space of reference operand in compound assignment (authored by stulova, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Repository: rC Clan

[PATCH] D59544: [OpenCL] Minor improvements in default header testing

This revision was automatically updated to reflect the committed changes. Closed by commit rL356479: [OpenCL] Minor improvements in default header testing (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay updated this revision to Diff 191365. MyDeveloperDay added a comment. Address review comments This may not be a more satisfactory solution but it at least now covers the other cases raised by @JonasToth Add more tests around this area. CHANGES SINCE LAST ACTION https://review

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: test/clang-tidy/readability-identifier-naming.cpp:509 +// CHECK-FIXES: {{^}} bool columns=false; + auto ptr=[&]{return Columns;}(); +// CHECK-FIXES: {{^}} auto ptr=[&]{return col

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

This revision was automatically updated to reflect the committed changes. Closed by commit rC356515: Add a spelling of pass_object_size that uses __builtin_dynamic_object_size (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D58757?vs=190917&id=191386#toc R

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191408. Tyker added a comment. Herald added a subscriber: jdoerfert. added diagnostics for contradictory attributes like for if: if (...) [[likely]] return 1; else [[likely]] return 2; handled the codegen for If to generate builtin_expect but i pro

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein added a comment. Hello, can you please support with this Pull-Request? You really have better knowledge about source code. For our case this solution was working fine and I wanted to share with you. Maybe it will help you if I create an examplary project which reproduces the me

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein updated this revision to Diff 191415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp ==

[PATCH] D59554: gn build: Add build files for some clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356567: gn build: Add build files for some clang-tools-extra (authored by nico, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D59306: [NFC][clang][astdump] Some baseline tests for OpenMP

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL356569: [NFC][clang][astdump] Some baseline tests for OpenMP (authored by lebedevri, committed by ). Herald added a projec

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound state

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: include/clang/Basic/TokenKinds.h:80 K == tok::utf8_string_literal || K == tok::utf16_string_literal || - K == tok::utf32_string_literal; } klimek

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

This revision was automatically updated to reflect the committed changes. Closed by commit rC356575: [clang-format] structured binding in range for detected as Objective C (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D59

[PATCH] D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356580: [X86] Remove getCPUKindCanonicalName which is unused. (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SI

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. In D52150#1436423 , @to-miz wrote: > I checked out the git repository and applied the patch to head and reran all > tests. > The diff produced by git is basically the same, should I upload the new diff? I think you might

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191530. MyDeveloperDay added a comment. Addressing code review comment @klimek I think is what you meant, a much smaller and neater version of what I had before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llv

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191536. MyDeveloperDay added a comment. Sorry for the spam: - write this a little better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.org/D59309 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood marked 9 inline comments as done. LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:112 +process_output = e.output.decode() +print('%s failed:\n%s' % (' '.join(args), process_output)) +if raise_error: --

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > The cost is financial, as it's developer time, which costs real money to > companies. In the end, to support this, people like myself who are doing this > as part of their job spend time that they'd otherwise spend to make other > things better that might be mo

[PATCH] D59394: [Sema] De-duplicate some availability checking logic

This revision was automatically updated to reflect the committed changes. Closed by commit rL356599: [Sema] Deduplicate some availability checking logic (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. Herald added a subscriber: jdoerfert. In D56323#1350998 , @JonasToth wrote: > @LegalizeAdulthood your stuck on the commit right things right? If you want I > can commit for you (maybe even later) as you said you are limi

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(

[PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added a reviewer: serge-sans-paille. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18509/new/ https://reviews.llvm.org/D18509 _

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added subscribers: jdoerfert, mgorny. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 __

[PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added a subscriber: xazax.hun. Herald added a reviewer: serge-sans-paille. Review process takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17482/new/ ht

[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356609: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc. (authored by ctopper, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM.

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL356613: [clang-format] BeforeHash added to IndentPPDirectives (authored by paulhoad, committed by ). Herald added a projec

[PATCH] D59573: [analyzer] C++17: PR41142: Ignore transparent InitListExprs when finding construction contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356634: [CFG] [analyzer] pr41142: C++17: Skip transparent InitListExprs in constructors. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

MyDeveloperDay added inline comments. Herald added a project: LLVM. Comment at: cfe/trunk/unittests/Format/FormatTest.cpp:78 EXPECT_EQ(Expected.str(), format(Code, Style)); if (Style.Language == FormatStyle::LK_Cpp) { // Objective-C++ is a superset of C++, so eve

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 191649. MyDeveloperDay added a comment. Addressing Review Comments - Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer to support verbatim interpolated strings C# 6) - For the most part the need to for them is removed by mer

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59629/new/ https://reviews.llvm.org/D59629 __

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

MyDeveloperDay added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1079 if (Style.Language == FormatStyle::LK_Proto && Line.Level == 0 && -CurrentToken->is(Keywords.kw_option)) { +(CurrentToken->is(Keywords.kw_option) || + CurrentToken->i

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 191654. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address comment nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 Files: clang/docs/ClangFormat.rst clan

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:19 + +class FormatTestCSharp : public ::testing::Test { +protected: klimek wrote: > If everything's static, you don't need a test fixture at all, you can just > make it

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

This revision was automatically updated to reflect the committed changes. Closed by commit rC356662: [clang-format] Add basic support for formatting C# files (authored by paulhoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D58404?vs=191654&id=191669#toc Repository: rC

[PATCH] D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356674: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher. (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL356675: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL356676: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356689: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove… (authored by ctopper, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356706: [Driver] Pass -malign-double from the driver to the cc1 command line (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL356709: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D59566?vs=1

[PATCH] D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, mprobst, reuk, JonasToth. MyDeveloperDay added a project: clang-tools-extra. Import sorting of java file, incorrectly move import statement to after a function beginning with the word import. Make 1 character

[PATCH] D59683: [Tooling] Avoid working-dir races in AllTUsToolExecutor

This revision was automatically updated to reflect the committed changes. Closed by commit rL356743: [Tooling] Avoid working-dir races in AllTUsToolExecutor (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191862. Tyker added a comment. handled codegen for if, while, for and do/while, it will generate a @llvm.expect before the condition based on the attribute i changed slithly the semantic if (...) { //error [[likely]] ... } if (...) [[likely]] { //

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. about the semantic issue. we will need for diagnostics purposes to detect attribute in branches during the semantic phase. so where and how can we store this information in the AST so that the CodeGen doesn't have to look through branches again for this attributes ? CHA

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. @lebedev.ri Are we talking about a general ideology of the long term cost to allow any new things in? or to not allow things in this specific case? because in this specific case all the changes are based on what is really a single clause that was already there be

[PATCH] D57571: [clang-tidy] A new OpenMP module

This revision was automatically updated to reflect the committed changes. Closed by commit rL356800: [clang-tidy] A new OpenMP module (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356802: [clang-tidy] openmp-exception-escape - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D59466?vs=191911&id=191929#toc Repository: rCTE

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356799: [NFC] ExceptionEscapeCheck: small refactoring (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59650/new/ http

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356801: [clang-tidy] openmp-use-default-none - a new check (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D57113?vs=191918&id=191927#toc Repository: rCTE

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

This revision was automatically updated to reflect the committed changes. Closed by commit rL356833: [clang-format] correctly format protobuf fields named "enum". (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59627/new/ https://reviews.llvm.org/D59627 __

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356834: Clang-format: add finer-grained options for putting all arguments on one line (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356835: [clang-format] Keep protobuf "package" statement on one line (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rC356842: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre, committed by ). Changed prior to commit: https://reviews.llvm.org/D58186?vs=192002&id=1920

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 192004. Tyker added a comment. i implemented the semantic the changes for if for, while and do while statement and the AST change to if. can you review it and tell me if it is fine so i implement the rest. i didn't update the test so they will fail. CHANGES

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 192012. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticS

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. @riccibruno Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

<    12   13   14   15   16   17   18   19   20   21   >