MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land.
From what I can tell this looks OK as you seem to be mainly only passing down the boolean, my guess is that while most people don't use the -lines directly that often but it probably gets called by some of the formatting tools that work over selections, maybe something like git-clang-format Assuming you have tested some of those usescase and run the FormatTests, then we should be able to apply the "Beyonce rule" for everything else. (I've actually run the tests with your patch and they are fine) If that is the case then this LGTM (but I'm not the code owner, just someone wanting to help with these stranded reviews) I've landed this patch in my fork (which contains list of desired patches which seem to never get landed here..) https://github.com/mydeveloperday/clang-experimental IMHO @russellmcc clang-format needs people like you who understand the internals, to help move along some of the reviews that just get stuck in no mans land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
